From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 29978 invoked by alias); 20 Oct 2011 00:12:20 -0000 Received: (qmail 29964 invoked by uid 22791); 20 Oct 2011 00:12:19 -0000 X-SWARE-Spam-Status: No, hits=-2.4 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from rcsinet15.oracle.com (HELO rcsinet15.oracle.com) (148.87.113.117) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 20 Oct 2011 00:11:55 +0000 Received: from acsinet21.oracle.com (acsinet21.oracle.com [141.146.126.237]) by rcsinet15.oracle.com (Switch-3.4.4/Switch-3.4.4) with ESMTP id p9K0Brfw031067 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Thu, 20 Oct 2011 00:11:54 GMT Received: from acsmt356.oracle.com (acsmt356.oracle.com [141.146.40.156]) by acsinet21.oracle.com (8.14.4+Sun/8.14.4) with ESMTP id p9K0BqkV005203 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Thu, 20 Oct 2011 00:11:52 GMT Received: from abhmt115.oracle.com (abhmt115.oracle.com [141.146.116.67]) by acsmt356.oracle.com (8.12.11.20060308/8.12.11) with ESMTP id p9K0BkaS026723; Wed, 19 Oct 2011 19:11:46 -0500 Received: from [192.168.1.4] (/79.51.25.230) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Wed, 19 Oct 2011 17:11:46 -0700 Message-ID: <4E9F66CC.3050604@oracle.com> Date: Thu, 20 Oct 2011 01:06:00 -0000 From: Paolo Carlini User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:7.0.1) Gecko/20110929 Thunderbird/7.0.1 MIME-Version: 1.0 To: Gabriel Dos Reis CC: Jason Merrill , "gcc-patches@gcc.gnu.org" Subject: Re: [C++ Patch] PR 48630 (PR 31423) References: <4E9F4265.6080809@oracle.com> <4E9F4FEA.6050107@redhat.com> <4E9F5F0C.1050607@oracle.com> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-IsSubscribed: yes Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org X-SW-Source: 2011-10/txt/msg01807.txt.bz2 On 10/20/2011 02:00 AM, Gabriel Dos Reis wrote: > I believe the effect of your new patch is that if will > always emit the suggest "did you forget "()"?" for member functions, > even in the case where the current suggestion is correct. > Using the type context would prevent that regression. If you could give some guidance about the way to implement this, I may try over the next few days, otherwise probably I will have to give up for now (I assigned myself other PRs already), but it would be a pity, this PR has been reported 2 times by different people, apparently it's quite misleading. Anyway, I'm not assigned to the bug, even if I will not be able to actually help, it would be nice if you could attach to the audit trail a couple of nasty examples beyond what already considered in the analyses therein (both PRs) Thanks! Paolo.