From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 11646 invoked by alias); 20 Oct 2011 03:07:05 -0000 Received: (qmail 11628 invoked by uid 22791); 20 Oct 2011 03:07:04 -0000 X-SWARE-Spam-Status: No, hits=2.8 required=5.0 tests=BAYES_00,BOTNET,RCVD_IN_DNSWL_NONE,RP_MATCHES_RCVD,TW_CX,TW_DC X-Spam-Check-By: sourceware.org Received: from vms173005pub.verizon.net (HELO vms173005pub.verizon.net) (206.46.173.5) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 20 Oct 2011 03:06:49 +0000 Received: from [192.168.1.11] ([unknown] [108.15.31.125]) by vms173005.mailsrvcs.net (Sun Java(tm) System Messaging Server 7u2-7.02 32bit (built Apr 16 2009)) with ESMTPA id <0LTC001UFGN24VA1@vms173005.mailsrvcs.net>; Wed, 19 Oct 2011 22:06:39 -0500 (CDT) Message-id: <4E9F903E.6000702@verizon.net> Date: Thu, 20 Oct 2011 06:45:00 -0000 From: Ed Smith-Rowland <3dw4rd@verizon.net> User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:7.0.1) Gecko/20110929 Thunderbird/7.0.1 MIME-version: 1.0 To: Benjamin Kosnik Cc: libstdc++@gcc.gnu.org, gcc-patches@gcc.gnu.org Subject: Re: [v3] tr2: bool_set, dynamic_bitset, ratio References: <20111019154823.631acb66@shotwell> In-reply-to: <20111019154823.631acb66@shotwell> Content-type: text/plain; charset=ISO-8859-1; format=flowed Content-transfer-encoding: 7bit Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org X-SW-Source: 2011-10/txt/msg01813.txt.bz2 On 10/19/2011 06:48 PM, Benjamin Kosnik wrote: > Hi Edward! > > I have reviewed and selectively merged your development > branch, libstdcxx-tr2-ideas-branch, into trunk. As ISO C++ is now > looking at new library efforts for TR2 (and N2965 has already been > checked in to trunk) I thought it well-timed. > > Please check my work, patch attached. > > On libstdcxx-tr2-ideas-branch, I found: > > 1) N1718 + extensions for polynomial. > 2) N2136 bool_set > 3) N2050 dynamic_bitset > 4) ratio extensions for binary > 5) cmath extensions > 6) C++0x rope > > Of these, I selected 2, 3, and 4 for merging. > > It is sad to leave N1718 unmerged, I think there is a lot of good work > here and frankly see N1744 (marked with open status for LWG) as a weaker > candidate. But it's hard for me to justify putting this in given that it > was explicitly rejected by LWG. Perhaps you have current status or > thoughts? > > For the rope extensions, I would suggest just adding C++0x bits to > ext/rope, instead of making tr2/rope. > > The additions look interesting but I just saw declarations and > no actual implementation so I punted. > > I would encourage you to continue working on TR2 projects! This > future work can now proceed on mainline, without a special branch. > > tested x86_64/linux > > -benjamin > > > > > > Wow! Thank you for putting these in! I was going to take a look at these during 4.8 but this is a nice surprise! The ones I'd most like to look at are real and integer. Stroustrup and others have often expressed a wish for multiprecision maths in the library wish list. I don't know if there is a paper yet. I also did rational using the gmp library. I'm wondering if rational should be a template class that could take any integral type - of which integer could be one - like boost rational. I think I like that solution better. I was also debating if we should make these multiprecision classes allocator aware. I tend to think so. Anyway, I'll take a look at the tr2 stuff that you checked in. I hadn't considered constexpr, nullptr, noexcept because they weren't in place in g++ when I did all this. Also, with and typelist we might be able to get pretty easily (although I haven't looked at it). That would be really cool. Thanks, Ed