public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Paolo Carlini <paolo.carlini@oracle.com>
To: Jason Merrill <jason@redhat.com>
Cc: "gcc-patches@gcc.gnu.org" <gcc-patches@gcc.gnu.org>
Subject: Re: [C++ Patch / RFC] PR 50870
Date: Thu, 27 Oct 2011 00:01:00 -0000	[thread overview]
Message-ID: <4EA88F7B.3060706@oracle.com> (raw)
In-Reply-To: <4EA88E3A.4010808@redhat.com>

On 10/27/2011 12:48 AM, Jason Merrill wrote:
> On 10/26/2011 06:20 PM, Paolo Carlini wrote:
>> I re-opened this one because: 1- We may want to fix it in 4_6-branch
>> too, it's a regression there too; 2- We are still handling incorrectly
>> the template impl case. For the latter a variant of my old idea still
>> works, fwiw.
>
>> -    object_type = TREE_TYPE (object);
>> +    object_type = (TREE_CODE (object) == ARROW_EXPR
>> +               ? TREE_OPERAND (object, 0) : TREE_TYPE (object));
> This is still wrong.  Why not use the same patch for 4.6 as for trunk?
I don't understand, sorry: both mainline and 4_6-branch do not handle 
correctly both testcases, template impl and not. If you want to look 
into it personally, I can unassign myself, no problem, really.

Paolo.

  reply	other threads:[~2011-10-26 22:54 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-10-26 15:28 Paolo Carlini
2011-10-26 16:25 ` Jason Merrill
2011-10-26 17:12   ` Paolo Carlini
2011-10-26 18:15     ` Jason Merrill
2011-10-26 22:54       ` Paolo Carlini
2011-10-26 23:23         ` Paolo Carlini
2011-10-27  0:00         ` Jason Merrill
2011-10-27  0:01           ` Paolo Carlini [this message]
2011-10-27  0:02             ` Paolo Carlini
2011-10-27  7:38               ` Jason Merrill
2011-10-27 12:34                 ` Paolo Carlini
2011-10-27 13:16                   ` Jason Merrill
2011-10-27 13:19                     ` Paolo Carlini
2011-10-27 13:20                       ` Jason Merrill
2011-10-27 14:56                         ` Paolo Carlini
2011-10-27 23:29                           ` Paolo Carlini
2011-10-28  1:44                             ` Paolo Carlini
2011-10-28  2:00                               ` Paolo Carlini
2011-10-28 16:59                                 ` Jason Merrill
2011-10-28 17:00                                   ` Paolo Carlini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4EA88F7B.3060706@oracle.com \
    --to=paolo.carlini@oracle.com \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=jason@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).