From: Andrew MacLeod <amacleod@redhat.com>
To: Richard Henderson <rth@redhat.com>
Cc: gcc-patches@gcc.gnu.org, jakub@redhat.com
Subject: Re: [cxx-mem-model][PATCH 0/9] Convert i386 to new atomic optabs.
Date: Sat, 29 Oct 2011 17:28:00 -0000 [thread overview]
Message-ID: <4EAC1712.3080905@redhat.com> (raw)
In-Reply-To: <1319774858-9181-1-git-send-email-rth@redhat.com>
On 10/28/2011 12:07 AM, Richard Henderson wrote:
> This exposed a wealth of problems in code that has heretofore never
> been tested. The fourth patch makes certain that all expansions of
> compare-and-swap go through a single routine.
>
> I've tested the whole series with and without the last patch. So
> that I've tested both the sync_ and atomic_ paths. I've not attempted
> to test if both are present. I rather assume that'll never be the
> case for any target.
Excellent. The code is written to always check first for the new atomic
patterns, and use them if present. If it works with either one present,
it should be fine with both, should it ever happen... but we can leave
that until some person actually decides that needs to happen :-)
Thanks for exercising and fixing that untested code path. now other
targets should be easier to convert too.
Andrew
prev parent reply other threads:[~2011-10-29 15:09 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-28 4:08 Richard Henderson
2011-10-28 4:08 ` [PATCH 7/9] Update omp for " Richard Henderson
2011-10-28 4:08 ` [PATCH 3/9] Introduce and use can_compare_and_swap_p Richard Henderson
2011-10-28 4:08 ` [PATCH 2/9] Handle expanding insns with 8 operands Richard Henderson
2011-10-28 4:08 ` [PATCH 1/9] Fix thinko in gen_mem_thread_fence operand Richard Henderson
2011-10-28 5:11 ` [PATCH 6/9] Update cppbuiltins for atomic-compare-and-swap Richard Henderson
2011-10-28 5:11 ` [PATCH 9/9] Update ChangeLogs Richard Henderson
2011-10-28 5:20 ` [PATCH 8/9] Convert i386 backend to new atomic patterns Richard Henderson
2011-10-28 5:30 ` [PATCH 5/9] Add missing atomic optab initializations Richard Henderson
2011-10-28 5:40 ` [PATCH 4/9] Rewrite all compare-and-swap in terms of expand_atomic_compare_and_swap Richard Henderson
2011-10-28 11:29 ` [cxx-mem-model][PATCH 0/9] Convert i386 to new atomic optabs Jakub Jelinek
2011-10-28 15:25 ` Richard Henderson
2011-10-29 17:28 ` Andrew MacLeod [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4EAC1712.3080905@redhat.com \
--to=amacleod@redhat.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=jakub@redhat.com \
--cc=rth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).