From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 9093 invoked by alias); 4 Nov 2011 18:14:58 -0000 Received: (qmail 9084 invoked by uid 22791); 4 Nov 2011 18:14:57 -0000 X-SWARE-Spam-Status: No, hits=-7.5 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,RP_MATCHES_RCVD,SPF_HELO_PASS,TW_CX X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 04 Nov 2011 18:14:41 +0000 Received: from int-mx01.intmail.prod.int.phx2.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id pA4IEedW009053 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Fri, 4 Nov 2011 14:14:40 -0400 Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199]) by int-mx01.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id pA4IEewQ027460; Fri, 4 Nov 2011 14:14:40 -0400 Received: from [10.3.113.8] ([10.3.113.8]) by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id pA4IEcha004356; Fri, 4 Nov 2011 14:14:39 -0400 Message-ID: <4EB42B8E.2010907@redhat.com> Date: Fri, 04 Nov 2011 18:17:00 -0000 From: Jeff Law User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:7.0) Gecko/20110927 Thunderbird/7.0 MIME-Version: 1.0 To: Andrew MacLeod CC: gcc-patches Subject: Re: cxx-mem-model merge [6 of 9] - libstdc++-v3 References: <4EB328D7.9010309@redhat.com> In-Reply-To: <4EB328D7.9010309@redhat.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-IsSubscribed: yes Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org X-SW-Source: 2011-11/txt/msg00630.txt.bz2 -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 On 11/03/11 17:50, Andrew MacLeod wrote: > These are the changes to libstdc++ to make use of the new atomics. > I changed the files to use the new atomics, and bkoz did a > shuffling of the include file layout to better suit the new c++ > approach. > > previously, libstdc++ provided a locked implementation in > atomic_0.h with the theory that eventually it would be used. The > new scheme involves leaving non-lock-free implementations to an > external library. This involved removing the old lock > implementation and restructuring things now that multiple > implementation dont have to be supported. SO a lot fo this is > churn... 2 include files deleted and one merged into another one.. Is there an ABI/API impact to all this churn? Or was the atomic_0.h stuff never used? Was it an exposed API or strictly internal? I get the impression that is_lock_free wasn't ever defined, which is probably good in this context. Given these are primarily Benjamin's changes, I'm going to defer to his wisdom :-) If he doesn't chime in, ping him directly. jeff -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.11 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iQEcBAEBAgAGBQJOtCuOAAoJEBRtltQi2kC7M34H/2B9f1DsPE9oK5DfvHYyclxZ hvFGlSnw5r9q7UGsWrCGDd/J4mmkXOJMHMfpzjowuWUYUYDNZ5b2FuZ9fMij2K5f wJOfN9wslWTNyafJb/hjVMEzy1dmCUB2YV4N0e5cy39lvfWfNzM/9EfYbz5UEQpO VCODtS0WbsSUTkt7HeDkD7U21mpSsn1fGx4gBJyBpODihIq7Qk4uFqGtvrKGve26 7Pi3aP64TQl3zwF2lAkOV4KgzPLQUv4RIWOiYuyzEf13XpfJivWPLTUkJqJka+lp 8W+LFOLl3ygnNUAe9ugwRNCE+agfHG+Hp7+l8ypCpWSsrBwJB8m7rY1sMDA2HJw= =E/Sj -----END PGP SIGNATURE-----