From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gcc-patches-return-307103-listarch-gcc-patches=gcc.gnu.org@gcc.gnu.org>
Received: (qmail 7602 invoked by alias); 7 Nov 2011 16:32:16 -0000
Received: (qmail 7592 invoked by uid 22791); 7 Nov 2011 16:32:15 -0000
X-SWARE-Spam-Status: No, hits=-7.0 required=5.0	tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,RP_MATCHES_RCVD,SPF_HELO_PASS,TW_TM
X-Spam-Check-By: sourceware.org
Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28)    by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 07 Nov 2011 16:32:00 +0000
Received: from int-mx01.intmail.prod.int.phx2.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11])	by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id pA7GW0QE018414	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK)	for <gcc-patches@gcc.gnu.org>; Mon, 7 Nov 2011 11:32:00 -0500
Received: from anchor.twiddle.net (vpn-225-162.phx2.redhat.com [10.3.225.162])	by int-mx01.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id pA7GVxr7014068;	Mon, 7 Nov 2011 11:31:59 -0500
Message-ID: <4EB807FF.3070300@redhat.com>
Date: Mon, 07 Nov 2011 16:41:00 -0000
From: Richard Henderson <rth@redhat.com>
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:7.0) Gecko/20110927 Thunderbird/7.0
MIME-Version: 1.0
To: Torvald Riegel <triegel@redhat.com>
CC: GCC Patches <gcc-patches@gcc.gnu.org>, Aldy Hernandez <aldyh@redhat.com>
Subject: Re: [trans-mem] Fix instantiation of transaction expressions.
References: <1320675134.18023.349.camel@triegel.csb>
In-Reply-To: <1320675134.18023.349.camel@triegel.csb>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-IsSubscribed: yes
Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
List-Id: <gcc-patches.gcc.gnu.org>
List-Archive: <http://gcc.gnu.org/ml/gcc-patches/>
List-Post: <mailto:gcc-patches@gcc.gnu.org>
List-Help: <mailto:gcc-patches-help@gcc.gnu.org>
Sender: gcc-patches-owner@gcc.gnu.org
X-SW-Source: 2011-11/txt/msg00993.txt.bz2

On 11/07/2011 06:12 AM, Torvald Riegel wrote:
>          stmt = begin_transaction_stmt (input_location, NULL, flags);
>          tmp = RECUR (TRANSACTION_EXPR_BODY (t));
> +        if (tmp)
> +          {
> +            /* No statements; handle this like an expression.  */

In which case I'm pretty sure you ought to check for non-null
TRANSACTION_EXPR_BODY first and not call begin_transaction_stmt.


r~