From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 12802 invoked by alias); 7 Nov 2011 16:56:55 -0000 Received: (qmail 12794 invoked by uid 22791); 7 Nov 2011 16:56:55 -0000 X-SWARE-Spam-Status: No, hits=-7.0 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,RP_MATCHES_RCVD,SPF_HELO_PASS X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 07 Nov 2011 16:56:39 +0000 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id pA7GuV4r026839 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Mon, 7 Nov 2011 11:56:31 -0500 Received: from anchor.twiddle.net (vpn-225-162.phx2.redhat.com [10.3.225.162]) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id pA7GuUCw005035; Mon, 7 Nov 2011 11:56:30 -0500 Message-ID: <4EB80DBE.9090009@redhat.com> Date: Mon, 07 Nov 2011 16:59:00 -0000 From: Richard Henderson User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:7.0) Gecko/20110927 Thunderbird/7.0 MIME-Version: 1.0 To: Sameera Deshpande CC: "gcc-patches@gcc.gnu.org" , "nickc@redhat.com" , Richard Earnshaw , "paul@codesourcery.com" , Ramana Radhakrishnan Subject: Re: [RFA/ARM][Patch 02/05]: LDRD generation instead of POP in A15 Thumb2 epilogue. References: <1318324138.2186.40.camel@e102549-lin.cambridge.arm.com> <1318324917.2186.52.camel@e102549-lin.cambridge.arm.com> <4E9720AA.20306@redhat.com> <1320659334.30897.88.camel@e102549-lin.cambridge.arm.com> In-Reply-To: <1320659334.30897.88.camel@e102549-lin.cambridge.arm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-IsSubscribed: yes Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org X-SW-Source: 2011-11/txt/msg01001.txt.bz2 On 11/07/2011 01:48 AM, Sameera Deshpande wrote: > >> >> >> I don't believe REG_FRAME_RELATED_EXPR does the right thing for >> anything besides prologues. You need to emit REG_CFA_RESTORE >> for the pop inside an epilogue. > > Richard, here is updated patch that uses REG_CFA_RESTORE instead of > REG_FRAME_RELATED_EXPR. > > > The patch is tested with check-gcc, check-gdb and bootstrap with no > regression. > > Ok for trunk? Ok by me re unwind info. r~