public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Jeff Law <law@redhat.com>
To: Jakub Jelinek <jakub@redhat.com>
Cc: gcc-patches <gcc-patches@gcc.gnu.org>
Subject: Re: RFA: New pass to delete unexecutable paths in the CFG
Date: Mon, 07 Nov 2011 19:14:00 -0000	[thread overview]
Message-ID: <4EB82C17.2030606@redhat.com> (raw)
In-Reply-To: <20111107100700.GH27375@tyan-ft48-01.lab.bos.redhat.com>

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 11/07/11 03:07, Jakub Jelinek wrote:
> On Mon, Nov 07, 2011 at 02:55:02AM -0700, Jeff Law wrote:
>> [ Working virtually from Hawaii tonight...  :-) ]
> 
> ;)
> 
>> You might legitimately wonder how often this triggers.   A GCC
>> 4.6.0 checking-enabled compiler sees a .64% codesize improvement
>> from this optimization.  That's an awful lot of unexecutable
>> code.  The NULL references come from the VEC implementation and a
>> variety of other sources.
> 
> I'd say it is a good idea, though I wonder if the gate shouldn't 
> also use && flag_delete_null_pointer_checks or at least if the
> default for this new option shouldn't be based on
> flag_delete_null_pointer_checks. -fno-delete-null-pointer-checks is
> documented for quite some time as an option which allows NULL
> pointer dereferences (and AFAIK AVR uses it) and people who use
> that option will most likely want to disable this optimization
> too.
Yea, I'd been back and forth on this too -- I don't like gating on the
null-pointer-check flag, but I agree that folks using
- -fno-delete-null-... probably aren't going to want the new
optimization either.

I'll put on my thinking cap and see if I can come up with a good name
that encompasses both classes of optimization without getting overly
broad.

jeff
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iQEcBAEBAgAGBQJOuCwXAAoJEBRtltQi2kC7I6UH/2PRnCZxPCHvImghz8IN3ThX
IANY9jCSqRzzsebWtTwZ9Y0XE6uQhMpEx/98/ZFZ96OC8rrQkoYR+Jf4DOAP82ja
SMDpBETK6BZ7Y/bMKgzJA/QfIlxIcRNScGqZg+F+C3WPqJADHAxCmWGqx/c4/Mwz
aylaEBVi/7klqxpmxlkSeN6n0whXf8zL/XmTovpro/6B3oiJaVd1diyrJl3s9vL4
BwjvsbA8ZosLPVCcdLY+9OWjhlnwbOxQQ/xzN8g7knPGNVhe4pXaBmzNiPXGKzrN
1qteyLNdVvnOWj/h1w9a3Ew2EJ3eLUXTytM5BjDfA3gF9Jd1umN81Js+Z/sBRXA=
=W7V6
-----END PGP SIGNATURE-----

  parent reply	other threads:[~2011-11-07 19:06 UTC|newest]

Thread overview: 31+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-11-07  9:58 Jeff Law
2011-11-07 10:19 ` Jakub Jelinek
2011-11-07 10:21   ` Richard Guenther
2011-11-07 10:30     ` Richard Guenther
2011-11-07 19:20       ` Jeff Law
2011-11-07 16:14     ` Jeff Law
2011-11-07 16:30       ` Richard Guenther
2011-11-07 16:57         ` Kai Tietz
2011-11-07 19:03         ` Jeff Law
2011-11-08 11:50           ` Paolo Bonzini
2011-11-08 19:48             ` Jeff Law
2011-11-08 20:38               ` Paolo Bonzini
2011-11-08 20:59                 ` Jeff Law
2011-11-09  8:37                   ` Paolo Bonzini
2011-11-09 18:11                     ` Jeff Law
2011-11-09 18:12                       ` Jakub Jelinek
2011-11-09 22:45                       ` Paolo Bonzini
2011-11-10 19:27                         ` Jeff Law
2011-11-07 19:14   ` Jeff Law [this message]
2011-11-07 14:16 ` Tom Tromey
2011-11-07 15:54   ` Jeff Law
2011-11-07 15:54     ` Richard Guenther
2011-11-07 19:09       ` Jeff Law
2011-11-07 22:34         ` Richard Guenther
2011-11-08 20:02           ` Jeff Law
2011-11-09  9:50             ` Richard Guenther
2011-11-09 17:43               ` Jeff Law
2011-11-07 15:55     ` Tom Tromey
2011-11-07 17:01       ` Paolo Bonzini
2011-11-15  7:52         ` RFA: disable -fdelete-null-pointer-checks for Java Jeff Law
2011-11-07 19:05       ` RFA: New pass to delete unexecutable paths in the CFG Jeff Law

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4EB82C17.2030606@redhat.com \
    --to=law@redhat.com \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=jakub@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).