From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 24465 invoked by alias); 8 Nov 2011 17:32:07 -0000 Received: (qmail 24454 invoked by uid 22791); 8 Nov 2011 17:32:06 -0000 X-SWARE-Spam-Status: No, hits=-7.0 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,RP_MATCHES_RCVD,SPF_HELO_PASS X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 08 Nov 2011 17:31:54 +0000 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id pA8HVnB1025247 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Tue, 8 Nov 2011 12:31:49 -0500 Received: from anchor.twiddle.net (vpn-225-39.phx2.redhat.com [10.3.225.39]) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id pA8HVlrp002320; Tue, 8 Nov 2011 12:31:48 -0500 Message-ID: <4EB96781.4030409@redhat.com> Date: Tue, 08 Nov 2011 17:40:00 -0000 From: Richard Henderson User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:7.0) Gecko/20110927 Thunderbird/7.0 MIME-Version: 1.0 To: Pedro Alves CC: gcc-patches@gcc.gnu.org Subject: Re: Disable libitm if unsupported References: <4EB959F0.60301@redhat.com> <201111081726.24103.pedro@codesourcery.com> In-Reply-To: <201111081726.24103.pedro@codesourcery.com> Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: 7bit X-IsSubscribed: yes Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org X-SW-Source: 2011-11/txt/msg01213.txt.bz2 On 11/08/2011 09:26 AM, Pedro Alves wrote: > On Tuesday 08 November 2011 16:33:52, Richard Henderson wrote: >> toplevel/ >> * configure.ac: Adjust srcdir for running libitm/configure.tgt. > >> +# Disable libitm on unsupported hosted systems. >> +if test x$enable_libitm = x; then >> + AC_MSG_CHECKING([for libitm support]) >> + if (srcdir=${srcdir}/libitm; \ >> + . ${srcdir}/configure.tgt; \ > > This should check that libitm exists before sourcing the script, > as otherwise it will error out on src tree > checkouts (binutils, gdb, ...), given that the libitm directory > doesn't exist there. Should I bother with an explicit test, or just use "set -e"? r~