public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Dave Korn <dave.korn.cygwin@gmail.com>
To: Rainer Orth <ro@CeBiTec.Uni-Bielefeld.DE>
Cc: Christian Joensson <christian.joensson@gmail.com>,
	 gcc-patches@gcc.gnu.org, Kai Tietz <ktietz@redhat.com>
Subject: Re: Failure to bootstrap trunk with --enable-threads=posix on cygwin since r180767
Date: Tue, 08 Nov 2011 18:18:00 -0000	[thread overview]
Message-ID: <4EB97076.3000101@gmail.com> (raw)
In-Reply-To: <yddd3d3wzdr.fsf@manam.CeBiTec.Uni-Bielefeld.DE>

On 07/11/2011 18:39, Rainer Orth wrote:
> Christian Joensson <christian.joensson@ writes:
> 
>> xgcc: error: unrecognized command line option ‘-pthread’
> [...]
>> Note the --enable-threads=posix.
>>
>> Backing off to revision 180766 does not yield this problem, while
>> 180767 has the problem.
> 
> I erroneously moved the use of i386/t-mingw-pthread to the cygwin case.

  As I just discovered!

> The following patch should correct this.  Could you give it a try?

> 2011-11-07  Rainer Orth  <ro@
> 
> 	libgcc:
> 	* config.host (i[34567]86-*-cygwin*): Move i386/t-mingw-pthread ...
> 	(i[34567]86-*-mingw*): ... here.
> 	(x86_64-*-mingw*): ... here.

  That's not quite right (although it will probably work):

> @@ -605,6 +600,9 @@ i[34567]86-*-mingw*)
>  	  win32)
>  	    tmake_file="$tmake_file i386/t-gthr-win32"
>  	    ;;
> +	  posix)
> +	    tmake_file="i386/t-mingw-pthread $tmake_file"
> +	    ;;
>  	esac
>  	# This has to match the logic for DWARF2_UNWIND_INFO in gcc/config/i386/cygming.h
>  	if test x$enable_sjlj_exceptions = xyes; then
> @@ -626,6 +624,9 @@ x86_64-*-mingw*)
>  	  win32)
>  	    tmake_file="$tmake_file i386/t-gthr-win32"
>  	    ;;
> +	  posix)
> +	    tmake_file="i386/t-mingw-pthread $tmake_file"
> +	    ;;
>  	esac
>  	# This has to match the logic for DWARF2_UNWIND_INFO in gcc/config/i386/cygming.h
>  	if test x$enable_sjlj_exceptions = xyes; then

  Notice how in your additions, you prepend the t-mingw-pthread file to the
list in $tmake_file rather than append it as the existing code does.  Ordering
of t-* files in $tmake_file is significant as there may be overrides and files
should be listed from most generic to most target/os-specific, so please
adjust those two hunks to match the way it's already being done.

  OK with that change.

    cheers,
      DaveK

  reply	other threads:[~2011-11-08 18:10 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <CABxpwDkCOnjzoVmxjDpTe3xZqbcbQq_9k+x6B+KKswfGymSbbA@mail.gmail.com>
2011-11-07 18:54 ` Rainer Orth
2011-11-08 18:18   ` Dave Korn [this message]
2011-11-08 18:20     ` Rainer Orth
2011-11-08 18:39       ` Dave Korn
2011-11-08 18:36   ` Christian Jönsson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4EB97076.3000101@gmail.com \
    --to=dave.korn.cygwin@gmail.com \
    --cc=christian.joensson@gmail.com \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=ktietz@redhat.com \
    --cc=ro@CeBiTec.Uni-Bielefeld.DE \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).