From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 22481 invoked by alias); 10 Nov 2011 20:10:34 -0000 Received: (qmail 22464 invoked by uid 22791); 10 Nov 2011 20:10:32 -0000 X-SWARE-Spam-Status: No, hits=-7.2 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,RP_MATCHES_RCVD,SPF_HELO_PASS X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 10 Nov 2011 20:10:18 +0000 Received: from int-mx01.intmail.prod.int.phx2.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id pAAKAHJa008166 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Thu, 10 Nov 2011 15:10:17 -0500 Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199]) by int-mx01.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id pAAKAHFQ025964; Thu, 10 Nov 2011 15:10:17 -0500 Received: from [0.0.0.0] (ovpn-113-127.phx2.redhat.com [10.3.113.127]) by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id pAAKAFDZ014282; Thu, 10 Nov 2011 15:10:16 -0500 Message-ID: <4EBC2FA7.1000504@redhat.com> Date: Thu, 10 Nov 2011 20:25:00 -0000 From: Jason Merrill User-Agent: Mozilla/5.0 (X11; Linux i686; rv:7.0.1) Gecko/20111001 Thunderbird/7.0.1 MIME-Version: 1.0 To: Jonathan Wakely CC: gcc-patches Subject: Re: [patch] c++/2972 warn when ctor-initializer leaves uninitialized data References: <4EB851F2.4090107@redhat.com> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org X-SW-Source: 2011-11/txt/msg01462.txt.bz2 On 11/10/2011 02:48 PM, Jonathan Wakely wrote: > +warn_missing_meminits (tree type, tree cons) > +{ > + tree mem_inits = sort_mem_initializers (type, NULL_TREE); > + while (mem_inits) > + { > + tree member = TREE_PURPOSE (mem_inits); > + /* TODO do not warn if brace-or-equal-initializer */ > + warn_meminit_leaves_uninitialized (member, TREE_TYPE (member), cons); > + mem_inits = TREE_CHAIN (mem_inits); > + } > +} Check DECL_INITIAL (member) to tell if it has an NSDMI. Jason