From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx0a-00069f02.pphosted.com (mx0a-00069f02.pphosted.com [205.220.165.32]) by sourceware.org (Postfix) with ESMTPS id 798DE395C066 for ; Wed, 10 Apr 2024 19:38:29 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 798DE395C066 Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=oracle.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=oracle.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 798DE395C066 Authentication-Results: server2.sourceware.org; arc=pass smtp.remote-ip=205.220.165.32 ARC-Seal: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1712777920; cv=pass; b=FqiBDiqQru1tdtLqIonNT7arDuQKsEQZT1/Ffthfn7F3A34jxhbshOFBtgekcW4009RVVXI4RIxKpkxvgQ/9UpeDgX510nDEAfJe7TXthxg6Hvum4eQpBiaNOiBvRMSLdFF+wbm4tK8lrYM8EWHzxda881toQjDSArKUdfCSaWg= ARC-Message-Signature: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1712777920; c=relaxed/simple; bh=9vSuuHUufCfc5qhjc8CnoCUs3cjvQL+xXg9n48Syevk=; h=DKIM-Signature:DKIM-Signature:From:To:Subject:Date:Message-ID: MIME-Version; b=eNB88hw9EQIVnNe2pCFr2NmQ4ocHOwEGfmEezisgU68eF5F9DtT0J2M2mgBJQAI3BrGGc75qlQkUjo4zYQlY+GtXbKtYo/6MMJTdyWUP7f/+/Do9J0MOVYbBqrmXe+bkRy5LNiXg15tdTDKpaFHRFt3v0uK5vpcmIbTiajiHDfY= ARC-Authentication-Results: i=2; server2.sourceware.org Received: from pps.filterd (m0333521.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 43AJ4Kb9026561; Wed, 10 Apr 2024 19:38:27 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=from : to : cc : subject : date : message-id : references : in-reply-to : content-type : content-id : content-transfer-encoding : mime-version; s=corp-2023-11-20; bh=AgSqZkCQVL4oLS30nilqosyMDHwLokHNQKVkoBW2T2c=; b=INhylsxTb+fVMMbo9MJXiwh4OlBewdmtN+HNY0u+EdlEbUx2DohH0kJlL42qouuABZyj wM3LdMNGXoRUGmf/MjgMwaamCYTskgrMH7NULYp39pjiQEo0BU/lDUbgd5EC7cfhMhL8 +rL11+VoOS/bPrD99qJ53WtDJ3jg1HQf74BYxIbCYjkqRen31hzVw+gFotHq+gO0zQBg xUqbefwANPTGHtvKhIr3GL4uxACSwTzMa9oVf6CZ6tEFIlPx3oln++kesb3Vu6hfi4qb PKJzyKrSmRRcmLcIL2FFv++8SYwcPmuU8Pr0PS6xrXIu6w7JgPfxtCkojfaQc4CC26sW /g== Received: from phxpaimrmta02.imrmtpd1.prodappphxaev1.oraclevcn.com (phxpaimrmta02.appoci.oracle.com [147.154.114.232]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 3xawacr6e5-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 10 Apr 2024 19:38:27 +0000 Received: from pps.filterd (phxpaimrmta02.imrmtpd1.prodappphxaev1.oraclevcn.com [127.0.0.1]) by phxpaimrmta02.imrmtpd1.prodappphxaev1.oraclevcn.com (8.17.1.19/8.17.1.19) with ESMTP id 43AJ9Em6010733; Wed, 10 Apr 2024 19:38:26 GMT Received: from nam02-sn1-obe.outbound.protection.outlook.com (mail-sn1nam02lp2040.outbound.protection.outlook.com [104.47.57.40]) by phxpaimrmta02.imrmtpd1.prodappphxaev1.oraclevcn.com (PPS) with ESMTPS id 3xavu8mpn3-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 10 Apr 2024 19:38:26 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=fc4iRT6Hp4bz3FHgB2sX0jGyeFIjUejW0Yex3LjxzsP8Bp/Iqg/MEspIuQEqKs+cZqXUulBKMnnetJq+czM442A2rXJEBk9E5RsFHOQPz4I56mrHJxoprIjMZXS7Acr958Q7c4gwuNg2ELLHI/5cxDV4LDFvcLobpVOwfHqEmwCEpXgR7NL7J3KyEXJCG0LRkiDGaxY2+y6rHJ6e76Pnkq1WZNtTBd6X+FxiuDF0Yzw49rIsocP/OkRNRLTlGpO5hzunubb72uNlu7AHth1BOeR6Ojkcxyx7GNrV9fe24goSHpTBn0xp2NNJckDURLtHk7JvAppmxCJkd/WqxhiCKQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=AgSqZkCQVL4oLS30nilqosyMDHwLokHNQKVkoBW2T2c=; b=jQTUwSOmwGOm0joOEfV5ZorjRTQe/sQfPs6w37m+wRVrHX4ubehcESuatNf89GO2+UxlPaAkQIc2TQr5JCZqDf5obM8Ri0/a07fafqOw2thxFN7aafzk4DjiqfMifKg1zdP2Nxechg4f3dYeoZNoAFtw1Nj0rA04FJzwDK3NLLaOu29N+ov4KzHgLiRER/UW5UFEIrC6khXerwJDx35a5c9cC488z7sfXpzSq7hR/Zm7fgLXncXbgvCi1EWcNMgc9Dhbf3ghUswc6HpqLRvx+QEWoTSgZ67ve1jMaeHJg8Z+emXpnXa0383hQJSeRtzY5rNmWggBnQDxxTecKhF1Hw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=AgSqZkCQVL4oLS30nilqosyMDHwLokHNQKVkoBW2T2c=; b=t03WL5vBgawzQeNhBd/C0RRhx3OqddZXfvXGF9pc+CpylyAr3Lt5/Xj2mumccefHY7E4g9bDEcG33r42CmevxGH9FP3SeQhS8HMsQ2/svBCXct6/04pfmcNxuaz+JP2oJmct6aqBK+/FKOI2bdtQFsRl8JdJdGFk+zboj4NS/K0= Received: from CY8PR10MB6538.namprd10.prod.outlook.com (2603:10b6:930:5a::17) by SN7PR10MB7048.namprd10.prod.outlook.com (2603:10b6:806:347::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7409.46; Wed, 10 Apr 2024 19:38:24 +0000 Received: from CY8PR10MB6538.namprd10.prod.outlook.com ([fe80::2dae:7852:9563:b4bc]) by CY8PR10MB6538.namprd10.prod.outlook.com ([fe80::2dae:7852:9563:b4bc%6]) with mapi id 15.20.7409.042; Wed, 10 Apr 2024 19:38:24 +0000 From: Qing Zhao To: Joseph Myers CC: Richard Biener , Siddhesh Poyarekar , "uecker@tugraz.at" , Kees Cook , "isanbard@gmail.com" , "gcc-patches@gcc.gnu.org" Subject: Re: [PATCH v8 2/5] Convert references with "counted_by" attributes to/from .ACCESS_WITH_SIZE. Thread-Topic: [PATCH v8 2/5] Convert references with "counted_by" attributes to/from .ACCESS_WITH_SIZE. Thread-Index: AQHagfMqFyMaRicJ4UCLPaNWmgIfh7Fh6A6AgAARTQA= Date: Wed, 10 Apr 2024 19:38:24 +0000 Message-ID: <4F25B7BF-4497-4504-B72C-040B057CA66A@oracle.com> References: <20240329160703.4012941-1-qing.zhao@oracle.com> <20240329160703.4012941-3-qing.zhao@oracle.com> <4e305cb8-ae4e-301f-44fd-12de5e4811b@redhat.com> In-Reply-To: <4e305cb8-ae4e-301f-44fd-12de5e4811b@redhat.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: Apple Mail (2.3774.500.171.1.1) x-ms-publictraffictype: Email x-ms-traffictypediagnostic: CY8PR10MB6538:EE_|SN7PR10MB7048:EE_ x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: I8y8vpvnehrDTsIcsbUkbi0gxNapiMCGOo1U36VqwyE04/IoHqOZoHaSWwyH+r8EyKnp0OFoEPPRwvqr1SCiNbRQgYKJcdw+tTuFyw2HxuIXGA8eBOjOd+W+THVwYqb8l+/+CWJIs6Kfg9P4c+Wzw5AVbjRyipFEgRat8VfWVUGGyuhC5RTFePCvTtWYD9PDt9ET0BUCl0+CC8dgoN2W3zKooYNwNx220PNgW7LUV5tOT5zlhZ1T0POvymHNSbVEgrxYS7fh5MnkVrklpufw2UWJ683zfInXEwrgmwIPwOItzJzCJSlRKAQdaf7Z2BBhqqwpMkfqxsLlgSrvc9ivRUg1TOdNs1BRgvnIJd78nA1GyFTAVHjMk80eYC31crPW+iK3kUrbd7rFSa7cBDywBJYZNDV2oEqhhbhnQ0dn5KriwTrmkkv4IZ17VOkyeALpkOzbZW1XuP90x2rEpR4CJPZUpTDqgBEw1c7p2C6TsThAO6lIdh4CXR55ombrWQyTlMRaxSBzxGRFu0MV5bgS38eeAJ83ls089V18AjTVko6CrCXaqotggZkWfc00mD2YMIeEQbbNsKhncSj5oUTRFIuTco4tUCdbvGRN9JHjKmALqhdFye0eqNhMjiK4Wi1ToE/PQ+0//2DVVpD7l+9qTNQs7UDX9W17EBZy2oHm0Sg= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:CY8PR10MB6538.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230031)(376005)(1800799015)(366007);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?VsQgPM8wI6jRsID8vD3JIpB38Z87C4zX9XtypIhgnOlTBQIDdSHnMB3jIXF4?= =?us-ascii?Q?9ilbdkVvxgbE7RlXZloG/uvZEAAlI66dWZfX90kTFce3Uz2wNKyeWNS5jWCr?= =?us-ascii?Q?rInAQfd/CsYB1oP8nA72qDcsicN+Nx9/KLaxFpykAH5dtP7fY0dGFVRWHPq/?= =?us-ascii?Q?91+I/GUxAAvDtf0Sf0z/aSjngSp6ng0LfnQ8C9VtchgsahnOll9DwR+gnium?= =?us-ascii?Q?NCkblss/itC4uGOdl90HbqsxHmmfNjZ3LD2jvqFTMyigsex4a4AXcvluiKx1?= =?us-ascii?Q?epObXXZRqKmjvhjqy8zKZK84VU3xo8+puj387FqQcRTYQ1tI4S26rKkaKde/?= =?us-ascii?Q?FTf/TuSxwtShny0KUx/1Am/vf3GSxLpWL7+VjLR+Xig9EzWnaiOugO8ag0qO?= =?us-ascii?Q?+N3eGtC+O2nQc2C6m2yLMMHCLq4LpjLIcT02y39zXm+fHfgzsvcTHRpqGUAc?= =?us-ascii?Q?tg880peHvooOKxey/ntuoOy1e44smMaQhXo1z3Y24K1CkhKffhtiGJDxc4Qq?= =?us-ascii?Q?fgcwEyfDjJalYEkpV1iQFAy+RSwFjXn4O/Pwu1KjG51TQwORM/+kugRUtb2f?= =?us-ascii?Q?+IK3zAujj5ieb70tKDz8+sKzuZ3tVLJi9EbBaleZ4aJZeh5C9yigctU1b/N0?= =?us-ascii?Q?5VWAB5QGrDIK3ew6jlBNp8pNhvFr/fm8PHH2XSxgGZY36Ha6MkEFV36+N+E1?= =?us-ascii?Q?BcZzcLPif2huFMpi/ZiepHcBnOkx0NNi/etmBHs+oZ3HURfM6a2mjB93OfG/?= =?us-ascii?Q?IEezoQDmGdS/ljgxxmwqJ1w/S3IoeVAOGCVDZJy9ezpR7LEZpeXlNiKXPRxB?= =?us-ascii?Q?8zTuu+J5M+aVjKYy28lQJfJx0QvOlKofPZibmy6OpFKc6S7xLzz+RlBDrkqd?= =?us-ascii?Q?vdXgEHJ4KJNYr1l1dCIW7yqkmjv8tfWQFFIjpBdCvB7s+ITS2VfO11GNrzac?= =?us-ascii?Q?AN2gGflz+l4VFymXzuH+7mN4qPRAIqloaAKuXlJYTPKiUxC5ZHnzyl4CgCqK?= =?us-ascii?Q?BgYG4UF9pXhmHCHDj+hdj7A+BxSndSngTacf76ZZvMNUnNRg5jOpr++CNe2s?= =?us-ascii?Q?kdclisStQZc+SCnsxPqaq0vfdX7bLc4PgPL+gh9Dwy+uzqLRen7DS1WpYgFa?= =?us-ascii?Q?tFc98JTu+LXw5IPa/GNfFgndvHqMnYXbC3kV0Y4zbM9rcLw5MAGKdRA/84Bz?= =?us-ascii?Q?4ByOmHcLmG7eDYSwlXIC/BkHkR6lwqscoD1H6wZ7QCJD5dgR8fRJbSl1CDdM?= =?us-ascii?Q?hu+4GwwsRe/pmqi7AnO1N6oTNnzd19EKDM25O84jsAGlvyy+jZG1KLyAlc8P?= =?us-ascii?Q?O3CsQXvZap381UnrpZV5PxIoT90/hgT8RpSR8Rs8Y0ClGXlkXhg5e/JYjI9h?= =?us-ascii?Q?fjsAm5KAf1fQA/Nm6bxalwImse6kaH9qu5ddBjfg4pKBOK2pmtjjbL2y2Zoj?= =?us-ascii?Q?0+xt44LY62wlUoPX8IeBjBzFk3VKyVoHUdGgmdT3vtk+6aYXsQQFn+oIg5k3?= =?us-ascii?Q?OOaKcX2TAt1Gx055Q29b7y/sq+V7LCi9ALZp4X3V+s3X2jgRDQ2ZsxGLbZgc?= =?us-ascii?Q?0QQYLHo9K2oA+uBPAfdnnv37Yf5nTQlsW1do95BvZTBgqaoMMQ7KhrsRscGQ?= =?us-ascii?Q?xNLPMvUdIt4D6WMqVyIppaI=3D?= Content-Type: text/plain; charset="us-ascii" Content-ID: Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: Er7t2p6Ld7x59cOuOI0wrF5h9EME+Q3Km+tUQ/d/9kZ2VH/EaT5Jb5NIbYC8Cu0/yoUAZMIZngpkO5cwQKOVNuqBTG3DwaQHHxuvj6C0HgVZtn/x4L5FV0dgpJfudENF7vDnjF+R0FQOSKnyL9PELEQVL4ylQMm2aqvbuiSGWPeh+cOSmN4fba4cLmTsQ/7BbsUTdgKXAG06LiBZtzJQPvIDdMVEa4CcE+XDNN1Wh5KUQd0nfbmMUadYs4JVjR/PZ5/2TDqBx+favjS8feh2Y6OciDRWh8m+2kXEKXNXHct5Kyd7JeUmgFpoO5Cvfeu2BzLen9c4exjRaIbWcRey3tyufBkqqE8sB136faT13rXKZEc9cJO2u42xqnStQ3KaqVcSbpd5JBZZib9bmSM+RPFHUKZZ6bOhiXHeFmbPQtp+t5wTDCCv7oN0r7mHdd3UvfPgPFnB/5aloJeP5i62uYYWKni/V9u+ejcSbdHurJxkEwNDCd6scddseX+Me+bw3MF+bGuvzkZtkrwTHvH8OhTE+PJAR+B/OV6GtiooW6aMqwk8AWEQi2oCLELczfWslDrthmb85i1D9DhwGyKe/qNj+mSd+2ciYT427rUSJhQ= X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: CY8PR10MB6538.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 3c7162d2-987b-44dd-1baa-08dc5995c97e X-MS-Exchange-CrossTenant-originalarrivaltime: 10 Apr 2024 19:38:24.4974 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: nYh9TvAFImGGpX5RkUMi6wK/dnzLS1uK5HRIB4m6mQ45QGle3ccpdUPJ+xJFCtTs2/98Goq+H9MJaCCjq8rVeg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN7PR10MB7048 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.272,Aquarius:18.0.1011,Hydra:6.0.619,FMLib:17.11.176.26 definitions=2024-04-10_04,2024-04-09_01,2023-05-22_02 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxlogscore=999 malwarescore=0 suspectscore=0 spamscore=0 mlxscore=0 bulkscore=0 adultscore=0 phishscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2404010000 definitions=main-2404100144 X-Proofpoint-GUID: atVWfg6X0yd2lWIjX55bltzqR1MFm1F9 X-Proofpoint-ORIG-GUID: atVWfg6X0yd2lWIjX55bltzqR1MFm1F9 X-Spam-Status: No, score=-5.2 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Thanks a lot for your review. Will fix these typos before committing to GCC15. Qing > On Apr 10, 2024, at 14:36, Joseph Myers wrote: >=20 > On Fri, 29 Mar 2024, Qing Zhao wrote: >=20 >> +/* For a SUBDATUM field of a structure or union DATUM, generate a REF t= o >> + the object that represents its counted_by per the attribute counted_= by >> + attached to this field if it's a flexible array member field, otherw= ise >> + return NULL_TREE. >> + set COUNTED_BY_TYPE to the TYPE of the counted_by field. >=20 > Use an uppercase letter at the start of a sentence, "Set". >=20 >> +static tree >> +build_counted_by_ref (tree datum, tree subdatum, tree *counted_by_type) >> +{ >> + tree type =3D TREE_TYPE (datum); >> + if (!(c_flexible_array_member_type_p (TREE_TYPE (subdatum)))) >> + return NULL_TREE; >=20 > There are redundant parentheses here around the call to=20 > c_flexible_array_member_type_p. >=20 > The C front-end changes in this patch are OK for GCC 15 (after GCC 14 has= =20 > branched, and once a version of patch 1 has also been approved) with thos= e=20 > fixes. >=20 > --=20 > Joseph S. Myers > josmyers@redhat.com >=20