From: Richard Earnshaw <rearnsha@arm.com>
To: Andrew Stubbs <ams@codesourcery.com>
Cc: "gcc-patches@gcc.gnu.org" <gcc-patches@gcc.gnu.org>,
"patches@linaro.org" <patches@linaro.org>
Subject: Re: [PATCH][ARM] NEON DImode not
Date: Thu, 01 Mar 2012 17:07:00 -0000 [thread overview]
Message-ID: <4F4FACC2.2050508@arm.com> (raw)
In-Reply-To: <4F4F7226.6070809@codesourcery.com>
On 01/03/12 12:57, Andrew Stubbs wrote:
> On Wed 29 Feb 2012 18:00:19 GMT, Richard Earnshaw wrote:
>> Why can't we have a single insn that deals with the have-neon and
>> dont-have-neon cases?
>
> Sorry, I'm not sure I follow?
>
> There's one insn for the have-neon case, and one for the
> don't-have-neon. The expander is necessary to prevent gen_one_cmpldi2
> locking recog to a disabled pattern (it caches the recog result, I think).
>
> It would be possible to have the arm.md insn emit NEON instructions, but
> that's not the usual practice, I think? The neon.md isns could also emit
> arm/thumb2 instructions, but there's no real point since there are
> already two different splitters for that.
>
> Andrew
>
The RTL part of one_cmpldi2_internal and one_cmpldi2_neon are the same.
Given that we now have controls to determine when an alternative is
enabled it's generally better to have just one pattern here and turn on
the alternatives that are suitable rather than having multiple patterns.
You're already half doing this with the nota8 and onlya8 controls.
R.
next prev parent reply other threads:[~2012-03-01 17:07 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-29 15:24 Andrew Stubbs
2012-02-29 20:03 ` Richard Earnshaw
2012-03-01 12:57 ` Andrew Stubbs
2012-03-01 17:07 ` Richard Earnshaw [this message]
2012-03-08 16:19 ` Andrew Stubbs
2012-03-08 18:03 ` Richard Henderson
2012-03-27 20:24 ` Andrew Stubbs
2012-03-27 20:43 ` Richard Henderson
2012-03-28 13:37 ` Ramana Radhakrishnan
2012-04-05 14:47 ` Andrew Stubbs
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F4FACC2.2050508@arm.com \
--to=rearnsha@arm.com \
--cc=ams@codesourcery.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=patches@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).