From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 29272 invoked by alias); 1 Mar 2012 17:07:51 -0000 Received: (qmail 29262 invoked by uid 22791); 1 Mar 2012 17:07:50 -0000 X-SWARE-Spam-Status: No, hits=-2.4 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_LOW X-Spam-Check-By: sourceware.org Received: from service87.mimecast.com (HELO service87.mimecast.com) (91.220.42.44) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 01 Mar 2012 17:07:37 +0000 Received: from cam-owa2.Emea.Arm.com (fw-tnat.cambridge.arm.com [217.140.96.21]) by service87.mimecast.com; Thu, 01 Mar 2012 17:07:32 +0000 Received: from [10.1.69.67] ([10.1.255.212]) by cam-owa2.Emea.Arm.com with Microsoft SMTPSVC(6.0.3790.3959); Thu, 1 Mar 2012 17:07:37 +0000 Message-ID: <4F4FACC2.2050508@arm.com> Date: Thu, 01 Mar 2012 17:07:00 -0000 From: Richard Earnshaw User-Agent: Mozilla/5.0 (X11; Linux i686 on x86_64; rv:10.0.2) Gecko/20120216 Thunderbird/10.0.2 MIME-Version: 1.0 To: Andrew Stubbs CC: "gcc-patches@gcc.gnu.org" , "patches@linaro.org" Subject: Re: [PATCH][ARM] NEON DImode not References: <4F4E3AA5.1070804@codesourcery.com> <4F4E67B3.8050002@arm.com> <4F4F7226.6070809@codesourcery.com> In-Reply-To: <4F4F7226.6070809@codesourcery.com> X-MC-Unique: 112030117073207701 Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org X-SW-Source: 2012-03/txt/msg00043.txt.bz2 On 01/03/12 12:57, Andrew Stubbs wrote: > On Wed 29 Feb 2012 18:00:19 GMT, Richard Earnshaw wrote: >> Why can't we have a single insn that deals with the have-neon and >> dont-have-neon cases? >=20 > Sorry, I'm not sure I follow? >=20 > There's one insn for the have-neon case, and one for the=20 > don't-have-neon. The expander is necessary to prevent gen_one_cmpldi2=20 > locking recog to a disabled pattern (it caches the recog result, I think). >=20 > It would be possible to have the arm.md insn emit NEON instructions, but= =20 > that's not the usual practice, I think? The neon.md isns could also emit= =20 > arm/thumb2 instructions, but there's no real point since there are=20 > already two different splitters for that. >=20 > Andrew >=20 The RTL part of one_cmpldi2_internal and one_cmpldi2_neon are the same. Given that we now have controls to determine when an alternative is enabled it's generally better to have just one pattern here and turn on the alternatives that are suitable rather than having multiple patterns. You're already half doing this with the nota8 and onlya8 controls. R.