From: Mikael Morin <mikael.morin@sfr.fr>
To: Bernhard Reutner-Fischer <rep.dot.nop@gmail.com>
Cc: fortran@gcc.gnu.org, gcc-patches@gcc.gnu.org
Subject: Re: [PATCH] gfortran testsuite: implicitly cleanup-modules
Date: Fri, 09 Mar 2012 00:04:00 -0000 [thread overview]
Message-ID: <4F594879.7080203@sfr.fr> (raw)
In-Reply-To: <1330636193-25099-1-git-send-email-rep.dot.nop@gmail.com>
On 01/03/2012 22:09, Bernhard Reutner-Fischer wrote:
> Hi,
>
> By now we have quite some leftover modules in the testsuite, again.
> Given that the previous suggestion in this thread -- to have a separate
> script in contrib -- did not trigger any reaction, let me suggest the
> patch below instead.
>
> Teach the testsuite to cleanup the modules.
> We do this by grepping for the module names and implicitly deleting them
> when the test is finished. For the testcases that use modules from other
> files we introduce a keep-modules procedure that keeps either all ("",
> i.e. empty list) or the given modules of the source file.
>
> A follow-up patch would remove the now superfluous cleanup-module calls
> in the remaining testcases. Since that patch is pretty big (~360k) i do
> not intend to send it in but want to apply it straight to the repo (it's
> just a sed '/cleanup-modules/d' on the testcases that do not occur in
> the below patch).
>
> Is it ok to reference ../doc in the ChangeLog entry below to keep the
> documentation change associated with the script itself?
>
No, the changes are associated by being in the same commit (and their
ChangeLog entries in the same subversion commit log).
>
> The patch was bootstrapped and regression tested using tcl-8.5 on
> x86_64-linux-gnu with no new regressions.
>
> Ok for trunk?
According to http://tmml.sourceforge.net/doc/tcl/regexp.html
you can use the -nocase option (= case insensitive) to simplify the
regexp patterns.
I noticed one whitespace inconsistency in keep-modules.
Otherwise it looks good to me (but I'm not a testsuite maintainer).
Mikael
next prev parent reply other threads:[~2012-03-09 0:04 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-03-26 21:40 [patch, testsuite, committed] Clean up gfortran.dg leftover module files Brooks Moses
2007-03-26 21:45 ` FX Coudert
2007-03-27 17:24 ` Bernhard Fischer
2007-03-27 17:29 ` Bernhard Fischer
2012-03-01 21:10 ` [PATCH] gfortran testsuite: implicitly cleanup-modules Bernhard Reutner-Fischer
2012-03-09 0:04 ` Mikael Morin [this message]
2012-03-13 16:39 ` Bernhard Reutner-Fischer
2012-03-13 20:31 ` Mike Stump
2012-03-15 12:40 ` Bernhard Reutner-Fischer
2012-03-15 15:57 ` Richard Guenther
2012-03-15 16:56 ` Bernhard Reutner-Fischer
2012-03-15 19:36 ` Jakub Jelinek
2012-03-16 10:05 ` Bernhard Reutner-Fischer
2012-03-16 15:00 ` Bernhard Reutner-Fischer
2012-06-29 0:15 ` Bernhard Reutner-Fischer
2012-06-29 0:55 ` Mike Stump
2012-06-29 0:56 ` Bernhard Reutner-Fischer
2012-06-29 5:43 ` Mike Stump
2013-06-07 14:30 ` Bernhard Reutner-Fischer
2013-06-10 23:21 ` Ben Elliston
2012-03-19 17:36 ` Rainer Orth
2012-03-22 12:30 ` Bernhard Reutner-Fischer
2012-04-03 12:17 ` [PATCH] gfortran testsuite: implicitly cleanup-modules, part 2 Bernhard Reutner-Fischer
2012-04-03 12:58 ` Bernhard Reutner-Fischer
2012-04-13 10:51 ` PING " Bernhard Reutner-Fischer
2012-04-13 13:58 ` Mike Stump
2012-04-13 14:40 ` Bernhard Reutner-Fischer
2012-04-13 20:09 ` Mike Stump
2012-04-13 14:15 ` Mike Stump
2015-04-23 8:55 ` [PATCH] gfortran testsuite: implicitly cleanup-modules Bernhard Reutner-Fischer
2015-04-29 21:58 ` Joseph Myers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F594879.7080203@sfr.fr \
--to=mikael.morin@sfr.fr \
--cc=fortran@gcc.gnu.org \
--cc=gcc-patches@gcc.gnu.org \
--cc=rep.dot.nop@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).