public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
* [PATCH 1/2] testsuite: fix dg-do ordering wrt dg-require-*
@ 2024-07-27 23:33 Sam James
  2024-07-27 23:33 ` [PATCH 2/2] testsuite: fix dg-add-options vs. dg-options ordering Sam James
  0 siblings, 1 reply; 3+ messages in thread
From: Sam James @ 2024-07-27 23:33 UTC (permalink / raw)
  To: gcc-patches; +Cc: libstdc++, ro, mikestump, Sam James

Per gccint, dg-do must precede dg-require-effective-target or
dg-require-support. Fix a handful of deviant cases.

gcc/testsuite/ChangeLog:

	* gcc.dg/pr25521.c: Fix dg-do directive order.
	* gcc.dg/vect/vect-simd-clone-19.c: Likewise.
	* gcc.target/arm/stack-protector-7.c: Likewise.
	* gcc.target/arm/stack-protector-8.c: Likewise.
	* gcc.target/powerpc/pr93122.c: Likewise.

libstdc++-v3/ChangeLog:

	PR libstdc++/110572
	* testsuite/18_support/type_info/110572.cc: Fix dg-do directive order.
---
Simple dejagnu directive fixes. OK?

 gcc/testsuite/gcc.dg/pr25521.c                        | 2 +-
 gcc/testsuite/gcc.dg/vect/vect-simd-clone-19.c        | 2 +-
 gcc/testsuite/gcc.target/arm/stack-protector-7.c      | 2 +-
 gcc/testsuite/gcc.target/arm/stack-protector-8.c      | 2 +-
 gcc/testsuite/gcc.target/powerpc/pr93122.c            | 2 +-
 libstdc++-v3/testsuite/18_support/type_info/110572.cc | 2 +-
 6 files changed, 6 insertions(+), 6 deletions(-)

diff --git a/gcc/testsuite/gcc.dg/pr25521.c b/gcc/testsuite/gcc.dg/pr25521.c
index 82b4cd88ec05..cd1b90085e11 100644
--- a/gcc/testsuite/gcc.dg/pr25521.c
+++ b/gcc/testsuite/gcc.dg/pr25521.c
@@ -1,8 +1,8 @@
 /* PR middle-end/25521 - place `const volatile' objects in read-only
    sections.
 
-   { dg-require-effective-target elf }
    { dg-do compile }
+   { dg-require-effective-target elf }
    { dg-skip-if "" { ! const_volatile_readonly_section } } */
 
 const volatile int foo = 30;
diff --git a/gcc/testsuite/gcc.dg/vect/vect-simd-clone-19.c b/gcc/testsuite/gcc.dg/vect/vect-simd-clone-19.c
index e7ed56ca7547..46d25526479d 100644
--- a/gcc/testsuite/gcc.dg/vect/vect-simd-clone-19.c
+++ b/gcc/testsuite/gcc.dg/vect/vect-simd-clone-19.c
@@ -1,5 +1,5 @@
-/* { dg-require-effective-target vect_simd_clones } */
 /* { dg-do compile } */
+/* { dg-require-effective-target vect_simd_clones } */
 
 int __attribute__ ((__simd__, const)) fn (int);
 
diff --git a/gcc/testsuite/gcc.target/arm/stack-protector-7.c b/gcc/testsuite/gcc.target/arm/stack-protector-7.c
index 2173bc5a35a0..23207fd98c84 100644
--- a/gcc/testsuite/gcc.target/arm/stack-protector-7.c
+++ b/gcc/testsuite/gcc.target/arm/stack-protector-7.c
@@ -1,6 +1,6 @@
+/* { dg-do compile } */
 /* { dg-require-effective-target arm_hard_vfp_ok }  */
 /* { dg-require-effective-target arm_arch_v7a_ok } */
-/* { dg-do compile } */
 /* { dg-options "-march=armv7-a -mfpu=vfp -fstack-protector-all -Os -mstack-protector-guard=tls -mstack-protector-guard-offset=1296 -mtp=cp15" } */
 
 #include "stack-protector-5.c"
diff --git a/gcc/testsuite/gcc.target/arm/stack-protector-8.c b/gcc/testsuite/gcc.target/arm/stack-protector-8.c
index ea5ef3211678..165f34706cc4 100644
--- a/gcc/testsuite/gcc.target/arm/stack-protector-8.c
+++ b/gcc/testsuite/gcc.target/arm/stack-protector-8.c
@@ -1,6 +1,6 @@
+/* { dg-do compile } */
 /* { dg-require-effective-target arm_hard_vfp_ok }  */
 /* { dg-require-effective-target arm_arch_v7a_ok } */
-/* { dg-do compile } */
 /* { dg-error "needs a hardware TLS register" "missing error when using TLS stack protector without hardware TLS register" { target *-*-* } 0 } */
 /* { dg-options "-fstack-protector-all -Os -mstack-protector-guard=tls -mtp=soft" } */
 
diff --git a/gcc/testsuite/gcc.target/powerpc/pr93122.c b/gcc/testsuite/gcc.target/powerpc/pr93122.c
index 97bcb0cea5ff..42d1d94ba15f 100644
--- a/gcc/testsuite/gcc.target/powerpc/pr93122.c
+++ b/gcc/testsuite/gcc.target/powerpc/pr93122.c
@@ -1,6 +1,6 @@
 /* PR target/93122 */
-/* { dg-require-effective-target power10_ok } */
 /* { dg-do compile { target lp64 } } */
+/* { dg-require-effective-target power10_ok } */
 /* { dg-options "-fstack-clash-protection -mprefixed -mdejagnu-cpu=power10" } */
 
 void bar (char *);
diff --git a/libstdc++-v3/testsuite/18_support/type_info/110572.cc b/libstdc++-v3/testsuite/18_support/type_info/110572.cc
index 64081879b77d..f727653adfb1 100644
--- a/libstdc++-v3/testsuite/18_support/type_info/110572.cc
+++ b/libstdc++-v3/testsuite/18_support/type_info/110572.cc
@@ -1,7 +1,7 @@
 // { dg-options "-static-libstdc++" }
+// { dg-do link }
 // { dg-require-static-libstdcxx }
 // { dg-require-cpp-feature-test __cpp_rtti }
-// { dg-do link }
 
 #include <typeinfo>
 

-- 
2.45.2


^ permalink raw reply	[flat|nested] 3+ messages in thread

* [PATCH 2/2] testsuite: fix dg-add-options vs. dg-options ordering
  2024-07-27 23:33 [PATCH 1/2] testsuite: fix dg-do ordering wrt dg-require-* Sam James
@ 2024-07-27 23:33 ` Sam James
  2024-07-28  6:28   ` Richard Biener
  0 siblings, 1 reply; 3+ messages in thread
From: Sam James @ 2024-07-27 23:33 UTC (permalink / raw)
  To: gcc-patches; +Cc: libstdc++, ro, mikestump, Sam James

Per gccint, dg-add-options must be placed after all dg-options directives.

gcc/testsuite/ChangeLog:

	* gcc.target/riscv/rvv/base/cmpmem-2.c: Fix dg-add-options order.
---
Simple dejagnu directive fixes. OK?

 gcc/testsuite/gcc.target/riscv/rvv/base/cmpmem-2.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/gcc/testsuite/gcc.target/riscv/rvv/base/cmpmem-2.c b/gcc/testsuite/gcc.target/riscv/rvv/base/cmpmem-2.c
index c782cc6c6e6e..fdb402a787b4 100644
--- a/gcc/testsuite/gcc.target/riscv/rvv/base/cmpmem-2.c
+++ b/gcc/testsuite/gcc.target/riscv/rvv/base/cmpmem-2.c
@@ -1,6 +1,6 @@
 /* { dg-do run { target { riscv_v } } } */
-/* { dg-add-options riscv_v } */
 /* { dg-options "-O2 -mrvv-max-lmul=dynamic" } */
+/* { dg-add-options riscv_v } */
 
 #include <stdlib.h>
 
-- 
2.45.2


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH 2/2] testsuite: fix dg-add-options vs. dg-options ordering
  2024-07-27 23:33 ` [PATCH 2/2] testsuite: fix dg-add-options vs. dg-options ordering Sam James
@ 2024-07-28  6:28   ` Richard Biener
  0 siblings, 0 replies; 3+ messages in thread
From: Richard Biener @ 2024-07-28  6:28 UTC (permalink / raw)
  To: Sam James; +Cc: gcc-patches, libstdc++, ro, mikestump



> Am 28.07.2024 um 01:34 schrieb Sam James <sam@gentoo.org>:
> 
> Per gccint, dg-add-options must be placed after all dg-options directives.
> 
> gcc/testsuite/ChangeLog:
> 
>    * gcc.target/riscv/rvv/base/cmpmem-2.c: Fix dg-add-options order.

Ok for both patches

Richard 

> ---
> Simple dejagnu directive fixes. OK?
> 
> gcc/testsuite/gcc.target/riscv/rvv/base/cmpmem-2.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/gcc/testsuite/gcc.target/riscv/rvv/base/cmpmem-2.c b/gcc/testsuite/gcc.target/riscv/rvv/base/cmpmem-2.c
> index c782cc6c6e6e..fdb402a787b4 100644
> --- a/gcc/testsuite/gcc.target/riscv/rvv/base/cmpmem-2.c
> +++ b/gcc/testsuite/gcc.target/riscv/rvv/base/cmpmem-2.c
> @@ -1,6 +1,6 @@
> /* { dg-do run { target { riscv_v } } } */
> -/* { dg-add-options riscv_v } */
> /* { dg-options "-O2 -mrvv-max-lmul=dynamic" } */
> +/* { dg-add-options riscv_v } */
> 
> #include <stdlib.h>
> 
> --
> 2.45.2
> 

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2024-07-28  6:29 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-07-27 23:33 [PATCH 1/2] testsuite: fix dg-do ordering wrt dg-require-* Sam James
2024-07-27 23:33 ` [PATCH 2/2] testsuite: fix dg-add-options vs. dg-options ordering Sam James
2024-07-28  6:28   ` Richard Biener

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).