public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Aurelien Buhrig <aurelien.buhrig.gcc@gmail.com>
To: gcc-patches@gcc.gnu.org
Subject: [PATCH] Bug fix in store_bit_field_1 for big endian targets (issue 51893)
Date: Wed, 21 Mar 2012 08:55:00 -0000	[thread overview]
Message-ID: <4F69979E.4070502@gmail.com> (raw)

[-- Attachment #1: Type: text/plain, Size: 355 bytes --]

Hi,

This patch (for 4.6) fixes a wrong subword index computation in
store_bit_field_1 for big endian targets when value is at least 4 times
bigger than a word (DI REG value with HI words).

It fixes a regression on gcc.c-torture/execute/bitfld-3.c for my current
backend port.

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=51893

OK to commit?

Aurélien

[-- Attachment #2: patch --]
[-- Type: text/plain, Size: 661 bytes --]

--- gcc-4.6.1.orig/gcc/expmed.c	2011-05-22 21:02:59.000000000 +0200
+++ src/gcc/expmed.c	2012-01-19 09:32:04.000000000 +0100
@@ -589,7 +589,10 @@
 	{
 	  /* If I is 0, use the low-order word in both field and target;
 	     if I is 1, use the next to lowest word; and so on.  */
-	  unsigned int wordnum = (backwards ? nwords - i - 1 : i);
+	  unsigned int wordnum = (backwards
+                                  ? GET_MODE_SIZE(fieldmode)/UNITS_PER_WORD
+                                        - i - 1 
+                                  : i);
 	  unsigned int bit_offset = (backwards
 				     ? MAX ((int) bitsize - ((int) i + 1)
 					    * BITS_PER_WORD,

             reply	other threads:[~2012-03-21  8:55 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-03-21  8:55 Aurelien Buhrig [this message]
2012-03-21 21:53 ` Eric Botcazou
2012-03-23  3:39   ` Alan Modra
2012-03-24  9:52     ` Eric Botcazou
2012-03-26 10:49       ` Aurelien Buhrig
2012-03-27 20:59         ` Eric Botcazou
2012-03-28  8:02           ` Richard Guenther

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4F69979E.4070502@gmail.com \
    --to=aurelien.buhrig.gcc@gmail.com \
    --cc=gcc-patches@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).