public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Richard Henderson <rth@redhat.com>
To: Uros Bizjak <ubizjak@gmail.com>
Cc: gcc-patches@gcc.gnu.org
Subject: Re: [PATCH, alpha]: Use generic config/elfos.h headers
Date: Wed, 21 Mar 2012 22:37:00 -0000	[thread overview]
Message-ID: <4F6A582E.3070704@redhat.com> (raw)
In-Reply-To: <CAFULd4amaG3TM-zdb3ZELRwbVJ-ji15SyWjUrD5SGqT8XG3Kfw@mail.gmail.com>

On 03/21/12 12:28, Uros Bizjak wrote:
> Hello!
> 
> Attached patch enables alpha to use generic config/elfos.h headers on
> linux and *bsd targets. The most important difference to generic
> elfos.h is in
> 
> 	* config/alpha/elf.h (TARGET_ASM_FILE_START_FILE_DIRECTIVE): Undefine.

This one can be deleted, since

2012-03-14  Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>

	...
        * config/alpha/alpha.c (alpha_file_start): Always assume
        OBJECT_FORMAT_ELF.
        Don't set targetm.asm_file_start_file_directive.
        [!OBJECT_FORMAT_ELF]: Remove.
        (TARGET_ASM_FILE_START_FILE_DIRECTIVE): Remove.

The patch looks ok, with,

> +#undef USER_LABEL_PREFIX
>  #define USER_LABEL_PREFIX ""

This ought to be deletable.

>  /* We use the default ASCII-output routine, except that we don't write more
>     than 50 characters since the assembler doesn't support very long lines.  */
>  
> +#undef ASM_OUTPUT_ASCII
>  #define ASM_OUTPUT_ASCII(MYFILE, MYSTRING, MYLENGTH) \

Likewise.  Since RO deleted all non-gas support.


r~

  reply	other threads:[~2012-03-21 22:37 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-03-21 19:29 Uros Bizjak
2012-03-21 22:37 ` Richard Henderson [this message]
2012-03-22  7:47   ` Uros Bizjak
2012-03-22 16:25     ` Richard Henderson
2012-03-22 16:49       ` Uros Bizjak
2012-03-22 16:51         ` Richard Henderson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4F6A582E.3070704@redhat.com \
    --to=rth@redhat.com \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=ubizjak@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).