From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 25142 invoked by alias); 23 Mar 2012 13:03:03 -0000 Received: (qmail 25112 invoked by uid 22791); 23 Mar 2012 13:03:02 -0000 X-SWARE-Spam-Status: No, hits=-2.6 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW X-Spam-Check-By: sourceware.org Received: from mail-ee0-f47.google.com (HELO mail-ee0-f47.google.com) (74.125.83.47) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 23 Mar 2012 13:02:17 +0000 Received: by eekc1 with SMTP id c1so956313eek.20 for ; Fri, 23 Mar 2012 06:02:15 -0700 (PDT) Received: by 10.213.20.12 with SMTP id d12mr894023ebb.260.1332507735276; Fri, 23 Mar 2012 06:02:15 -0700 (PDT) Received: from yakj.usersys.redhat.com (host190-163-dynamic.0-87-r.retail.telecomitalia.it. [87.0.163.190]) by mx.google.com with ESMTPS id n55sm27971666eef.6.2012.03.23.06.02.13 (version=TLSv1/SSLv3 cipher=OTHER); Fri, 23 Mar 2012 06:02:14 -0700 (PDT) Message-ID: <4F6C7454.4060004@gnu.org> Date: Fri, 23 Mar 2012 13:03:00 -0000 From: Paolo Bonzini User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:10.0.1) Gecko/20120216 Thunderbird/10.0.1 MIME-Version: 1.0 To: Paolo Carlini CC: Terry Guo , libstdc++@gcc.gnu.org, gcc-patches@gcc.gnu.org, ro@CeBiTec.Uni-Bielefeld.DE, mikestump@comcast.net, Richard Earnshaw Subject: Re: [Ping][PATCH, libstdc++-v3] Enable to cross-test libstdc++ on simulator References: <000001ccfc22$59706ed0$0c514c70$@guo@arm.com> <4F6C6F26.9010905@oracle.com> In-Reply-To: <4F6C6F26.9010905@oracle.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org X-SW-Source: 2012-03/txt/msg01561.txt.bz2 Il 23/03/2012 13:40, Paolo Carlini ha scritto: > Hi, > > On 03/07/2012 06:22 AM, Terry Guo wrote: >> Hello, >> >> Can anybody please review and approve the following simple patch? Thanks >> very much. >> >> http://gcc.gnu.org/ml/libstdc++/2011-08/msg00063.html > apparently somebody, somewhere, approved this patch, because I see: > > 2012-03-13 Terry Guo > > * testsuite/Makefile.in (TEST_GCC_EXEC_PREFIX): New. > > but frankly the commit as-is didn't make much sense, because the *.in > files are generated: a sensible patch should have touched the *.am file > and then, upon approval, committed also the files change by 'autoreconf'. It was approved by Mike Stump who obviously confused the *.in with *.am, or libstdc++-v3 with gcc. It happens. :) The same change done to Makefile.am is of course ok, but you don't need my approval to install it. (the other) Paolo