From: Aurelien Buhrig <aurelien.buhrig.gcc@gmail.com>
To: Eric Botcazou <ebotcazou@adacore.com>
Cc: Alan Modra <amodra@gmail.com>, gcc-patches@gcc.gnu.org
Subject: Re: [PATCH] Bug fix in store_bit_field_1 for big endian targets (issue 51893)
Date: Mon, 26 Mar 2012 10:49:00 -0000 [thread overview]
Message-ID: <4F7049C5.7040703@gmail.com> (raw)
In-Reply-To: <201203241051.54973.ebotcazou@adacore.com>
[-- Attachment #1: Type: text/plain, Size: 499 bytes --]
>> Passes bootstrap and regression test powerpc64-linux.
>
> Thanks a lot, Alan!
>
> So, Aurelien, you only need to adjust the formatting of the patch and post a
> ChangeLog entry along with it. TIA.
>
Thanks Alan!
Bootstrap and regression test for m68k-elf ok, but I have trouble cross
compiling trunk for powerpc64-linux target...
Changelog:
* expmed.c (store_bit_field_1): Fix wordnum value for big endian targets
Will this fix be backported to 4.6 branch for next release?
Aurélien
[-- Attachment #2: patch --]
[-- Type: text/plain, Size: 603 bytes --]
Index: gcc/expmed.c
===================================================================
--- gcc/expmed.c (revision 185732)
+++ gcc/expmed.c (working copy)
@@ -550,7 +550,10 @@
{
/* If I is 0, use the low-order word in both field and target;
if I is 1, use the next to lowest word; and so on. */
- unsigned int wordnum = (backwards ? nwords - i - 1 : i);
+ unsigned int wordnum = (backwards
+ ? GET_MODE_SIZE (fieldmode) / UNITS_PER_WORD
+ - i - 1
+ : i);
unsigned int bit_offset = (backwards
? MAX ((int) bitsize - ((int) i + 1)
* BITS_PER_WORD,
next prev parent reply other threads:[~2012-03-26 10:49 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-21 8:55 Aurelien Buhrig
2012-03-21 21:53 ` Eric Botcazou
2012-03-23 3:39 ` Alan Modra
2012-03-24 9:52 ` Eric Botcazou
2012-03-26 10:49 ` Aurelien Buhrig [this message]
2012-03-27 20:59 ` Eric Botcazou
2012-03-28 8:02 ` Richard Guenther
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F7049C5.7040703@gmail.com \
--to=aurelien.buhrig.gcc@gmail.com \
--cc=amodra@gmail.com \
--cc=ebotcazou@adacore.com \
--cc=gcc-patches@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).