From: Paolo Carlini <paolo.carlini@oracle.com>
To: Jeffrey Yasskin <jyasskin@googlers.com>
Cc: gcc-patches <gcc-patches@gcc.gnu.org>
Subject: Re: [patch] Fix PR52822 (stable_partition move-assigns object to itself) in trunk, 4.7, and 4.6
Date: Thu, 05 Apr 2012 06:12:00 -0000 [thread overview]
Message-ID: <4F7D37A9.8040401@oracle.com> (raw)
In-Reply-To: <4F7D36FF.7000808@oracle.com>
On 4/4/12 11:09 PM, Paolo Carlini wrote:
> Hi,
>> The attached patches fix http://gcc.gnu.org/PR52822, and have been
>> tested with `make check-c++` on linux-x86_64. The trunk patch applies
>> and tests cleanly on gcc-4_7-branch. The gcc-4_6-branch patch is
>> significantly simpler, as Paolo suggested on the bug.
> A few small issues.
>
> For the 4.6 version of the patch, you want to use std::__addressof,
> instead of simply &, which may be overloaded.
And by the way what's wrong with just comparing the iterators?
Paolo.
next prev parent reply other threads:[~2012-04-05 6:12 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-03 23:14 Jeffrey Yasskin
2012-04-05 6:09 ` Paolo Carlini
2012-04-05 6:12 ` Paolo Carlini [this message]
2012-04-07 3:15 ` Jeffrey Yasskin
2012-04-10 18:23 ` Paolo Carlini
2012-04-10 18:26 ` Paolo Carlini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F7D37A9.8040401@oracle.com \
--to=paolo.carlini@oracle.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=jyasskin@googlers.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).