From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gcc-patches-return-316520-listarch-gcc-patches=gcc.gnu.org@gcc.gnu.org>
Received: (qmail 4938 invoked by alias); 11 Apr 2012 02:17:59 -0000
Received: (qmail 4912 invoked by uid 22791); 11 Apr 2012 02:17:58 -0000
X-SWARE-Spam-Status: No, hits=-7.0 required=5.0	tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,KHOP_THREADED,RCVD_IN_DNSWL_HI,RCVD_IN_HOSTKARMA_W,SPF_HELO_PASS,T_RP_MATCHES_RCVD
X-Spam-Check-By: sourceware.org
Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28)    by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 11 Apr 2012 02:17:38 +0000
Received: from int-mx12.intmail.prod.int.phx2.redhat.com (int-mx12.intmail.prod.int.phx2.redhat.com [10.5.11.25])	by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q3B2Hcfh011056	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK);	Tue, 10 Apr 2012 22:17:38 -0400
Received: from [10.3.113.125] (ovpn-113-125.phx2.redhat.com [10.3.113.125])	by int-mx12.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id q3B2Hb99022522;	Tue, 10 Apr 2012 22:17:37 -0400
Message-ID: <4F84E9C1.3050705@redhat.com>
Date: Wed, 11 Apr 2012 02:17:00 -0000
From: Jason Merrill <jason@redhat.com>
User-Agent: Mozilla/5.0 (X11; Linux i686; rv:11.0) Gecko/20120329 Thunderbird/11.0.1
MIME-Version: 1.0
To: =?ISO-8859-1?Q?Fabien_Ch=EAne?= <fabien.chene@gmail.com>
CC: GCC Patches <gcc-patches@gcc.gnu.org>
Subject: Re: [C++ Patch] for c++/52465
References: <CAFH4-dgxXPKEZmMvw98bZ-kF5L--oBx9jyscX8t2sUWOJxK=PQ@mail.gmail.com> <4F746D6F.1040705@redhat.com> <CAFH4-djHAKYxEwiYbOjzkkD2N+R3fGeVGoiD846o_hbGha3zwQ@mail.gmail.com> <4F80AE37.70907@redhat.com> <CAFH4-dik+yBG40XGA1GFjnPJwCADY4CdBs602bUkAq3gdJjTsA@mail.gmail.com>
In-Reply-To: <CAFH4-dik+yBG40XGA1GFjnPJwCADY4CdBs602bUkAq3gdJjTsA@mail.gmail.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 8bit
Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
List-Id: <gcc-patches.gcc.gnu.org>
List-Archive: <http://gcc.gnu.org/ml/gcc-patches/>
List-Post: <mailto:gcc-patches@gcc.gnu.org>
List-Help: <mailto:gcc-patches-help@gcc.gnu.org>
Sender: gcc-patches-owner@gcc.gnu.org
X-SW-Source: 2012-04/txt/msg00582.txt.bz2

On 04/10/2012 04:23 PM, Fabien Chêne wrote:
> Ah yes, that's slightly better.
> (I've kept the NULL check in strip_using_decl, it seems safer to me.
> Just tell me if you prefer not)
> Tested x86_64-unkown-linux-gnu. OK for trunk and 4.7 ?
>
> 2012-03-08  Fabien Chêne<fabien@gcc.gnu.org>
>
>         PR c++/52465
>         * decl.c (grokdeclarator): Call strip_using_decl.
>         * parser.c (cp_parser_class_name): Call strip_using_decl and
>         perform some checks on the target decl.
>         * name-lookup.c (strip_using_decl): Returns NULL_TREE if the decl
>         to be stripped is NULL_TREE.
>         (qualify_lookup): Call strip_using_decl and perform some checks on
>         the target decl.

Your ChangeLog needs to be adjusted.  :)

The patch is OK, thanks!

Jason