From: Jason Merrill <jason@redhat.com>
To: Dodji Seketeli <dodji@redhat.com>
Cc: GCC Patches <gcc-patches@gcc.gnu.org>,
Tom Tromey <tromey@redhat.com>,
Gabriel Dos Reis <gdr@integrable-solutions.net>
Subject: Re: [PATCH preprocessor, diagnostics] PR preprocessor/53229 - Fix diagnostics location when pasting tokens
Date: Tue, 22 May 2012 15:00:00 -0000 [thread overview]
Message-ID: <4FBBAA0A.808@redhat.com> (raw)
In-Reply-To: <m3vcjod1tb.fsf@redhat.com>
On 05/22/2012 05:04 AM, Dodji Seketeli wrote:
> The problem is that cpp_get_token_1 can be called when we are at the
> beginning of a macro expansion (inside enter_macro_expansion, called
> from cpp_get_token_1), *before* context->c.macro is set. This happens
> e.g, when we call funlike_invocation_p to know if the current macro is
> function-like or not.
OK, sounds like we need some additional code to handle that. I guess we
could do something in funlike_invocation_p to prevent cpp_get_token_1
from setting invocation_location, or change the check we use to decide
whether or not we already have an invocation location, perhaps by
looking at invocation_location itself (and clearing it when we finish a
macro).
Jason
next prev parent reply other threads:[~2012-05-22 15:00 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-15 11:18 Dodji Seketeli
2012-05-15 11:30 ` Manuel López-Ibáñez
2012-05-15 13:28 ` Jason Merrill
2012-05-15 14:18 ` Dodji Seketeli
2012-05-21 2:24 ` Jason Merrill
2012-05-21 14:08 ` Dodji Seketeli
2012-05-21 14:57 ` Jason Merrill
2012-05-22 9:04 ` Dodji Seketeli
2012-05-22 15:00 ` Jason Merrill [this message]
2012-05-24 16:03 ` Dodji Seketeli
2012-05-24 16:50 ` Jason Merrill
2012-05-24 17:41 ` Dodji Seketeli
2012-05-24 18:57 ` Jason Merrill
2012-05-24 19:18 ` Dodji Seketeli
2012-05-24 21:08 ` Dodji Seketeli
2012-05-28 16:28 ` Jason Merrill
2012-05-15 18:36 ` Tom Tromey
2012-05-21 14:15 ` Dodji Seketeli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FBBAA0A.808@redhat.com \
--to=jason@redhat.com \
--cc=dodji@redhat.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=gdr@integrable-solutions.net \
--cc=tromey@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).