* [testsuite] scandump.exp: use printable version of regexp
@ 2012-06-13 21:14 Janis Johnson
2012-06-13 22:13 ` Mike Stump
0 siblings, 1 reply; 2+ messages in thread
From: Janis Johnson @ 2012-06-13 21:14 UTC (permalink / raw)
To: gcc-patches
[-- Attachment #1: Type: text/plain, Size: 347 bytes --]
Most scan-* procedures used in dg-final test directives use a printable
version of the regular expression in the test summary. This patch makes
scan-*-dump-tiles do that as well, which eliminates several duplicates
in test summaries for expressions that contain a newline.
Tested on i686-pc-linux-gnu and arm-none-eabi. OK for mainline?
Janis
[-- Attachment #2: gcc-20120613-2 --]
[-- Type: text/plain, Size: 834 bytes --]
2012-06-13 Janis Johnson <janisjo@codesourcery.com>
* lib/scandump.exp (scan-dump-times): Use printable version of
regexp in test summary line.
Index: lib/scandump.exp
===================================================================
--- lib/scandump.exp (revision 188482)
+++ lib/scandump.exp (working copy)
@@ -94,7 +94,8 @@
upvar 3 name testcase
set suf [dump-suffix [lindex $args 3]]
- set testname "$testcase scan-[lindex $args 0]-dump-times $suf \"[lindex $args 1]\" [lindex $args 2]"
+ set printable_pattern [make_pattern_printable [lindex $args 1]]
+ set testname "$testcase scan-[lindex $args 0]-dump-times $suf \"$printable_pattern\" [lindex $args 2]"
set src [file tail [lindex $testcase 0]]
set output_file "[glob -nocomplain $src.[lindex $args 3]]"
if { $output_file == "" } {
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [testsuite] scandump.exp: use printable version of regexp
2012-06-13 21:14 [testsuite] scandump.exp: use printable version of regexp Janis Johnson
@ 2012-06-13 22:13 ` Mike Stump
0 siblings, 0 replies; 2+ messages in thread
From: Mike Stump @ 2012-06-13 22:13 UTC (permalink / raw)
To: janisjo; +Cc: gcc-patches
On Jun 13, 2012, at 2:13 PM, Janis Johnson wrote:
> Most scan-* procedures used in dg-final test directives use a printable
> version of the regular expression in the test summary. This patch makes
> scan-*-dump-tiles do that as well, which eliminates several duplicates
> in test summaries for expressions that contain a newline.
Ok.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2012-06-13 22:11 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-06-13 21:14 [testsuite] scandump.exp: use printable version of regexp Janis Johnson
2012-06-13 22:13 ` Mike Stump
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).