From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 7428 invoked by alias); 14 Jun 2012 06:30:05 -0000 Received: (qmail 7415 invoked by uid 22791); 14 Jun 2012 06:30:04 -0000 X-SWARE-Spam-Status: No, hits=-4.2 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,KHOP_THREADED,RCVD_IN_HOSTKARMA_W,RCVD_IN_HOSTKARMA_WL X-Spam-Check-By: sourceware.org Received: from relay1.mentorg.com (HELO relay1.mentorg.com) (192.94.38.131) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 14 Jun 2012 06:29:51 +0000 Received: from svr-orw-fem-01.mgc.mentorg.com ([147.34.98.93]) by relay1.mentorg.com with esmtp id 1Sf3Z0-0005qT-Fn from ChungLin_Tang@mentor.com ; Wed, 13 Jun 2012 23:29:50 -0700 Received: from SVR-ORW-FEM-05.mgc.mentorg.com ([147.34.97.43]) by svr-orw-fem-01.mgc.mentorg.com over TLS secured channel with Microsoft SMTPSVC(6.0.3790.4675); Wed, 13 Jun 2012 23:29:50 -0700 Received: from [0.0.0.0] (147.34.91.1) by svr-orw-fem-05.mgc.mentorg.com (147.34.97.43) with Microsoft SMTP Server id 14.1.289.1; Wed, 13 Jun 2012 23:29:49 -0700 Message-ID: <4FD984E2.90301@codesourcery.com> Date: Thu, 14 Jun 2012 07:47:00 -0000 From: Chung-Lin Tang User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:12.0) Gecko/20120428 Thunderbird/12.0.1 MIME-Version: 1.0 To: Ramana Radhakrishnan CC: Yi-Hsiu Hsu , "gcc-patches@gcc.gnu.org" Subject: Re: [PATCH, ARM] New CPU support for Marvell PJ4 cores References: <689C75E0D210324F8BE88961219F681624B5949520@SC-VEXCH2.marvell.com> In-Reply-To: Content-Type: text/plain; charset="ISO-8859-1" Content-Transfer-Encoding: 7bit X-IsSubscribed: yes Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org X-SW-Source: 2012-06/txt/msg00898.txt.bz2 On 2012/6/14 02:18 AM, Ramana Radhakrishnan wrote: > On 29 May 2012 10:07, Yi-Hsiu Hsu wrote: >> Hi, >> >> This patch maintains Marvell PJ4 cores pipeline description. >> Run arm testsuite on arm-linux-gnueabi and no extra regressions are found. >> >> * config/arm/marvell-pj4.md: New marvell-pj4 pipeline description. >> * config/arm/arm.c (arm_issue_rate): Add marvell_pj4. >> * config/arm/arm-cores.def: Add core marvell-pj4. >> * config/arm/arm-tune.md: Regenerated. >> * config/arm/arm-tables.opt: Regenerated. >> * doc/invoke.texi: Added entry for marvell-pj4. > > This command line option should also be added to BE8_LINK_SPEC similar > to what's done for the other v7-a cores. > > Ok with that change. I take the blame for not doing this back then, but I suggest the resource names be properly qualified, similar to most recently added pipeline descriptions, e.g. prepend resource/reservation names with "pj4_" ("is" to "pj4_is", etc.) Chung-Lin