From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 37938 invoked by alias); 17 Dec 2018 19:33:16 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 37928 invoked by uid 89); 17 Dec 2018 19:33:16 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_NONE autolearn=ham version=3.3.2 spammy=Hx-languages-length:644 X-HELO: mail-qt1-f194.google.com Received: from mail-qt1-f194.google.com (HELO mail-qt1-f194.google.com) (209.85.160.194) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 17 Dec 2018 19:33:14 +0000 Received: by mail-qt1-f194.google.com with SMTP id t33so12723662qtt.4 for ; Mon, 17 Dec 2018 11:33:14 -0800 (PST) Return-Path: Received: from [192.168.1.149] (209-6-216-142.s141.c3-0.smr-cbr1.sbo-smr.ma.cable.rcncustomer.com. [209.6.216.142]) by smtp.gmail.com with ESMTPSA id o2sm9724718qko.97.2018.12.17.11.33.11 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 17 Dec 2018 11:33:12 -0800 (PST) Subject: Re: [PATCH] v5: C++: more location wrapper nodes (PR c++/43064, PR c++/43486) To: David Malcolm Cc: Jeff Law , gcc-patches@gcc.gnu.org References: <1544833064-29934-1-git-send-email-dmalcolm@redhat.com> From: Jason Merrill Message-ID: <4a0448bb-8f3e-92cb-0e13-f8928632cc0c@redhat.com> Date: Mon, 17 Dec 2018 19:33:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.3.1 MIME-Version: 1.0 In-Reply-To: <1544833064-29934-1-git-send-email-dmalcolm@redhat.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2018-12/txt/msg01249.txt.bz2 On 12/14/18 7:17 PM, David Malcolm wrote: > + /* Since default args are effectively part of the function type, > + strip location wrappers here, since otherwise the location of > + one function's default arguments is arbitrarily chosen for > + all functions with similar signature (due to canonicalization > + of function types). */ Hmm, looking at this again, why would this happen? I see that type_list_equal uses == to compare default arguments, so two function types with the same default argument but different location wrappers shouldn't be combined. Jason