From: "Andre Vieira (lists)" <andre.simoesdiasvieira@arm.com>
To: Jakub Jelinek <jakub@redhat.com>,
"gcc-patches@gcc.gnu.org" <gcc-patches@gcc.gnu.org>,
Richard Biener <rguenther@suse.de>,
richard.sandiford@arm.com
Subject: Re: [PATCH] vect, tree-optimization/105219: Disable epilogue vectorization when peeling for alignment
Date: Tue, 26 Apr 2022 16:45:14 +0100 [thread overview]
Message-ID: <4a0809ef-5b68-9459-ad47-153e642b3125@arm.com> (raw)
In-Reply-To: <YmgL5z/TRv4n+x/B@tucnak>
On 26/04/2022 16:12, Jakub Jelinek wrote:
> On Tue, Apr 26, 2022 at 03:43:13PM +0100, Richard Sandiford via Gcc-patches wrote:
>>> --- /dev/null
>>> +++ b/gcc/testsuite/gcc.target/aarch64/pr105219-2.c
>>> @@ -0,0 +1,29 @@
>>> +/* { dg-do run } */
>>> +/* { dg-options "-O3 -march=armv8.2-a -mtune=thunderx -fno-vect-cost-model" } */
>>> +/* { dg-skip-if "incompatible options" { *-*-* } { "-march=*" } { "-march=armv8.2-a" } } */
>>> +/* { dg-skip-if "incompatible options" { *-*-* } { "-mtune=*" } { "-mtune=thunderx" } } */
>>> +/* { dg-skip-if "incompatible options" { *-*-* } { "-mcpu=*" } } */
>> I think this should be in gcc.dg/vect, with the options forced
>> for { target aarch64 }.
> I think not just aarch64, doesn't it need some effective target that
> the HW on which it is tested is ARM v8.2-a compatible plus that binutils
> can assemble v8.2-a instructions?
> Sure, it can be done in gcc.dg/vect too if those effective targets
> aren't defined in aarch64.exp. But probably needs dg-additional-options
> there instead of dg-options.
>
> Jakub
For some reason I thought richi wasn't able to reproduce this on other
targets, but from my last read of the PR I think he was... Regardless
probably worth testing it for all targets for sure.
Question is how do I make it run for all targets but use target specific
options for each to try and trigger the original issue? Multiple
dg-additional-options with different target selectors?
Kind regards,
Andre
next prev parent reply other threads:[~2022-04-26 15:45 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-26 14:34 Andre Vieira (lists)
2022-04-26 14:43 ` Richard Sandiford
2022-04-26 15:12 ` Jakub Jelinek
2022-04-26 15:45 ` Andre Vieira (lists) [this message]
2022-04-26 16:02 ` Jakub Jelinek
2022-04-26 15:41 ` Andre Vieira (lists)
2022-04-27 6:35 ` Richard Biener
2022-04-27 10:59 ` Richard Biener
2022-04-27 11:10 ` Richard Biener
2022-04-27 13:46 ` Andre Vieira (lists)
2022-04-27 14:09 ` Richard Biener
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4a0809ef-5b68-9459-ad47-153e642b3125@arm.com \
--to=andre.simoesdiasvieira@arm.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=jakub@redhat.com \
--cc=rguenther@suse.de \
--cc=richard.sandiford@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).