From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by sourceware.org (Postfix) with ESMTP id BE380385780C for ; Tue, 26 Apr 2022 15:45:18 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org BE380385780C Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 736CE23A; Tue, 26 Apr 2022 08:45:18 -0700 (PDT) Received: from [10.57.10.193] (unknown [10.57.10.193]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 99C7B3F73B; Tue, 26 Apr 2022 08:45:17 -0700 (PDT) Message-ID: <4a0809ef-5b68-9459-ad47-153e642b3125@arm.com> Date: Tue, 26 Apr 2022 16:45:14 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.8.1 Subject: Re: [PATCH] vect, tree-optimization/105219: Disable epilogue vectorization when peeling for alignment Content-Language: en-US To: Jakub Jelinek , "gcc-patches@gcc.gnu.org" , Richard Biener , richard.sandiford@arm.com References: <8462f41b-895f-9aca-499e-7713ec161673@arm.com> From: "Andre Vieira (lists)" In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-7.9 required=5.0 tests=BAYES_00, KAM_DMARC_STATUS, KAM_SHORT, NICE_REPLY_A, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 26 Apr 2022 15:45:20 -0000 On 26/04/2022 16:12, Jakub Jelinek wrote: > On Tue, Apr 26, 2022 at 03:43:13PM +0100, Richard Sandiford via Gcc-patches wrote: >>> --- /dev/null >>> +++ b/gcc/testsuite/gcc.target/aarch64/pr105219-2.c >>> @@ -0,0 +1,29 @@ >>> +/* { dg-do run } */ >>> +/* { dg-options "-O3 -march=armv8.2-a -mtune=thunderx -fno-vect-cost-model" } */ >>> +/* { dg-skip-if "incompatible options" { *-*-* } { "-march=*" } { "-march=armv8.2-a" } } */ >>> +/* { dg-skip-if "incompatible options" { *-*-* } { "-mtune=*" } { "-mtune=thunderx" } } */ >>> +/* { dg-skip-if "incompatible options" { *-*-* } { "-mcpu=*" } } */ >> I think this should be in gcc.dg/vect, with the options forced >> for { target aarch64 }. > I think not just aarch64, doesn't it need some effective target that > the HW on which it is tested is ARM v8.2-a compatible plus that binutils > can assemble v8.2-a instructions? > Sure, it can be done in gcc.dg/vect too if those effective targets > aren't defined in aarch64.exp. But probably needs dg-additional-options > there instead of dg-options. > > Jakub For some reason I thought richi wasn't able to reproduce this on other targets, but from my last read of the PR I think he was... Regardless probably worth testing it for all targets for sure. Question is how do I make it run for all targets but use target specific options for each to try and trigger the original issue? Multiple dg-additional-options with different target selectors? Kind regards, Andre