From: Aldy Hernandez <aldyh@redhat.com>
To: Jakub Jelinek <jakub@redhat.com>
Cc: Andrew MacLeod <amacleod@redhat.com>, gcc-patches@gcc.gnu.org
Subject: Re: [PATCH] range-op-float: Further comparison fixes
Date: Sat, 1 Apr 2023 20:32:03 +0200 [thread overview]
Message-ID: <4a0f2399-8242-5382-7128-a3c9333a20ad@redhat.com> (raw)
In-Reply-To: <ZCffnpXHlfKJ+Fy8@tucnak>
On 4/1/23 09:39, Jakub Jelinek wrote:
> On Fri, Mar 31, 2023 at 01:28:35PM +0200, Aldy Hernandez wrote:
>>> Ok for trunk if this passes bootstrap/regtest?
>>
>> LGTM
>
> Unfortunately I ran into 4 tests where we run into the known bug
> where if ranger finds out a range of some floating point operation
> it folds it and throws away the trapping side-effects with it.
Is VRP folding it, or is some other pass using ranger making a decision
based on INF > INF being false? Cause we'd ultimately like to keep
ranger honest...that is returning FALSE for the above, so the onus is on
the ranger callers on making correct decisions.
IMO.
Aldy
next prev parent reply other threads:[~2023-04-01 18:32 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-31 7:57 [PATCH] range-op-float, value-range: Fix up handling of UN{LT,LE,GT,GE,EQ}_EXPR and handle comparisons in get_tree_range [PR91645] Jakub Jelinek
2023-03-31 10:45 ` [PATCH] range-op-float: Further comparison fixes Jakub Jelinek
2023-03-31 10:57 ` [PATCH] range-op-float: Further foperator_{,not_}equal::fold_range fix Jakub Jelinek
2023-03-31 11:28 ` Aldy Hernandez
2023-03-31 11:28 ` [PATCH] range-op-float: Further comparison fixes Aldy Hernandez
2023-04-01 7:39 ` Jakub Jelinek
2023-04-01 18:32 ` Aldy Hernandez [this message]
2023-03-31 11:28 ` [PATCH] range-op-float, value-range: Fix up handling of UN{LT,LE,GT,GE,EQ}_EXPR and handle comparisons in get_tree_range [PR91645] Aldy Hernandez
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4a0f2399-8242-5382-7128-a3c9333a20ad@redhat.com \
--to=aldyh@redhat.com \
--cc=amacleod@redhat.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=jakub@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).