From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by sourceware.org (Postfix) with ESMTP id 689DD385B52C for ; Tue, 17 Jan 2023 17:07:10 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 689DD385B52C Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=foss.arm.com Authentication-Results: sourceware.org; spf=none smtp.mailfrom=foss.arm.com Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 16353AD7; Tue, 17 Jan 2023 09:07:52 -0800 (PST) Received: from [10.2.78.76] (unknown [10.2.78.76]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 5EF453F71A; Tue, 17 Jan 2023 09:07:09 -0800 (PST) Message-ID: <4a2579d2-9740-7f2e-d249-c9f81a0f0645@foss.arm.com> Date: Tue, 17 Jan 2023 17:07:08 +0000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.2 Subject: Re: [PATCH] testsuite: Skip intrinsics test if arm Content-Language: en-GB To: Torbjorn SVENSSON , gcc-patches@gcc.gnu.org References: <20220919161657.4103924-1-torbjorn.svensson@foss.st.com> <8ebf2146-bdef-1208-a32b-c89bcf0e16ee@foss.arm.com> <880cd0da-dcf8-4b18-a7a2-0d21627f344c@foss.st.com> From: Richard Earnshaw In-Reply-To: <880cd0da-dcf8-4b18-a7a2-0d21627f344c@foss.st.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-3494.2 required=5.0 tests=BAYES_00,BODY_8BITS,GIT_PATCH_0,KAM_DMARC_STATUS,KAM_LAZY_DOMAIN_SECURITY,KAM_SHORT,NICE_REPLY_A,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 15/01/2023 17:06, Torbjorn SVENSSON via Gcc-patches wrote: > > > On 2023-01-12 16:03, Richard Earnshaw wrote: >> >> >> On 19/09/2022 17:16, Torbjörn SVENSSON via Gcc-patches wrote: >>> In the test case, it's clearly written that intrinsics is not >>> implemented on arm*. A simple xfail does not help since there are >>> link error and that would cause an UNRESOLVED testcase rather than >>> XFAIL. >>> By chaning to dg-skip-if, the entire test case is omitted. >>> >>> gcc/testsuite/ChangeLog: >>> >>>     * gcc.target/aarch64/advsimd-intrinsics/vld1x2.c: Replace >>>     dg-xfail-if with gd-skip-if. >> >> Sorry for the delay reviewing this, I missed it at the time. >> >> My problem with your suggested solution is that if these intrinsics >> are ever added this test will not automatically pick this up as it >> will have been disabled.  I presume from the comment (and the body of >> the test that contains an #ifdef for aarch64) that this is expected to >> be a temporary issue rather than something permanent. >> >> So IMO I think it is correct to leave this as unresolved because the >> test cannot be built due to an issue with the compiler. > > This patch has already been merged after Kyrill reviewed it back in > September. > > Without this change, the log would be filled with warnings about missing > types. Maybe we could add some check that will enable the test only if > the types are known? > Would that mitigate your concern? > > Attached is the log from vld1x2.c on Cortex-A7 with -mfloat-abi=hard > -mfpu=neon. > > When I look at the result of a run, I only look at the test cases that > are either FAIL (obviously), XPASS and UNRESOLVED. All other test cases > are in a "good" state from what I can tell. If there are a lot of test > cases in the UNRESOLVED state, that are not yet implemented year after > year, it makes it harder to identify those test cases that are of > interest. Right or wrong, that's why I suggested to remove it for the > list of test cases that should be working. > > Let me know what you think. Ah, OK. Somehow I'd misplaced v2 of the patch, which is the version that got approved. R. > > Kind regards, > Torbjörn > >> >> R. >> >>> >>> Co-Authored-By: Yvan ROUX  >>> Signed-off-by: Torbjörn SVENSSON  >>> --- >>>   gcc/testsuite/gcc.target/aarch64/advsimd-intrinsics/vld1x2.c | 2 +- >>>   1 file changed, 1 insertion(+), 1 deletion(-) >>> >>> diff --git >>> a/gcc/testsuite/gcc.target/aarch64/advsimd-intrinsics/vld1x2.c >>> b/gcc/testsuite/gcc.target/aarch64/advsimd-intrinsics/vld1x2.c >>> index 92a139bc523..f933102be47 100644 >>> --- a/gcc/testsuite/gcc.target/aarch64/advsimd-intrinsics/vld1x2.c >>> +++ b/gcc/testsuite/gcc.target/aarch64/advsimd-intrinsics/vld1x2.c >>> @@ -1,6 +1,6 @@ >>>   /* We haven't implemented these intrinsics for arm yet.  */ >>> -/* { dg-xfail-if "" { arm*-*-* } } */ >>>   /* { dg-do run } */ >>> +/* { dg-skip-if "unsupported" { arm*-*-* } } */ >>>   /* { dg-options "-O3" } */ >>>   #include