From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 78482 invoked by alias); 11 Dec 2017 23:39:24 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 78453 invoked by uid 89); 11 Dec 2017 23:39:23 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE autolearn=ham version=3.3.2 spammy=learn X-HELO: mail-qt0-f174.google.com Received: from mail-qt0-f174.google.com (HELO mail-qt0-f174.google.com) (209.85.216.174) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 11 Dec 2017 23:39:22 +0000 Received: by mail-qt0-f174.google.com with SMTP id d4so43112558qtj.5 for ; Mon, 11 Dec 2017 15:39:22 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=21wgwTsp+UNFxaTykVVvjVz6vRZz/AhqXpfvDU1bo+Q=; b=S3NQzbhIJURHMMqAOPYIFgUApQqVD6J6dI9rU1ZnrlE9NPywcIoYHOhg7ySRJ+Dw1Q pFhKVxMSugOslefqM9qH5cDpBEW1OX83nyBUIdC8Z4NVxI8K8tOvy1TeTN8NTkAv2KHY tCLdJufO0QlrfGUdZEmR3CjYvpi4ZUzrZS/XhT/kO/sf3cTzcG1iGB9BkTqVgasqXXoU dcDv2RHzwAUBXQxbXN5jEwyyBrqneltasbXfWacijUTRoT0aOQVdl6q0Yi7zx0+4ky4P Bb7YvMMuTfw0NJO3g1gUIx3lOYJSqxWGWfB34Om+m84hZJsDJOI1ZB/TQL+As+nOvM4r vY7w== X-Gm-Message-State: AKGB3mKCYjDg7b0QraNuJ67MMeJ4now8EsBu6KFfYXaK6NYbofi7Mro7 nXQktpBVpJxaLbkZ+TWfr4Wv/OUZE/0= X-Google-Smtp-Source: ACJfBovLAiIZGgTS4dYdCwPJO0z9eAU45fDiGh0W496pctBFmT6cuw3umPLHRl8MpbH3S4wOX4SSTQ== X-Received: by 10.55.217.18 with SMTP id u18mr3062418qki.153.1513035560514; Mon, 11 Dec 2017 15:39:20 -0800 (PST) Received: from [192.168.1.132] (209-6-90-240.s1774.c3-0.smr-ubr1.sbo-smr.ma.cable.rcncustomer.com. [209.6.90.240]) by smtp.gmail.com with ESMTPSA id a17sm5423576qkj.6.2017.12.11.15.39.19 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 11 Dec 2017 15:39:19 -0800 (PST) Subject: Re: [PATCH 08/14] cp/tree.c: strip location wrappers in lvalue_kind To: David Malcolm Cc: Nathan Sidwell , Jakub Jelinek , Richard Biener , gcc-patches List References: <1510350329-48956-1-git-send-email-dmalcolm@redhat.com> <1510350329-48956-9-git-send-email-dmalcolm@redhat.com> From: Jason Merrill Message-ID: <4a709a4e-0c8e-da35-45d0-65ed5fe07167@redhat.com> Date: Mon, 11 Dec 2017 23:39:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0 MIME-Version: 1.0 In-Reply-To: <1510350329-48956-9-git-send-email-dmalcolm@redhat.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2017-12/txt/msg00675.txt.bz2 On 11/10/2017 04:45 PM, David Malcolm wrote: > Without this, then lvalue_p returns false for decls, and hence > e.g. uses of them for references fail. > > Stripping location wrappers in lvalue_kind restores the correct > behavior of lvalue_p etc. > > gcc/cp/ChangeLog: > * tree.c (lvalue_kind): Strip any location wrapper. Rather, lvalue_kind should learn to handle VIEW_CONVERT_EXPR. Jason