From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-oi1-x22b.google.com (mail-oi1-x22b.google.com [IPv6:2607:f8b0:4864:20::22b]) by sourceware.org (Postfix) with ESMTPS id A41C13858C53 for ; Fri, 1 Mar 2024 04:30:39 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org A41C13858C53 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org A41C13858C53 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2607:f8b0:4864:20::22b ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1709267443; cv=none; b=iBN7bNoEFrTzTK+k7M4QzYEv/O/a/+Rp/Dst03ryrb1X+DxDeqVk3QaEcyIcfWy0Q6wjmi/zTokMRLfMa78bVDFlIwdhx6ICcq8syI7xKmzTkTg8703wBKnsinktPBs9n1YP/vms9uWn3/hI7qY2LwDhrg0Ph/IHbNDBJhNdZ8g= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1709267443; c=relaxed/simple; bh=h8IERzq4njvHzppH17PD5WsU73ANeNnYnXjbvqYtY6E=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=gROO8jHNCEViK7YTp04yHu7Jf8PiN67M55sE98DEBVw1VA3VU/o4p1k8i1WeVMbJbYqCa1sgfNdH57hkClYaRDSMXitiOnpS914iyoU3Wr/u7a6XE7vW0e372YS/thD3k8HEV8wv0MpyYaG2Hn3qivXjzP++ekwCyyuKJ+VgtZ0= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-oi1-x22b.google.com with SMTP id 5614622812f47-3bbc649c275so1047280b6e.0 for ; Thu, 29 Feb 2024 20:30:39 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1709267439; x=1709872239; darn=gcc.gnu.org; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=zEqYQU5y/AXAxBb2hX/QvFQekPhWHEgrSY0YlcQK29A=; b=l6wS4gm7UZBe5zGE4v+45jLjcKoZ7grv87GiJA7gVYIH7rCi5eybpZ5JG9ZTKMtUdF uLF8tH+6piEurP6yniCHvOJwgmaUAydnTMnsFyqcsef3axrL6hLW2235DLVXT8xXalO8 CP93uv0tSgb9qH1JU24tBZoj+QYc8SJr0SWUeuiq2upAXck84gpzRqNLg8gPXgye8jvE qZv/ibi5JLOtY7cWbQ9xQHqHedQLbR+u4oyFQfkhgrVy+cUQHoPnlN809vKtB/OCGqXc pwkKreqztq55a3ch1P5mJqO85FWhATjN30U/UpA7haJxdiDSzK28cXHLQNuM5Kbxr1Yp DWjA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1709267439; x=1709872239; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=zEqYQU5y/AXAxBb2hX/QvFQekPhWHEgrSY0YlcQK29A=; b=tSJ3LtHnkdAD/Yl9RhI4QJ0E3oiQ/DtEBhuTF8jNlCey+O3DIe9vpRF2Z+bQAUDlU5 LpGGLxOrPE99x1Yvo99H7Erg/pfwMcOyT0GxNUscfLxYRoya6t6B6g/0LztsHdmpqkdK wLtm8tjR53z/YRAjyW8ssyVL+QQq65X54UxBbReZDUv+a6uakQGJIbF5VCY77rIt6Sfk 3W8HlyeMjwCHK8srCu27hHDvFqJ70+2oZSgpSpvV/Js7l0UrcoD04iJR2ZboSV418J3D Vpi/EeCij0oArdM+w7ShBRDALulOpn/vgGfB+V1ZJWWLF/cy9PIT/oJcoYmjB74t8cAh iFcg== X-Forwarded-Encrypted: i=1; AJvYcCXtlu+aPXhGBUkJFH8KtMdZdccHWiIti706khm6kSRAybxsSsoQHDmW1WHggPfCIsm03oYhrMBZPkLyGH8Vi9eKpTqgT/190w== X-Gm-Message-State: AOJu0YwBZAksJLwHCs532385+IeaVDwRclqezBrG/wxoFTSxEAone1gO 93zOsdKj0P/VtfAGbiMhuyeuLNuinRjw6nvsmWkIhu854BbRZ5ti X-Google-Smtp-Source: AGHT+IESJozN26Rx5uRR+Vv6/HqhbhAKlGtFCm8Z4qqfTOlJOCrf/QafQDMLGM0x7JIxRtmx6uyIzg== X-Received: by 2002:a05:6808:9b8:b0:3c1:ba5e:9aaf with SMTP id e24-20020a05680809b800b003c1ba5e9aafmr596562oig.21.1709267438748; Thu, 29 Feb 2024 20:30:38 -0800 (PST) Received: from [172.31.0.109] ([136.36.72.243]) by smtp.gmail.com with ESMTPSA id z23-20020a056808029700b003c136b7e02dsm541875oic.57.2024.02.29.20.30.36 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 29 Feb 2024 20:30:37 -0800 (PST) Message-ID: <4a986781-7be8-4e45-a2d7-567d1df58ee3@gmail.com> Date: Thu, 29 Feb 2024 21:30:34 -0700 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Beta Subject: Re: [PATCH] combine: Don't simplify paradoxical SUBREG on WORD_REGISTER_OPERATIONS [PR113010] Content-Language: en-US To: Greg McGary , gcc-patches@gcc.gnu.org References: <20240227001736.3690294-1-gkm@rivosinc.com> From: Jeff Law In-Reply-To: <20240227001736.3690294-1-gkm@rivosinc.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-2.4 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 2/26/24 17:17, Greg McGary wrote: > The sign-bit-copies of a sign-extending load cannot be known until runtime on > WORD_REGISTER_OPERATIONS targets, except in the case of a zero-extending MEM > load. See the fix for PR112758. > > 2024-02-22 Greg McGary > > PR rtl-optimization/113010 > * combine.cc (simplify_comparison): Simplify a SUBREG on > WORD_REGISTER_OPERATIONS targets only if it is a zero-extending > MEM load. > > * gcc.c-torture/execute/pr113010.c: New test. I think this is fine for the trunk. I'll do some final testing on it tomorrow. Jeff