* [patch] install host specific {bits,ext}/opt_random.h headers in host specific c++ incdir
@ 2013-05-12 9:58 Matthias Klose
2013-05-17 7:36 ` [ping] " Matthias Klose
2013-05-18 19:32 ` Paolo Carlini
0 siblings, 2 replies; 10+ messages in thread
From: Matthias Klose @ 2013-05-12 9:58 UTC (permalink / raw)
To: libstdc++; +Cc: gcc-patches
[-- Attachment #1: Type: text/plain, Size: 214 bytes --]
{bits,ext}/opt_random.h became host specific in 4.8, but are still installed
into the host independent c++ include dir. install them into the host specific
include dir instead. Ok for 4.8 and trunk?
Matthias
[-- Attachment #2: host-headers.diff --]
[-- Type: text/plain, Size: 2831 bytes --]
2013-05-11 Matthias Klose <doko@ubuntu.com>
* include/Makefile.am (bits_headers): Remove ${bits_host_headers}.
(ext_headers): Remove ${ext_host_headers}.
(stamp-${host_alias}): Create ${host_builddir}/../ext.
(stamp-host): Link ${bits_host_headers} and ${ext_host_headers}.
(install-headers): Install ${bits_host_headers} and ${ext_host_headers}.
* include/Makefile.in: Regenerate.
--- libstdc++-v3/include/Makefile.am (revision 198799)
+++ libstdc++-v3/include/Makefile.am (working copy)
@@ -172,8 +172,7 @@
${bits_srcdir}/valarray_array.tcc \
${bits_srcdir}/valarray_before.h \
${bits_srcdir}/valarray_after.h \
- ${bits_srcdir}/vector.tcc \
- ${bits_host_headers}
+ ${bits_srcdir}/vector.tcc
bits_host_headers = \
${glibcxx_srcdir}/${CPU_OPT_BITS_RANDOM}
@@ -535,8 +534,7 @@
${ext_srcdir}/vstring.tcc \
${ext_srcdir}/vstring_fwd.h \
${ext_srcdir}/vstring_util.h \
- ${ext_compat_headers} \
- ${ext_host_headers}
+ ${ext_compat_headers}
ext_compat_headers = \
${backward_srcdir}/hash_set \
@@ -1048,13 +1046,14 @@
stamp-${host_alias}:
@-mkdir -p ${host_builddir}
+ @-mkdir -p ${host_builddir}/../ext
@$(STAMP) stamp-${host_alias}
# Host includes static.
# XXX Missing dependency info for {host_headers_extra}
-stamp-host: ${host_headers} ${host_headers_noinst} stamp-${host_alias}
+stamp-host: ${host_headers} ${bits_host_headers} ${ext_host_headers} ${host_headers_noinst} stamp-${host_alias}
@cd ${host_builddir} && {\
- $(LN_S) ${host_headers} . || true ;\
+ $(LN_S) ${host_headers} ${bits_host_headers} . || true ;\
$(LN_S) ${glibcxx_srcdir}/$(BASIC_FILE_H) basic_file.h || true ;\
$(LN_S) ${glibcxx_srcdir}/$(ALLOCATOR_H) c++allocator.h || true ;\
$(LN_S) ${glibcxx_srcdir}/$(CSTDIO_H) c++io.h || true ;\
@@ -1064,6 +1063,9 @@
$(LN_S) ${glibcxx_srcdir}/$(CMESSAGES_H) messages_members.h || true ;\
$(LN_S) ${glibcxx_srcdir}/$(CTIME_H) time_members.h || true;\
} 2>/dev/null
+ @cd ${host_builddir}/../ext && {\
+ $(LN_S) ${ext_host_headers} . || true ;\
+ } 2>/dev/null
$(STAMP) stamp-host
# Host includes dynamic.
@@ -1290,9 +1292,12 @@
for file in ${profile_impl_headers}; do \
$(INSTALL_DATA) $${file} $(DESTDIR)${gxx_include_dir}/${profile_impl_builddir}; done
$(mkinstalldirs) $(DESTDIR)${host_installdir}
- for file in ${host_headers} ${host_headers_extra} \
+ for file in ${host_headers} ${bits_host_headers} ${host_headers_extra} \
${thread_host_headers}; do \
$(INSTALL_DATA) $${file} $(DESTDIR)${host_installdir}; done
+ $(mkinstalldirs) $(DESTDIR)${host_installdir}/../ext
+ for file in ${ext_host_headers}; do \
+ $(INSTALL_DATA) $${file} $(DESTDIR)${host_installdir}/../ext; done
# By adding these files here, automake will remove them for 'make clean'
CLEANFILES = ${pch_output} ${pch_output_anchors} stamp-host
^ permalink raw reply [flat|nested] 10+ messages in thread
* [ping] Re: [patch] install host specific {bits,ext}/opt_random.h headers in host specific c++ incdir
2013-05-12 9:58 [patch] install host specific {bits,ext}/opt_random.h headers in host specific c++ incdir Matthias Klose
@ 2013-05-17 7:36 ` Matthias Klose
2013-05-18 19:32 ` Paolo Carlini
1 sibling, 0 replies; 10+ messages in thread
From: Matthias Klose @ 2013-05-17 7:36 UTC (permalink / raw)
To: libstdc++; +Cc: gcc-patches
ping?
Am 12.05.2013 11:58, schrieb Matthias Klose:
> {bits,ext}/opt_random.h became host specific in 4.8, but are still installed
> into the host independent c++ include dir. install them into the host specific
> include dir instead. Ok for 4.8 and trunk?
>
> Matthias
>
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [patch] install host specific {bits,ext}/opt_random.h headers in host specific c++ incdir
2013-05-12 9:58 [patch] install host specific {bits,ext}/opt_random.h headers in host specific c++ incdir Matthias Klose
2013-05-17 7:36 ` [ping] " Matthias Klose
@ 2013-05-18 19:32 ` Paolo Carlini
2013-05-19 0:06 ` Matthias Klose
1 sibling, 1 reply; 10+ messages in thread
From: Paolo Carlini @ 2013-05-18 19:32 UTC (permalink / raw)
To: Matthias Klose; +Cc: libstdc++, gcc-patches
Hi,
On 05/12/2013 11:58 AM, Matthias Klose wrote:
> {bits,ext}/opt_random.h became host specific in 4.8, but are still installed
> into the host independent c++ include dir. install them into the host specific
> include dir instead. Ok for 4.8 and trunk?
I think it's Ok, yes, but let's do mainline only, for now at least.
Thanks!
Paolo.
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [patch] install host specific {bits,ext}/opt_random.h headers in host specific c++ incdir
2013-05-18 19:32 ` Paolo Carlini
@ 2013-05-19 0:06 ` Matthias Klose
2013-05-19 9:35 ` Andreas Schwab
0 siblings, 1 reply; 10+ messages in thread
From: Matthias Klose @ 2013-05-19 0:06 UTC (permalink / raw)
To: Paolo Carlini; +Cc: libstdc++, gcc-patches
Am 18.05.2013 21:31, schrieb Paolo Carlini:
> Hi,
>
> On 05/12/2013 11:58 AM, Matthias Klose wrote:
>> {bits,ext}/opt_random.h became host specific in 4.8, but are still installed
>> into the host independent c++ include dir. install them into the host specific
>> include dir instead. Ok for 4.8 and trunk?
> I think it's Ok, yes, but let's do mainline only, for now at least.
committed for the trunk. please lets reconsider this before the 4.8.2 release.
Matthias
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [patch] install host specific {bits,ext}/opt_random.h headers in host specific c++ incdir
2013-05-19 0:06 ` Matthias Klose
@ 2013-05-19 9:35 ` Andreas Schwab
2013-05-19 9:40 ` Paolo Carlini
0 siblings, 1 reply; 10+ messages in thread
From: Andreas Schwab @ 2013-05-19 9:35 UTC (permalink / raw)
To: Matthias Klose; +Cc: Paolo Carlini, libstdc++, gcc-patches
Tests that now fail, but worked before:
ext/random/arcsine_distribution/cons/default.cc (test for excess errors)
ext/random/arcsine_distribution/cons/parms.cc (test for excess errors)
ext/random/arcsine_distribution/operators/equal.cc (test for excess errors)
ext/random/arcsine_distribution/operators/inequal.cc (test for excess errors)
ext/random/arcsine_distribution/operators/serialize.cc (test for excess errors)
ext/random/arcsine_distribution/requirements/explicit_instantiation/1.cc (test for excess errors)
ext/random/arcsine_distribution/requirements/typedefs.cc (test for excess errors)
ext/random/beta_distribution/cons/default.cc (test for excess errors)
ext/random/beta_distribution/cons/parms.cc (test for excess errors)
ext/random/beta_distribution/operators/equal.cc (test for excess errors)
ext/random/beta_distribution/operators/inequal.cc (test for excess errors)
ext/random/beta_distribution/operators/serialize.cc (test for excess errors)
ext/random/beta_distribution/requirements/explicit_instantiation/1.cc (test for excess errors)
ext/random/beta_distribution/requirements/typedefs.cc (test for excess errors)
ext/random/hoyt_distribution/cons/default.cc (test for excess errors)
ext/random/hoyt_distribution/cons/parms.cc (test for excess errors)
ext/random/hoyt_distribution/operators/equal.cc (test for excess errors)
ext/random/hoyt_distribution/operators/inequal.cc (test for excess errors)
ext/random/hoyt_distribution/operators/serialize.cc (test for excess errors)
ext/random/hoyt_distribution/requirements/explicit_instantiation/1.cc (test for excess errors)
ext/random/hoyt_distribution/requirements/typedefs.cc (test for excess errors)
ext/random/k_distribution/cons/default.cc (test for excess errors)
ext/random/k_distribution/cons/parms.cc (test for excess errors)
ext/random/k_distribution/operators/equal.cc (test for excess errors)
ext/random/k_distribution/operators/inequal.cc (test for excess errors)
ext/random/k_distribution/operators/serialize.cc (test for excess errors)
ext/random/k_distribution/requirements/explicit_instantiation/1.cc (test for excess errors)
ext/random/k_distribution/requirements/typedefs.cc (test for excess errors)
ext/random/nakagami_distribution/cons/default.cc (test for excess errors)
ext/random/nakagami_distribution/cons/parms.cc (test for excess errors)
ext/random/nakagami_distribution/operators/equal.cc (test for excess errors)
ext/random/nakagami_distribution/operators/inequal.cc (test for excess errors)
ext/random/nakagami_distribution/operators/serialize.cc (test for excess errors)
ext/random/nakagami_distribution/requirements/explicit_instantiation/1.cc (test for excess errors)
ext/random/nakagami_distribution/requirements/typedefs.cc (test for excess errors)
ext/random/normal_mv_distribution/cons/default.cc (test for excess errors)
ext/random/normal_mv_distribution/cons/parms.cc (test for excess errors)
ext/random/normal_mv_distribution/operators/equal.cc (test for excess errors)
ext/random/normal_mv_distribution/operators/inequal.cc (test for excess errors)
ext/random/normal_mv_distribution/operators/serialize.cc (test for excess errors)
ext/random/normal_mv_distribution/requirements/explicit_instantiation/1.cc (test for excess errors)
ext/random/normal_mv_distribution/requirements/typedefs.cc (test for excess errors)
ext/random/pareto_distribution/cons/default.cc (test for excess errors)
ext/random/pareto_distribution/cons/parms.cc (test for excess errors)
ext/random/pareto_distribution/operators/equal.cc (test for excess errors)
ext/random/pareto_distribution/operators/inequal.cc (test for excess errors)
ext/random/pareto_distribution/operators/serialize.cc (test for excess errors)
ext/random/pareto_distribution/requirements/explicit_instantiation/1.cc (test for excess errors)
ext/random/pareto_distribution/requirements/typedefs.cc (test for excess errors)
ext/random/rice_distribution/cons/default.cc (test for excess errors)
ext/random/rice_distribution/cons/parms.cc (test for excess errors)
ext/random/rice_distribution/operators/equal.cc (test for excess errors)
ext/random/rice_distribution/operators/inequal.cc (test for excess errors)
ext/random/rice_distribution/operators/serialize.cc (test for excess errors)
ext/random/rice_distribution/requirements/explicit_instantiation/1.cc (test for excess errors)
ext/random/rice_distribution/requirements/typedefs.cc (test for excess errors)
ext/random/simd_fast_mersenne_twister_engine/cons/copy.cc (test for excess errors)
ext/random/simd_fast_mersenne_twister_engine/cons/default.cc (test for excess errors)
ext/random/simd_fast_mersenne_twister_engine/cons/seed1.cc (test for excess errors)
ext/random/simd_fast_mersenne_twister_engine/cons/seed2.cc (test for excess errors)
ext/random/simd_fast_mersenne_twister_engine/cons/seed_seq.cc (test for excess errors)
ext/random/simd_fast_mersenne_twister_engine/operators/equal.cc (test for excess errors)
ext/random/simd_fast_mersenne_twister_engine/operators/inequal.cc (test for excess errors)
ext/random/simd_fast_mersenne_twister_engine/operators/serialize.cc (test for excess errors)
ext/triangular_distribution/cons/default.cc (test for excess errors)
ext/triangular_distribution/cons/parms.cc (test for excess errors)
ext/triangular_distribution/operators/equal.cc (test for excess errors)
ext/triangular_distribution/operators/inequal.cc (test for excess errors)
ext/triangular_distribution/operators/serialize.cc (test for excess errors)
ext/triangular_distribution/requirements/explicit_instantiation/1.cc (test for excess errors)
ext/triangular_distribution/requirements/typedefs.cc (test for excess errors)
ext/von_mises_distribution/cons/default.cc (test for excess errors)
ext/von_mises_distribution/cons/parms.cc (test for excess errors)
ext/von_mises_distribution/operators/equal.cc (test for excess errors)
ext/von_mises_distribution/operators/inequal.cc (test for excess errors)
ext/von_mises_distribution/operators/serialize.cc (test for excess errors)
ext/von_mises_distribution/requirements/explicit_instantiation/1.cc (test for excess errors)
ext/von_mises_distribution/requirements/typedefs.cc (test for excess errors)
Andreas.
--
Andreas Schwab, schwab@linux-m68k.org
GPG Key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5
"And now for something completely different."
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [patch] install host specific {bits,ext}/opt_random.h headers in host specific c++ incdir
2013-05-19 9:35 ` Andreas Schwab
@ 2013-05-19 9:40 ` Paolo Carlini
2013-05-21 8:26 ` Matthias Klose
0 siblings, 1 reply; 10+ messages in thread
From: Paolo Carlini @ 2013-05-19 9:40 UTC (permalink / raw)
To: Andreas Schwab; +Cc: Matthias Klose, libstdc++, gcc-patches
On 05/19/2013 11:35 AM, Andreas Schwab wrote:
> Tests that now fail, but worked before:
Thanks Andreas. Matthias, please revert ASAP, thanks.
Paolo.
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [patch] install host specific {bits,ext}/opt_random.h headers in host specific c++ incdir
2013-05-19 9:40 ` Paolo Carlini
@ 2013-05-21 8:26 ` Matthias Klose
2013-05-22 9:18 ` Paolo Carlini
0 siblings, 1 reply; 10+ messages in thread
From: Matthias Klose @ 2013-05-21 8:26 UTC (permalink / raw)
To: Paolo Carlini; +Cc: Andreas Schwab, libstdc++, gcc-patches
[-- Attachment #1: Type: text/plain, Size: 406 bytes --]
Am 19.05.2013 11:40, schrieb Paolo Carlini:
> On 05/19/2013 11:35 AM, Andreas Schwab wrote:
>> Tests that now fail, but worked before:
> Thanks Andreas. Matthias, please revert ASAP, thanks.
you already did that.
Looks like ext/random includes opt_random.h, which is not on any include dir, so
make it ext/opt_random.h. tests all pass, and check the include with an
installed version too.
Matthias
[-- Attachment #2: host-headers.diff --]
[-- Type: text/plain, Size: 5911 bytes --]
# DP: Install host specific libstdc++ headers into the host include dir
2013-05-11 Matthias Klose <doko@ubuntu.com>
* include/Makefile.am (bits_headers): Remove ${bits_host_headers}.
(ext_headers): Remove ${ext_host_headers}.
(stamp-${host_alias}): Create ${host_builddir}/../ext.
(stamp-host): Link ${bits_host_headers} and ${ext_host_headers}.
(install-headers): Install ${bits_host_headers} and ${ext_host_headers}.
* include/Makefile.in: Regenerate.
* include/ext/random: Include ext/opt_random.h.
Index: b/src/libstdc++-v3/include/Makefile.am
===================================================================
--- a/src/libstdc++-v3/include/Makefile.am 2013-05-12 17:29:35.231053893 +0000
+++ b/src/libstdc++-v3/include/Makefile.am 2013-05-19 11:45:38.434218502 +0000
@@ -172,8 +172,7 @@
${bits_srcdir}/valarray_array.tcc \
${bits_srcdir}/valarray_before.h \
${bits_srcdir}/valarray_after.h \
- ${bits_srcdir}/vector.tcc \
- ${bits_host_headers}
+ ${bits_srcdir}/vector.tcc
bits_host_headers = \
${glibcxx_srcdir}/${CPU_OPT_BITS_RANDOM}
@@ -535,8 +534,7 @@
${ext_srcdir}/vstring.tcc \
${ext_srcdir}/vstring_fwd.h \
${ext_srcdir}/vstring_util.h \
- ${ext_compat_headers} \
- ${ext_host_headers}
+ ${ext_compat_headers}
ext_compat_headers = \
${backward_srcdir}/hash_set \
@@ -1048,13 +1046,14 @@
stamp-${host_alias}:
@-mkdir -p ${host_builddir}
+ @-mkdir -p ${host_builddir}/../ext
@$(STAMP) stamp-${host_alias}
# Host includes static.
# XXX Missing dependency info for {host_headers_extra}
-stamp-host: ${host_headers} ${host_headers_noinst} stamp-${host_alias}
+stamp-host: ${host_headers} ${bits_host_headers} ${ext_host_headers} ${host_headers_noinst} stamp-${host_alias}
@cd ${host_builddir} && {\
- $(LN_S) ${host_headers} . || true ;\
+ $(LN_S) ${host_headers} ${bits_host_headers} . || true ;\
$(LN_S) ${glibcxx_srcdir}/$(BASIC_FILE_H) basic_file.h || true ;\
$(LN_S) ${glibcxx_srcdir}/$(ALLOCATOR_H) c++allocator.h || true ;\
$(LN_S) ${glibcxx_srcdir}/$(CSTDIO_H) c++io.h || true ;\
@@ -1064,6 +1063,9 @@
$(LN_S) ${glibcxx_srcdir}/$(CMESSAGES_H) messages_members.h || true ;\
$(LN_S) ${glibcxx_srcdir}/$(CTIME_H) time_members.h || true;\
} 2>/dev/null
+ @cd ${host_builddir}/../ext && {\
+ $(LN_S) ${ext_host_headers} . || true ;\
+ } 2>/dev/null
$(STAMP) stamp-host
# Host includes dynamic.
@@ -1290,9 +1292,12 @@
for file in ${profile_impl_headers}; do \
$(INSTALL_DATA) $${file} $(DESTDIR)${gxx_include_dir}/${profile_impl_builddir}; done
$(mkinstalldirs) $(DESTDIR)${host_installdir}
- for file in ${host_headers} ${host_headers_extra} \
+ for file in ${host_headers} ${bits_host_headers} ${host_headers_extra} \
${thread_host_headers}; do \
$(INSTALL_DATA) $${file} $(DESTDIR)${host_installdir}; done
+ $(mkinstalldirs) $(DESTDIR)${host_installdir}/../ext
+ for file in ${ext_host_headers}; do \
+ $(INSTALL_DATA) $${file} $(DESTDIR)${host_installdir}/../ext; done
# By adding these files here, automake will remove them for 'make clean'
CLEANFILES = ${pch_output} ${pch_output_anchors} stamp-host
Index: b/src/libstdc++-v3/include/Makefile.in
===================================================================
--- a/src/libstdc++-v3/include/Makefile.in 2013-05-12 17:29:35.231053893 +0000
+++ b/src/libstdc++-v3/include/Makefile.in 2013-05-19 11:46:14.778466710 +0000
@@ -434,8 +434,7 @@
${bits_srcdir}/valarray_array.tcc \
${bits_srcdir}/valarray_before.h \
${bits_srcdir}/valarray_after.h \
- ${bits_srcdir}/vector.tcc \
- ${bits_host_headers}
+ ${bits_srcdir}/vector.tcc
bits_host_headers = \
${glibcxx_srcdir}/${CPU_OPT_BITS_RANDOM}
@@ -795,8 +794,7 @@
${ext_srcdir}/vstring.tcc \
${ext_srcdir}/vstring_fwd.h \
${ext_srcdir}/vstring_util.h \
- ${ext_compat_headers} \
- ${ext_host_headers}
+ ${ext_compat_headers}
ext_compat_headers = \
${backward_srcdir}/hash_set \
@@ -1461,13 +1459,14 @@
stamp-${host_alias}:
@-mkdir -p ${host_builddir}
+ @-mkdir -p ${host_builddir}/../ext
@$(STAMP) stamp-${host_alias}
# Host includes static.
# XXX Missing dependency info for {host_headers_extra}
-stamp-host: ${host_headers} ${host_headers_noinst} stamp-${host_alias}
+stamp-host: ${host_headers} ${bits_host_headers} ${ext_host_headers} ${host_headers_noinst} stamp-${host_alias}
@cd ${host_builddir} && {\
- $(LN_S) ${host_headers} . || true ;\
+ $(LN_S) ${host_headers} ${bits_host_headers} . || true ;\
$(LN_S) ${glibcxx_srcdir}/$(BASIC_FILE_H) basic_file.h || true ;\
$(LN_S) ${glibcxx_srcdir}/$(ALLOCATOR_H) c++allocator.h || true ;\
$(LN_S) ${glibcxx_srcdir}/$(CSTDIO_H) c++io.h || true ;\
@@ -1477,6 +1476,9 @@
$(LN_S) ${glibcxx_srcdir}/$(CMESSAGES_H) messages_members.h || true ;\
$(LN_S) ${glibcxx_srcdir}/$(CTIME_H) time_members.h || true;\
} 2>/dev/null
+ @cd ${host_builddir}/../ext && {\
+ $(LN_S) ${ext_host_headers} . || true ;\
+ } 2>/dev/null
$(STAMP) stamp-host
# Host includes dynamic.
@@ -1688,9 +1690,12 @@
for file in ${profile_impl_headers}; do \
$(INSTALL_DATA) $${file} $(DESTDIR)${gxx_include_dir}/${profile_impl_builddir}; done
$(mkinstalldirs) $(DESTDIR)${host_installdir}
- for file in ${host_headers} ${host_headers_extra} \
+ for file in ${host_headers} ${bits_host_headers} ${host_headers_extra} \
${thread_host_headers}; do \
$(INSTALL_DATA) $${file} $(DESTDIR)${host_installdir}; done
+ $(mkinstalldirs) $(DESTDIR)${host_installdir}/../ext
+ for file in ${ext_host_headers}; do \
+ $(INSTALL_DATA) $${file} $(DESTDIR)${host_installdir}/../ext; done
# To remove directories.
clean-local:
--- a/src/libstdc++-v3/include/ext/random
+++ b/src/libstdc++-v3/include/ext/random
@@ -2848,7 +2848,7 @@
_GLIBCXX_END_NAMESPACE_VERSION
} // namespace __gnu_cxx
-#include "opt_random.h"
+#include "ext/opt_random.h"
#include "random.tcc"
#endif // _GLIBCXX_USE_C99_STDINT_TR1
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [patch] install host specific {bits,ext}/opt_random.h headers in host specific c++ incdir
2013-05-21 8:26 ` Matthias Klose
@ 2013-05-22 9:18 ` Paolo Carlini
2013-06-10 17:54 ` Matthias Klose
0 siblings, 1 reply; 10+ messages in thread
From: Paolo Carlini @ 2013-05-22 9:18 UTC (permalink / raw)
To: Matthias Klose; +Cc: Andreas Schwab, libstdc++, gcc-patches
On 05/21/2013 10:25 AM, Matthias Klose wrote:
> Am 19.05.2013 11:40, schrieb Paolo Carlini:
>> On 05/19/2013 11:35 AM, Andreas Schwab wrote:
>>> Tests that now fail, but worked before:
>> Thanks Andreas. Matthias, please revert ASAP, thanks.
> you already did that.
>
> Looks like ext/random includes opt_random.h, which is not on any include dir, so
> make it ext/opt_random.h. tests all pass, and check the include with an
> installed version too.
Ok, if nobody has further comments over the next day or so, let's try
again ;)
Thanks,
Paolo.
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [patch] install host specific {bits,ext}/opt_random.h headers in host specific c++ incdir
2013-05-22 9:18 ` Paolo Carlini
@ 2013-06-10 17:54 ` Matthias Klose
2013-06-10 19:29 ` Paolo Carlini
0 siblings, 1 reply; 10+ messages in thread
From: Matthias Klose @ 2013-06-10 17:54 UTC (permalink / raw)
To: Paolo Carlini; +Cc: Andreas Schwab, libstdc++, gcc-patches
Am 22.05.2013 11:18, schrieb Paolo Carlini:
> On 05/21/2013 10:25 AM, Matthias Klose wrote:
>> Am 19.05.2013 11:40, schrieb Paolo Carlini:
>>> On 05/19/2013 11:35 AM, Andreas Schwab wrote:
>>>> Tests that now fail, but worked before:
>>> Thanks Andreas. Matthias, please revert ASAP, thanks.
>> you already did that.
>>
>> Looks like ext/random includes opt_random.h, which is not on any include dir, so
>> make it ext/opt_random.h. tests all pass, and check the include with an
>> installed version too.
> Ok, if nobody has further comments over the next day or so, let's try again ;)
now on the trunk for some weeks. ok for the 4.8 branch as well?
Matthias
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [patch] install host specific {bits,ext}/opt_random.h headers in host specific c++ incdir
2013-06-10 17:54 ` Matthias Klose
@ 2013-06-10 19:29 ` Paolo Carlini
0 siblings, 0 replies; 10+ messages in thread
From: Paolo Carlini @ 2013-06-10 19:29 UTC (permalink / raw)
To: Matthias Klose; +Cc: Andreas Schwab, libstdc++, gcc-patches
Hi,
Matthias Klose <doko@ubuntu.com> ha scritto:
>Am 22.05.2013 11:18, schrieb Paolo Carlini:
>> On 05/21/2013 10:25 AM, Matthias Klose wrote:
>>> Am 19.05.2013 11:40, schrieb Paolo Carlini:
>>>> On 05/19/2013 11:35 AM, Andreas Schwab wrote:
>>>>> Tests that now fail, but worked before:
>>>> Thanks Andreas. Matthias, please revert ASAP, thanks.
>>> you already did that.
>>>
>>> Looks like ext/random includes opt_random.h, which is not on any
>include dir, so
>>> make it ext/opt_random.h. tests all pass, and check the include
>with an
>>> installed version too.
>> Ok, if nobody has further comments over the next day or so, let's try
>again ;)
>
>now on the trunk for some weeks. ok for the 4.8 branch as well?
Ok with me.
Thanks,
Paolo
^ permalink raw reply [flat|nested] 10+ messages in thread
end of thread, other threads:[~2013-06-10 19:29 UTC | newest]
Thread overview: 10+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-05-12 9:58 [patch] install host specific {bits,ext}/opt_random.h headers in host specific c++ incdir Matthias Klose
2013-05-17 7:36 ` [ping] " Matthias Klose
2013-05-18 19:32 ` Paolo Carlini
2013-05-19 0:06 ` Matthias Klose
2013-05-19 9:35 ` Andreas Schwab
2013-05-19 9:40 ` Paolo Carlini
2013-05-21 8:26 ` Matthias Klose
2013-05-22 9:18 ` Paolo Carlini
2013-06-10 17:54 ` Matthias Klose
2013-06-10 19:29 ` Paolo Carlini
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).