From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pf1-x432.google.com (mail-pf1-x432.google.com [IPv6:2607:f8b0:4864:20::432]) by sourceware.org (Postfix) with ESMTPS id 3620A3858C78 for ; Tue, 30 Jul 2024 20:23:46 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 3620A3858C78 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=ventanamicro.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=ventanamicro.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 3620A3858C78 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2607:f8b0:4864:20::432 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1722371028; cv=none; b=tyyB7hLqvylHYrA85PKhvmOSoO4QVmMKRuuCp1pHwAk4YuZfU78cPdB6nwVCgaUlLQ/N02b4pOYzOdydyAyVjSSA5Bk+87/aAM/Cfy0XT9ZMosj7lkRBz4IziUqhSGnmWnTzxJkEKko6GdrvvxWD+yPUi+QeV3QPIVuunPal36I= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1722371028; c=relaxed/simple; bh=lpCGj/WgHyNbn5a/Om7CVYgNTTcKrl6bsz9l0BhPq2k=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=NZJtaLvzW8X2uCv+PpuaKPWeDf4VbiVR1gHnor0dNgbwCGLBO34yhCCPldxF7IfQ2Y+bYudoEG++yDR8kluBkvJ/A7mga7ixsWFfML2w3gc2+05lddXRTpW3MBBPen1mcJU/dCpp4fFloiIJnJEf/P6f46eB3mjpCR96Sqscffo= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-pf1-x432.google.com with SMTP id d2e1a72fcca58-70d333d57cdso3456436b3a.3 for ; Tue, 30 Jul 2024 13:23:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ventanamicro.com; s=google; t=1722371025; x=1722975825; darn=gcc.gnu.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=x4eW6CadfXHsYPgYwY8L+S/zcv7+9mcjqqnqu6l/78c=; b=RwEcU+AFqiOgFStnX7yh0WgqVO9V2gPXjPxjH8RGRaerQPA1S9AFz5BsrrxfojGqjM owH2DLWglOW1Jq1Q9C8GfoMYSS3Xs36eE65lUu3AnE3wRdpCCT9Wr1VZr6iQYZIoiNZ/ bEXn6pUKhy6c8FYiuRjSGXrPuPwCP5GZV7bHqTAimWXBsCukJLLfGQOtZApu+SP/iygE CYoExtT+02a0ORE8L2nagtKXAolzIMxI4mrSgXSkhrX5SMYvUBLnhPysHExqBleQ5Rk5 c9dMTywNvAkKoUBi4pusCnIXc+iDO6PAo2/TJOhRUti+Herm17SIeQQBA/b+DPKFR/lZ sI1Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1722371025; x=1722975825; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=x4eW6CadfXHsYPgYwY8L+S/zcv7+9mcjqqnqu6l/78c=; b=fGkzcTNbAyWN/4OzAPnduOS/vCtIVjilSmJ0Z4IWTsgKLOtzO73nllpm1GO2k7rRqS /yr33OUWzu1B+DR6/aERglj0NtT/pRSTtqTYugl4zJQsrHPBAvGLS9/v4GHnDzfWAtp6 zAV9iLm14YFQRK9dXQmUzR7XBNt6S8OKQN4So+CEL57ua6rkX9wEQNiaBxXlA1lY5K52 M7djBZXyBxAj9+3TASJ08TEmc/RLtp8OUcG4WL0ygEQM9li8+vTthkiFqrv06BPdsJzq pgAuywywNMcP6HIS6Eyzlrf9LMvZcYUBSIJegJcGsICTNct9Z1w/vh1JMy3VAuehucqF t2bw== X-Gm-Message-State: AOJu0Yx5Yws78MCn1nrDRCCAww1mYUzwmzqb+JaXhHBaeHVK29TeGZFz 2asG3tJSrS/LQX8+gEGfCeSGj/WEkawPNjIVFsqtHZl+lLv104YEqcszYkBQnDc= X-Google-Smtp-Source: AGHT+IFzU4YTBScsRQOCwmrexp7HZxgeRw4nBngoj4DIkwomSpdMsmr9wwXsLauL9TvTFSB+USrwZQ== X-Received: by 2002:a05:6a20:1592:b0:1be:e3d8:1a85 with SMTP id adf61e73a8af0-1c4a13afae7mr11641552637.36.1722371024899; Tue, 30 Jul 2024 13:23:44 -0700 (PDT) Received: from [172.31.0.109] ([136.36.72.243]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-70ead86ff31sm9114582b3a.144.2024.07.30.13.23.43 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 30 Jul 2024 13:23:44 -0700 (PDT) Message-ID: <4a9c9ea7-56a4-45f5-bd75-903381a25e7f@ventanamicro.com> Date: Tue, 30 Jul 2024 14:23:37 -0600 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Beta Subject: Re: [PATCHv2 2/2] libiberty/buildargv: handle input consisting of only white space Content-Language: en-US To: Andrew Burgess , Thomas Schwinge Cc: gcc-patches@gcc.gnu.org References: <24a8d878590403540bc9b579ba58805985a4d2f7.1701881419.git.aburgess@redhat.com> <37b3a30868139bab59155717f6bff1ed08dbca76.1707585836.git.aburgess@redhat.com> <87h6c8qxsh.fsf@euler.schwinge.ddns.net> <871q3cfjjy.fsf@redhat.com> From: Jeff Law In-Reply-To: <871q3cfjjy.fsf@redhat.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-5.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 7/29/24 6:51 AM, Andrew Burgess wrote: > Thomas Schwinge writes: > >> Hi! >> >> On 2024-02-10T17:26:01+0000, Andrew Burgess wrote: >>> --- a/libiberty/argv.c >>> +++ b/libiberty/argv.c >> >>> @@ -439,17 +442,8 @@ expandargv (int *argcp, char ***argvp) >>> } >>> /* Add a NUL terminator. */ >>> buffer[len] = '\0'; >>> - /* If the file is empty or contains only whitespace, buildargv would >>> - return a single empty argument. In this context we want no arguments, >>> - instead. */ >>> - if (only_whitespace (buffer)) >>> - { >>> - file_argv = (char **) xmalloc (sizeof (char *)); >>> - file_argv[0] = NULL; >>> - } >>> - else >>> - /* Parse the string. */ >>> - file_argv = buildargv (buffer); >>> + /* Parse the string. */ >>> + file_argv = buildargv (buffer); >>> /* If *ARGVP is not already dynamically allocated, copy it. */ >>> if (*argvp == original_argv) >>> *argvp = dupargv (*argvp); >> >> With that (single) use of 'only_whitespace' now gone: >> >> [...]/source-gcc/libiberty/argv.c:128:1: warning: ‘only_whitespace’ defined but not used [-Wunused-function] >> 128 | only_whitespace (const char* input) >> | ^~~~~~~~~~~~~~~ >> > > Sorry about that. > > The patch below is the obvious fix. OK to apply? Of course. jeff