On 09/11/2018 04:20 PM, James Greenhalgh wrote:
> On Tue, Sep 04, 2018 at 10:13:43AM -0500, Sam Tebbs wrote:
>> Hi James,
>>
>> Thanks for the feedback. Here is an update with the changes you proposed
>> and an updated changelog.
>>
>> gcc/
>> 2018-09-04  Sam Tebbs  <sam.tebbs@arm.com>
>>
>>           PR target/85628
>>           * config/aarch64/aarch64.md (*aarch64_bfxil):
>>           Define.
>>           * config/aarch64/constraints.md (Ulc): Define
>>           * config/aarch64/aarch64-protos.h (aarch64_high_bits_all_ones_p):
>>           Define.
>>           * config/aarch64/aarch64.c (aarch64_high_bits_all_ones_p): New function.
>>
>> gcc/testsuite
>> 2018-09-04  Sam Tebbs  <sam.tebbs@arm.com>
>>
>>           PR target/85628
>>           * gcc.target/aarch64/combine_bfxil.c: New file.
>>           * gcc.target/aarch64/combine_bfxil_2.c: New file.
>>
>>
> <snip>
>
>> +/* Return true if I's bits are consecutive ones from the MSB.  */
>> +bool
>> +aarch64_high_bits_all_ones_p (HOST_WIDE_INT i)
>> +{
>> +  return exact_log2(-i) != HOST_WIDE_INT_M1;
>> +}
> You need a space in here between the function name and the bracket:
>
>    exact_log2 (-i)
>
>
>> +extern void abort(void);
> The same comment applies multiple places in this file.
>
> Likewise; if (
>
> Otherwise, OK, please apply with those fixes.
>
> Thanks,
> James

Thanks for noticing that, here's the fixed version.

Sam