From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 11578 invoked by alias); 10 Aug 2007 21:18:52 -0000 Received: (qmail 11511 invoked by uid 22791); 10 Aug 2007 21:18:52 -0000 X-Spam-Check-By: sourceware.org Received: from wa-out-1112.google.com (HELO wa-out-1112.google.com) (209.85.146.182) by sourceware.org (qpsmtpd/0.31) with ESMTP; Fri, 10 Aug 2007 21:18:46 +0000 Received: by wa-out-1112.google.com with SMTP id m16so1004126waf for ; Fri, 10 Aug 2007 14:18:45 -0700 (PDT) Received: by 10.114.78.1 with SMTP id a1mr527703wab.1186780724802; Fri, 10 Aug 2007 14:18:44 -0700 (PDT) Received: by 10.114.149.7 with HTTP; Fri, 10 Aug 2007 14:18:44 -0700 (PDT) Message-ID: <4aca3dc20708101418k5988146n5eb8d6b99dc53c73@mail.gmail.com> Date: Fri, 10 Aug 2007 21:18:00 -0000 From: "Daniel Berlin" To: "Andrew Pinski" Subject: Re: [PATCH]: Transform compute_may_aliases into a TODO Cc: "GCC Patches" , "Diego Novillo" In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Content-Disposition: inline References: <4aca3dc20708101355ked7fae4y2ed1cacbbb4f52d6@mail.gmail.com> Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org X-SW-Source: 2007-08/txt/msg00707.txt.bz2 On 8/10/07, Andrew Pinski wrote: > On 8/10/07, Daniel Berlin wrote: > > We often recompute aliases even when absolutely nothing has changed. > > This is quite wasteful. > > The attached changes compute_may_aliases into a TODO, and we now only > > run it when we've changed things that could destroy aliases. > > You forgot to remove this comment which is no longer true: > /* FIXME: May alias should a TODO but for 4.0.0, > we add may_alias right after fold builtins > which can create arbitrary GIMPLE. */ Fixed, thanks > > Thanks, > Andrew Pinski >