public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Xi Ruoyao <xry111@xry111.site>
To: Dimitrije Milosevic <Dimitrije.Milosevic@Syrmia.com>,
	 "gcc-patches@gcc.gnu.org" <gcc-patches@gcc.gnu.org>
Cc: Djordje Todorovic <Djordje.Todorovic@syrmia.com>,
	Richard Sandiford <richard.sandiford@arm.com>
Subject: Re: [PATCH] libsanitizer: Cherry-pick 2bfb0fcb51510f22723c8cdfefe from upstream
Date: Mon, 25 Jul 2022 15:04:34 +0800	[thread overview]
Message-ID: <4ae7033e87198cfed67db923f28139f877f4aa03.camel@xry111.site> (raw)
In-Reply-To: <VI1PR03MB48936B498E6BB9FD37E020F082959@VI1PR03MB4893.eurprd03.prod.outlook.com>

LGTM.  Requiring permission to push.

> +const unsigned struct_kernel_stat_sz =
> +    SANITIZER_ANDROID
> +        ? FIRST_32_SECOND_64(104, 128)
> +        : FIRST_32_SECOND_64((_MIPS_SIM == _ABIN32) ? 160 : 144, 216);

These values matches sizeof(struct stat) on gcc230, so should be
correct:

xry111@gcc230:~$ cat t.c
#include <stdio.h>
#include <sys/stat.h>

int main()
{
  printf("%d\n", sizeof(struct stat));
}
xry111@gcc230:~$ cc t.c -mabi=32 && ./a.out 
144
xry111@gcc230:~$ cc t.c -mabi=n32 && ./a.out 
160
xry111@gcc230:~$ cc t.c -mabi=64 && ./a.out 
216

-- 
Xi Ruoyao <xry111@xry111.site>
School of Aerospace Science and Technology, Xidian University

  reply	other threads:[~2022-07-25  7:04 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-07-25  6:55 Dimitrije Milosevic
2022-07-25  7:04 ` Xi Ruoyao [this message]
2022-07-27  6:41 ` PING: " Dimitrije Milosevic
2022-07-27  6:43   ` Xi Ruoyao
2022-07-27  6:52     ` Dimitrije Milosevic
2022-07-27 12:57       ` Richard Sandiford
2022-07-28 13:43 ` Dimitrije Milosevic
2022-07-28 13:48   ` Martin Liška
2022-07-29  6:38     ` Dimitrije Milosevic
2022-08-01  4:11       ` Martin Liška

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4ae7033e87198cfed67db923f28139f877f4aa03.camel@xry111.site \
    --to=xry111@xry111.site \
    --cc=Dimitrije.Milosevic@Syrmia.com \
    --cc=Djordje.Todorovic@syrmia.com \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=richard.sandiford@arm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).