From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm1-x32a.google.com (mail-wm1-x32a.google.com [IPv6:2a00:1450:4864:20::32a]) by sourceware.org (Postfix) with ESMTPS id 431D1385840C for ; Thu, 7 Sep 2023 09:48:31 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 431D1385840C Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=linaro.org Received: by mail-wm1-x32a.google.com with SMTP id 5b1f17b1804b1-401187f8071so4463425e9.0 for ; Thu, 07 Sep 2023 02:48:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1694080110; x=1694684910; darn=gcc.gnu.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=+/xavPfeHKkM5Edb1Fs57Ak7muWryzIAsBFEjQC6YKw=; b=JWeksioes8X+gbggGaRG6tE54nqW5UNSrb5VWrx5zMfbyySCEsZ6wkOiG6rjcoitLS IL9Wk3tTBHL3U5RwgLMtr6QcGufblTGycjC118N9lbPk2u0g8mm5aQeFxF7Cx/RvOGnK wWFh13sZCaOOexq6WdDjJi2CTZw0/xju7hLEWxfNkJ+42Mdd6vugZpnFkYLlm0dOGhwJ waUMQQFcjmJcm6R7xIzehYlWOvYcKyG3vNQT+ILBsR65yFbCQGcc0rJpVuR4/N3ly0lx Isi3M5ZrHWWDbUrffVe9C0XiMmb0OVOSNoQMFLTr/D/ryZ4Q0AkWiwQhxRQefNQFE1sc 3E7A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1694080110; x=1694684910; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=+/xavPfeHKkM5Edb1Fs57Ak7muWryzIAsBFEjQC6YKw=; b=VKPY0m+lW/lMbYRDkobl3E1vHc7ufCk3qnPquPd4YywthkveCkF/6fC2UvQi5h3h4f TW0KjN99cYQ5EPpFtAZTw3tGRP/aycNVeAWQQGuQYxw8665UYSo63GM86/JKbTkqK26o sYix5UC/qa/mRl3jd+vodNljw7k1BnGSdk9YKWgHXGsoyxZFzKjdGX9LsJ+Vm0VOAQNs +hXiPASwcsQXS2Uzwmuc26B/r0kBKi4Ey+KP6QItcjhvCWR2txXPSyrOUbRaZN9J788/ CAGyq2qUY79meqBZ7MIMWYHNGAuHLv/rjPJ0FI8QOz4qq0+U5hbJ8BdaOzi1PwNOP3Kd qhpg== X-Gm-Message-State: AOJu0YziaEwyuIygsSA98g7SVs0LwGmoutXZ55FcUbUp7wuCXceAAxKJ KMHhq+EUTRwmkG2IbQ/pYpdss2RbLru9V0a+tmw= X-Google-Smtp-Source: AGHT+IECB9k1RoR69ENUNhn2CpFuTYnYdpxvNiieJ33Nc1+rYNTbtaD4fi9Kzgag3CTTMvD+59exlg== X-Received: by 2002:a05:600c:492f:b0:401:431e:2d03 with SMTP id f47-20020a05600c492f00b00401431e2d03mr1584782wmp.14.1694080109945; Thu, 07 Sep 2023 02:48:29 -0700 (PDT) Received: from localhost ([102.36.222.112]) by smtp.gmail.com with ESMTPSA id e6-20020a05600c218600b003fe1c332810sm1971573wme.33.2023.09.07.02.48.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 07 Sep 2023 02:48:29 -0700 (PDT) Date: Thu, 7 Sep 2023 12:48:25 +0300 From: Dan Carpenter To: Steven Rostedt Cc: Dave Chinner , Guenter Roeck , Christoph Hellwig , ksummit@lists.linux.dev, linux-fsdevel@vger.kernel.org, gcc-patches@gcc.gnu.org Subject: Re: [MAINTAINERS/KERNEL SUMMIT] Trust and maintenance of file systems Message-ID: <4af7c904-ac36-44c9-83c4-2cb30c732672@kadam.mountain> References: <8718a8a3-1e62-0e2b-09d0-7bce3155b045@roeck-us.net> <20230906215327.18a45c89@gandalf.local.home> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230906215327.18a45c89@gandalf.local.home> X-Spam-Status: No, score=-13.5 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Wed, Sep 06, 2023 at 09:53:27PM -0400, Steven Rostedt wrote: > On Thu, 7 Sep 2023 08:54:38 +1000 > Dave Chinner wrote: > > > And let's not forget: removing a filesystem from the kernel is not > > removing end user support for extracting data from old filesystems. > > We have VMs for that - we can run pretty much any kernel ever built > > inside a VM, so users that need to extract data from a really old > > filesystem we no longer support in a modern kernel can simply boot > > up an old distro that did support it and extract the data that way. > > Of course there's the case of trying to recreate a OS that can run on a > very old kernel. Just building an old kernel is difficult today because > today's compilers will refuse to build them (I've hit issues in bisections > because of that!) Yeah. I can't run Smatch on obsolete kernels because I can't build the tools/ directory etc. For example, it would be interesting to look at really ancient kernels to see how buggy they are. I started to hunt down all the Makefile which add a -Werror but there are a lot and eventually I got bored and gave up. Someone should patch GCC so there it checks an environment variable to ignore -Werror. Somethine like this? diff --git a/gcc/opts.cc b/gcc/opts.cc index ac81d4e42944..2de69300d4fe 100644 --- a/gcc/opts.cc +++ b/gcc/opts.cc @@ -2598,6 +2598,17 @@ print_help (struct gcc_options *opts, unsigned int lang_mask, lang_mask); } +static bool +ignore_w_error(void) +{ + char *str; + + str = getenv("IGNORE_WERROR"); + if (str && strcmp(str, "1") == 0) + return true; + return false; +} + /* Handle target- and language-independent options. Return zero to generate an "unknown option" message. Only options that need extra handling need to be listed here; if you simply want @@ -2773,11 +2784,15 @@ common_handle_option (struct gcc_options *opts, break; case OPT_Werror: + if (ignore_w_error()) + break; dc->warning_as_error_requested = value; break; case OPT_Werror_: - if (lang_mask == CL_DRIVER) + if (ignore_w_error()) + break; + if (lang_mask == CL_DRIVER) break; enable_warning_as_error (arg, value, lang_mask, handlers,