From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 29566 invoked by alias); 19 Feb 2002 19:28:24 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 29382 invoked from network); 19 Feb 2002 19:28:18 -0000 Received: from unknown (HELO puce.csi.cam.ac.uk) (131.111.8.40) by sources.redhat.com with SMTP; 19 Feb 2002 19:28:18 -0000 Received: from student.cusu.cam.ac.uk ([131.111.179.82] helo=kern.srcf.societies.cam.ac.uk ident=mail) by puce.csi.cam.ac.uk with esmtp (Exim 3.34 #1) id 16dFvz-0001vK-00; Tue, 19 Feb 2002 19:28:15 +0000 Received: from gs234 by kern.srcf.societies.cam.ac.uk with local (Exim 3.12 #1 (Debian)) id 16dFvy-0005ro-00; Tue, 19 Feb 2002 19:28:14 +0000 To: Gerald Pfeifer Cc: gcc-patches@gcc.gnu.org Subject: Re: [PATCH] Fix documentation typos. References: Organization: The Church of Emacs X-Face: /o2;eGh9msH~a<|xh/*d@XD)bmdD]25b/b8 Date: Tue, 19 Feb 2002 13:07:00 -0000 Message-ID: <4apu31i84x.fsf@kern.srcf.societies.cam.ac.uk> User-Agent: Gnus/5.090006 (Oort Gnus v0.06) Emacs/21.1 (i586-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-SW-Source: 2002-02/txt/msg01321.txt.bz2 On Tue, 19 Feb 2002, pfeifer@dbai.tuwien.ac.at wrote: > On Tue, 19 Feb 2002, Gaute B Strokkenes wrote: >> This is a resend of: >> >> http://gcc.gnu.org/ml/gcc-patches/2002-01/msg00354.html >> http://gcc.gnu.org/ml/gcc-patches/2002-01/msg00495.html >> http://gcc.gnu.org/ml/gcc-patches/2002-01/msg02058.html >> >> It would be nice if anyone could have a look at this simple, 4-byte >> change sometime soon. > > It's really embarrassing that nobody has reviewed/committed this > yet, but perhaps it's because you haven't provided a ChangeLog > entry? Well, I don't really know how to make ChangeLog entries. Since I don't have my own computer, I didn't configure gcc and try make dvi or anything like that, even though according to the instructions I should have (but I did run makeinfo manually). It seemed a bit excessive to do all that just in order to notify the GCC maintainers of two very straightforward typos. In fact, I do not think I would have submitted a patch had it not been for the fact that describing the typos verbally would probably take more time and be less illuminating. > I created a ChangeLog entry and committed the rtl.texi patch with > a bit of reformatting to avoid overly long lines. Can someone else > please review the other part of the patch?! Basically, there are two functions f: A -> B and g: B -> A. The paragraph says that even though the composite fg: B -> B is the identity on B, the other composite gf: A -> A is _not_ the identity on A. The mistake is that one of the function names is misspelt: TYPE_INFO() rather than TYPE_BINFO(). I emulated your changelog entry and used M-q in emacs to reformat the paragraph: 2002-02-19 Gaute B Strokkenes * doc/c-tree.texi (Classes, TYPE_BINFO): Fix typo. Index: c-tree.texi =================================================================== RCS file: /cvsroot/gcc/gcc/gcc/doc/c-tree.texi,v retrieving revision 1.30 diff -u -r1.30 c-tree.texi --- c-tree.texi 19 Feb 2002 02:53:32 -0000 1.30 +++ c-tree.texi 19 Feb 2002 18:54:55 -0000 @@ -760,8 +760,8 @@ qualifiers. However, it is not always the case that @code{TYPE_BINFO (BINFO_TYPE (y))} is always the same binfo as @code{y}. The reason is that if @code{y} is a binfo representing a base-class @code{B} of a -derived class @code{D}, then @code{BINFO_TYPE (y)} will be @code{B}, and -@code{TYPE_INFO (BINFO_TYPE (y))} will be @code{B} as its own +derived class @code{D}, then @code{BINFO_TYPE (y)} will be @code{B}, +and @code{TYPE_BINFO (BINFO_TYPE (y))} will be @code{B} as its own base-class, rather than as a base-class of @code{D}. The @code{BINFO_BASETYPES} is a @code{TREE_VEC} (@pxref{Containers}). > 2002-02-19 Gaute B Strokkenes > > * doc/rtl.texi (Flags, MEM_SCALAR_P): Fix typo. Gee whiz, my name in big letters... ;-) -- Big Gaute http://www.srcf.ucam.org/~gs234/ Yow! I'm having a quadraphonic sensation of two winos alone in a steel mill!