public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Thomas Preudhomme <thomas.preudhomme@foss.arm.com>
To: Richard Biener <rguenther@suse.de>,
	Jakub Jelinek <jakub@redhat.com>,
	"gcc-patches@gcc.gnu.org" <gcc-patches@gcc.gnu.org>
Subject: [PATCH, contrib] Support multi-tool sum files in dg-cmp-results.sh
Date: Wed, 14 Jun 2017 12:30:00 -0000	[thread overview]
Message-ID: <4b5196b2-d2eb-b6b9-1b9e-79402d466b99@foss.arm.com> (raw)

Hi,

dg-cmp-results.sh contrib script is written to work with sum file for
a single tool only. It throws away the header including the first ===
line and everything starting from the following ===, assuming it is the
test result. This does not work well for sum files with results for
multiple tools.

This patch changes the logic to instead keep everything between "Running
target" line and the beginning of Summary line. Other existing filter
mechanism will ensure only FAIL, PASS, etc. lines are kept after that.

ChangeLog entry is as follow:

*** contrib/ChangeLog ***

2017-06-14  Thomas Preud'homme  <thomas.preudhomme@arm.com>

	* dg-cmp-results.sh: Keep test result lines rather than throwing
	header and summary to support sum files with multiple tools.

Tested successfully on sum file with single tool with similar results
and on sum file with multiple tools now showing a regression with patch
proposed in https://gcc.gnu.org/ml/gcc-patches/2017-06/msg00875.html

Is this ok for trunk?

Best regards,

Thomas

             reply	other threads:[~2017-06-14 12:30 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-06-14 12:30 Thomas Preudhomme [this message]
2017-06-15 16:15 ` Thomas Preudhomme
2017-06-19 10:44   ` Thomas Preudhomme
2017-06-19 12:28     ` Christophe Lyon
2017-06-19 15:55 ` Mike Stump
2017-06-20 15:31   ` Thomas Preudhomme
2017-06-20 15:50     ` Mike Stump

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4b5196b2-d2eb-b6b9-1b9e-79402d466b99@foss.arm.com \
    --to=thomas.preudhomme@foss.arm.com \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=jakub@redhat.com \
    --cc=rguenther@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).