From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ciao.gmane.io (ciao.gmane.io [116.202.254.214]) by sourceware.org (Postfix) with ESMTPS id E7A593858D33 for ; Tue, 17 Oct 2023 17:02:53 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org E7A593858D33 Authentication-Results: sourceware.org; dmarc=fail (p=none dis=none) header.from=gmx.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=m.gmane-mx.org ARC-Filter: OpenARC Filter v1.0.0 sourceware.org E7A593858D33 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=116.202.254.214 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1697562175; cv=none; b=xF8PFJuvTsz7iD67RXLVMss+RJUZ/f3NY//CipCbsDPXOOlC8fgJ/OE16T+ZeCDO+LrxeuTdE/4Opbb0EABFm6QLE+1gdZbMrZkg0C1DskAYJSgQoS3qN/ia6PDpYtkXQ6/H/Uve2SIbYcVnxa6e01WGR2dr44+9ReLb9+cxn1A= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1697562175; c=relaxed/simple; bh=UDnWsAUf7baT1tlZuWXZ3zVXogF89hsONSjliv3Bdzo=; h=To:From:Subject:Date:Message-ID:Mime-Version; b=S/Z5iMQwcIuLucNQ1UlsB4lv6vyULooWGppgAui+DljqzRCtfkmRZ9/l/ePxi2JD9gM9rEtmq9+gzDeIL/CcrlbFEKnB+2NfBu9eXToTtic55isu7VsEheddxkawgRxjedfs26sknAnsrnGlVIALeEGwxZfPENSxjLzDaMCI3M4= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from list by ciao.gmane.io with local (Exim 4.92) (envelope-from ) id 1qsnT2-0000Em-V2 for gcc-patches@gcc.gnu.org; Tue, 17 Oct 2023 19:02:52 +0200 X-Injected-Via-Gmane: http://gmane.org/ To: gcc-patches@gcc.gnu.org From: Harald Anlauf Subject: Re: [patch] fortran/intrinsic.texi: Improve SIGNAL intrinsic entry Date: Tue, 17 Oct 2023 19:02:48 +0200 Message-ID: <4b56e2ca-0af1-4747-a90a-0eac16c1b82e@gmx.de> References: <3f2d2471-dd94-4eb1-86b2-ae7ed439028b@gmx.de> <33a8ad77-3ef6-47e2-a6ad-6b480d21c141@codesourcery.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit User-Agent: Mozilla Thunderbird Content-Language: en-US In-Reply-To: <33a8ad77-3ef6-47e2-a6ad-6b480d21c141@codesourcery.com> Cc: fortran@gcc.gnu.org X-Spam-Status: No, score=-2.9 required=5.0 tests=BAYES_00,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS,KAM_DMARC_STATUS,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Tobias, your latest patch - which you already pushed - removes the intrinsic declaration of signal. This can lead to a user's confusion and undesired results when the code is compiled e.g. with -std=f2018, because call signal (10, 1) ! 10 = SIGUSR1 and 1 = SIG_IGN (on some systems) could be mapped to the wrong external instead of the libgfortran function _gfortran_signal_sub_int etc., or you could get other compile-time errors with the example code. I strongly recommend to restore the intrinsic declaration. Cheers, Harald Am 17.10.23 um 09:47 schrieb Tobias Burnus: > Hi Harald, > > On 16.10.23 20:31, Harald Anlauf wrote: >> Hi Tobias, >> >> Am 16.10.23 um 19:11 schrieb Tobias Burnus: >>> OK for mainline? >> >> I think the patch qualifies as obvious. >> >> While at it, you might consider removing the comment a few lines below >> the place you are changing, >> >> @c TODO: What should the interface of the handler be?  Does it take >> arguments? >> >> and enhance the given example by e.g.: > > Updated version attached – I will commit it later today, unless anyone > has follow-up suggestions before. > > Thanks for the suggestions, > > Tobias > ----------------- > Siemens Electronic Design Automation GmbH; Anschrift: Arnulfstraße 201, > 80634 München; Gesellschaft mit beschränkter Haftung; Geschäftsführer: > Thomas Heurung, Frank Thürauf; Sitz der Gesellschaft: München; > Registergericht München, HRB 106955 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mout.gmx.net (mout.gmx.net [212.227.15.18]) by sourceware.org (Postfix) with ESMTPS id EF7973858C52; Tue, 17 Oct 2023 17:02:53 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org EF7973858C52 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmx.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmx.de ARC-Filter: OpenARC Filter v1.0.0 sourceware.org EF7973858C52 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=212.227.15.18 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1697562175; cv=none; b=hW85gZIbH7HCtEU9GAIZkhDZxS1tG+KbRp0Go9BOC+QhwLvLYjqOWby+sI66UkgU9UkTrfr2jWwwgTGIL8XTryLvMuWVR7zd3oCFsx2OGIgT860Xd6RpdCjRkb3bXaw3UaUiOrNRP5fmwuAouhfTKCZxMaFDmPFkEmBwELwPdDQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1697562175; c=relaxed/simple; bh=tHb3beGf2V4a39V4lvGoelnpoMu0yxQkDNMK5YZiWXc=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=I+/lONLDi0XLt3dXnqA1v7Fj0hKno1mQmraJERd2FNsYyusQW/q1yLqxT5f1cEqddpcmfSEW8BgYNt5Jc4+zWwFVaejwAx3e7N4SY4sYhBNKYdzyXIHAXc/mBcafV7SHsXzvyY01d3A48E2wsMU+Dbkt8SqHbw/qcSlX5yvPEY8= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.de; s=s31663417; t=1697562169; x=1698166969; i=anlauf@gmx.de; bh=tHb3beGf2V4a39V4lvGoelnpoMu0yxQkDNMK5YZiWXc=; h=X-UI-Sender-Class:Date:Subject:To:References:From:In-Reply-To; b=fcDqzbwKAnCfbPDWqSIFno+GodpcuakXaaUcAqcxTzQ+JzFbpRoipNBrWmrXRsDG TJLRNQDymq/o65n65Kc1BNPkUngDRKZfmchrJKQO793iIKgpneSV2eRWmufctLcA4 vYFyU6/WdGrCVxfAK31iLGtF92MxyGM33Q3lCN/22Jro/AQicDoXNk6J7cgmQqJ8H pn9iirnWIuNj6VtMgVzkaBEJOMwWbYLyfOvOubRBK7AEZLPZAllJ75X1KjoakpqyR w6WFK0WqDmgGE/MNr3G/Wm9tKAd1cCvdvK/ZVloGFTtmaMFIX8GCFPuym/OrKQ5xJ j6sRevPKmyGKHOSMoA== X-UI-Sender-Class: 724b4f7f-cbec-4199-ad4e-598c01a50d3a Received: from [192.168.178.29] ([93.207.95.46]) by mail.gmx.net (mrgmx005 [212.227.17.190]) with ESMTPSA (Nemesis) id 1MwwZd-1rlQJe0WQF-00yOgw; Tue, 17 Oct 2023 19:02:49 +0200 Message-ID: <4b56e2ca-0af1-4747-a90a-0eac16c1b82e@gmx.de> Date: Tue, 17 Oct 2023 19:02:48 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [patch] fortran/intrinsic.texi: Improve SIGNAL intrinsic entry To: Tobias Burnus , gcc-patches , fortran Newsgroups: gmane.comp.gcc.patches,gmane.comp.gcc.fortran References: <3f2d2471-dd94-4eb1-86b2-ae7ed439028b@gmx.de> <33a8ad77-3ef6-47e2-a6ad-6b480d21c141@codesourcery.com> Content-Language: en-US From: Harald Anlauf In-Reply-To: <33a8ad77-3ef6-47e2-a6ad-6b480d21c141@codesourcery.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: quoted-printable X-Provags-ID: V03:K1:t8Pcl4b0RWRifdrHxoRP0EHMLYPHkgHwMF4fOxP+nCW8zAIftJB 0exXo/05JeW12NwEMG/81vzY3Ws5xrpvs4oStH8nFFSiezJhM8mJNl3QGCJNEs24AaW7vGI MRMuoznucbJcsVARom81c5Bfj4NMyUr3cIzxe5xEvaO/bjRaHwwDjDeFh34hSj4NkVcSUgi 80sIGu00Qa/JJHLvUXe5A== UI-OutboundReport: notjunk:1;M01:P0:tG6zoKCtRww=;ZIuUYeIHPlUyJGy7tKDGZNQT5cY 8Ml8a15REAa5oDygkuuNhSyExmoW6x+HaKwmNUEH9i2YOzk5gxMXT8h/3zUWkSPD5MYEyHuQK 3zrVD7Y+quhVPB8JLk5Ln7qKrnsiT46SqI0P2DpMDEZmCgm6WIRgMC+Rq8+e5V42FZV39PSm2 TBDmbULuZgBm9T5UVuWwOeKtltkPLVWtmxX+TKcht/cBepLTIUm+V/hf05EG1d7Cj/UJ1VCaJ N0fwedNtJjliTVR1phmpvZIx5zK9kIe9FKigyVWfXlbSqQ6VApzS9SBeLs+TKIFjDQXX5M02B 6jDXuMq55fhoQP9HD+S0nU2K+TGlzODD9vCI0B4uTXGhppoFMo4pZdaPLh0UK0xbTJaVRsUiO t/iFZrDfXAc2ievJq6fIZa8hHiCGw4dmota9hKwOLYddvv/7cC7/5UqqAQPub/BfhVNTVXDWo RWy3XkC/x02Detegk1M1SK+UG8i0ZxDskEy86K5r+zqrvIV0imwf/g8EtO+dIrUrRG7rIvVRu VIynvg5sPbLArWDIrY/z2gxsXp3IC8y94i5ZtkwM3oXcfeDQzr4VPW+MI2ECXIihrvsUqlwm2 xA3lpU1MTkkboOM3zbzO1+VIMhWywQL2+Wn85hwUJpYSXqzknwaNmfGPDUolT9sxgEE2tLrNl IxWYH8iwrzG6M3YkvprWrb1Oj47cB9ZkgEqjKWYLz4acNrnx0fYP//Y+ensKm+DTJQKmsOMUn BF70sjjOcjb3bl0jmjah+Df4teGQLCeBSRVMWP1Kt4YsPP9Qz4anI/ECUsg3DzVP2F4DY5v1S zKcNYyaKBHg5nahluzqhn2aJITquRi+UI66cIaPysiOK4dDN/6M9P9g6g3aG9FmNQERxnlE/h lNcvQAdSsObdgRKfzD3AD8nNYmmYY+MibHxf7dGCdyFyLF0MI3GoclWJ4H+DxLdwUVuPRyhnc ZzxzGsOKUdthZiq+nAtzGIvP/ZE= X-Spam-Status: No, score=-4.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Message-ID: <20231017170248.zEMpTdUc7dbBV5mxdrUWiCgZ7qA6bFdQKQdS7U_YmUo@z> Tobias, your latest patch - which you already pushed - removes the intrinsic declaration of signal. This can lead to a user's confusion and undesired results when the code is compiled e.g. with -std=3Df2018, because call signal (10, 1) ! 10 =3D SIGUSR1 and 1 =3D SIG_IGN (on some system= s) could be mapped to the wrong external instead of the libgfortran function _gfortran_signal_sub_int etc., or you could get other compile-time errors with the example code. I strongly recommend to restore the intrinsic declaration. Cheers, Harald Am 17.10.23 um 09:47 schrieb Tobias Burnus: > Hi Harald, > > On 16.10.23 20:31, Harald Anlauf wrote: >> Hi Tobias, >> >> Am 16.10.23 um 19:11 schrieb Tobias Burnus: >>> OK for mainline? >> >> I think the patch qualifies as obvious. >> >> While at it, you might consider removing the comment a few lines below >> the place you are changing, >> >> @c TODO: What should the interface of the handler be?=C2=A0 Does it tak= e >> arguments? >> >> and enhance the given example by e.g.: > > Updated version attached =E2=80=93 I will commit it later today, unless = anyone > has follow-up suggestions before. > > Thanks for the suggestions, > > Tobias > ----------------- > Siemens Electronic Design Automation GmbH; Anschrift: Arnulfstra=C3=9Fe = 201, > 80634 M=C3=BCnchen; Gesellschaft mit beschr=C3=A4nkter Haftung; Gesch=C3= =A4ftsf=C3=BChrer: > Thomas Heurung, Frank Th=C3=BCrauf; Sitz der Gesellschaft: M=C3=BCnchen; > Registergericht M=C3=BCnchen, HRB 106955