From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com [148.163.156.1]) by sourceware.org (Postfix) with ESMTPS id 095193983C58 for ; Tue, 27 Jul 2021 21:08:20 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 095193983C58 Received: from pps.filterd (m0098409.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.0.43/8.16.0.43) with SMTP id 16RL3mQA023026; Tue, 27 Jul 2021 17:08:20 -0400 Received: from ppma02wdc.us.ibm.com (aa.5b.37a9.ip4.static.sl-reverse.com [169.55.91.170]) by mx0a-001b2d01.pphosted.com with ESMTP id 3a2sepgnsb-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 27 Jul 2021 17:08:20 -0400 Received: from pps.filterd (ppma02wdc.us.ibm.com [127.0.0.1]) by ppma02wdc.us.ibm.com (8.16.1.2/8.16.1.2) with SMTP id 16RL231c031331; Tue, 27 Jul 2021 21:08:18 GMT Received: from b01cxnp23033.gho.pok.ibm.com (b01cxnp23033.gho.pok.ibm.com [9.57.198.28]) by ppma02wdc.us.ibm.com with ESMTP id 3a235kufuv-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 27 Jul 2021 21:08:18 +0000 Received: from b01ledav002.gho.pok.ibm.com (b01ledav002.gho.pok.ibm.com [9.57.199.107]) by b01cxnp23033.gho.pok.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 16RL8IdQ39387444 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 27 Jul 2021 21:08:18 GMT Received: from b01ledav002.gho.pok.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 09D21124439; Tue, 27 Jul 2021 21:08:18 +0000 (GMT) Received: from b01ledav002.gho.pok.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 046EA124452; Tue, 27 Jul 2021 21:08:17 +0000 (GMT) Received: from lexx (unknown [9.171.17.235]) by b01ledav002.gho.pok.ibm.com (Postfix) with ESMTP; Tue, 27 Jul 2021 21:08:16 +0000 (GMT) Message-ID: <4b66f4b3a0ed196d8c834d3a5ea91998679d1e24.camel@vnet.ibm.com> Subject: Re: [PATCH 50/55] rs6000: Update rs6000_builtin_decl From: will schmidt To: Bill Schmidt , gcc-patches@gcc.gnu.org Cc: segher@kernel.crashing.org Date: Tue, 27 Jul 2021 16:08:15 -0500 In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.28.5 (3.28.5-10.el7) Mime-Version: 1.0 Content-Transfer-Encoding: 7bit X-TM-AS-GCONF: 00 X-Proofpoint-ORIG-GUID: r9TyLil6ShuIgMyPufdUOBgo_PmuOLVh X-Proofpoint-GUID: r9TyLil6ShuIgMyPufdUOBgo_PmuOLVh X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.391, 18.0.790 definitions=2021-07-27_14:2021-07-27, 2021-07-27 signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 suspectscore=0 lowpriorityscore=0 malwarescore=0 clxscore=1015 adultscore=0 mlxlogscore=999 mlxscore=0 priorityscore=1501 spamscore=0 bulkscore=0 phishscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2107140000 definitions=main-2107270119 X-Spam-Status: No, score=-12.5 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 27 Jul 2021 21:08:22 -0000 On Thu, 2021-06-17 at 10:19 -0500, Bill Schmidt via Gcc-patches wrote: > 2021-03-05 Bill Schmidt > Hi, Description could be a bit longer. :-) (Even just a duplicate of the mail subject to fill the space would prob be fine.) > gcc/ > * config/rs6000/rs6000-call.c (rs6000_new_builtin_decl): New > function. > (rs6000_builtin_decl): Call it. > --- > gcc/config/rs6000/rs6000-call.c | 20 ++++++++++++++++++++ > 1 file changed, 20 insertions(+) > > diff --git a/gcc/config/rs6000/rs6000-call.c b/gcc/config/rs6000/rs6000-call.c > index 6b60f0852ef..54cf014ed23 100644 > --- a/gcc/config/rs6000/rs6000-call.c > +++ b/gcc/config/rs6000/rs6000-call.c > @@ -16258,11 +16258,31 @@ rs6000_init_builtins (void) > } > } > > +static tree > +rs6000_new_builtin_decl (unsigned code, bool initialize_p ATTRIBUTE_UNUSED) > +{ > + rs6000_gen_builtins fcode = (rs6000_gen_builtins) code; > + > + if (fcode >= RS6000_OVLD_MAX) > + return error_mark_node; > + > + if (!rs6000_new_builtin_is_supported_p (fcode)) > + { > + rs6000_invalid_new_builtin (fcode); > + return error_mark_node; > + } > + > + return rs6000_builtin_decls_x[code]; > +} > + > /* Returns the rs6000 builtin decl for CODE. */ > > tree > rs6000_builtin_decl (unsigned code, bool initialize_p ATTRIBUTE_UNUSED) > { > + if (new_builtins_are_live) > + return rs6000_new_builtin_decl (code, initialize_p); > + Ok, lgtm, thanks -Will > HOST_WIDE_INT fnmask; > > if (code >= RS6000_BUILTIN_COUNT)