From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr1-x434.google.com (mail-wr1-x434.google.com [IPv6:2a00:1450:4864:20::434]) by sourceware.org (Postfix) with ESMTPS id 967F43858D28 for ; Fri, 24 Mar 2023 17:45:54 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 967F43858D28 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-wr1-x434.google.com with SMTP id m2so2614734wrh.6 for ; Fri, 24 Mar 2023 10:45:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1679679953; h=in-reply-to:from:references:cc:to:content-language:subject :user-agent:mime-version:date:message-id:from:to:cc:subject:date :message-id:reply-to; bh=NCYZnA6wq9fF/8Hoc8aTiQNpoxWIwF/TZwJvDsOfSAQ=; b=SGPmToFGKZqfhoNeIZmVXlFihaGIhYnNsQZyv5uKwAzG3+yPqD0iOdhqE5Sn1eG5uz 3cvxZJ4OBybTOGGdstCWzLmzDVDASoBzY4Gobw6QW9BYUTcZFHeJeUcmAHt24HUyYfKV i5a48miF5wZRYV1xEwkCOaoNB4DskadYws2dc2jgZTZy840N51bgTXlBoRK/E+wyPI84 /2fDP95kLYq3SpoPWp9yyYoyqQXCCK7vAseua1wmhDmDB8PML1MlPjKm1ixcwQpd6xIR yMYk59bXR6KJ1WRjiCk+W07d33ZiK9vws8KV/GW86l+IYhtMkVc2sjaV5oKIjNLtGT/7 LY6Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1679679953; h=in-reply-to:from:references:cc:to:content-language:subject :user-agent:mime-version:date:message-id:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=NCYZnA6wq9fF/8Hoc8aTiQNpoxWIwF/TZwJvDsOfSAQ=; b=v7/4J53E2Ya2enSfesJ5LA5Fo/6h/N63QUSivTE33SwO6MDW6WOy0gg5j9GT/rQpre 9XTgTzOF4J24nM48lgCp/y1Ry03J19ynUKzvO9Oe3WMfCpNDLWGXI5VxUrkKKTsghO7Y ulV6HT0Y36v6ihUdJRj5kbmwlJRJ1NDWjhoeKUTPJLWkZRPj2LpFcGV1DF0P3r2Ms5J7 cHMTByZTNKahSr4SF5UamI2E8CP+t9YvnCnuKJGD8CbY1Rkk7peBZqyfvLPJhXVzFfES YEvBCQxSaX9gKKK1qtb6AV+DaUQir3Sb/LArH40HaXZCsvyo3xPi4MPszGkrz0gSENJX V9SQ== X-Gm-Message-State: AAQBX9d+gj8bDqZv2cKy6hxbHwwUixe7GQjO8OnBCbpoXCGW/M+pK5f8 Gx0UDx2eEEB6FXZz8lDO7Zw= X-Google-Smtp-Source: AKy350baCpmWA2jMZXC5bxkFKG7xzdvVTW0zQ/W1m9Qc/5+h80UHUj5zCy245WmFeVPZLbQ+9KBt7Q== X-Received: by 2002:a5d:4b44:0:b0:2cd:bc79:5444 with SMTP id w4-20020a5d4b44000000b002cdbc795444mr2831495wrs.2.1679679952934; Fri, 24 Mar 2023 10:45:52 -0700 (PDT) Received: from [192.168.0.160] ([170.253.51.134]) by smtp.gmail.com with ESMTPSA id a17-20020a5d5091000000b002c7b229b1basm18790954wrt.15.2023.03.24.10.45.51 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 24 Mar 2023 10:45:52 -0700 (PDT) Message-ID: <4ba61ffe-2322-728f-871f-930216b6a128@gmail.com> Date: Fri, 24 Mar 2023 18:45:44 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Subject: Re: [PATCH v2] C, ObjC: Add -Wunterminated-string-initialization Content-Language: en-US To: David Malcolm , gcc-patches@gcc.gnu.org Cc: Alejandro Colomar , Doug McIlroy , "G. Branden Robinson" , Ralph Corderoy , Dave Kemper , Larry McVoy , Andrew Pinski , Jonathan Wakely , Andrew Clayton , Martin Uecker References: <20230324133928.14753-1-alx@kernel.org> <7d57dcfbc21caa2c6d9ac1118f4f6a34a8fb341c.camel@redhat.com> From: Alejandro Colomar In-Reply-To: <7d57dcfbc21caa2c6d9ac1118f4f6a34a8fb341c.camel@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------ZYUG1WwMBDfthR2T7euAX5f6" X-Spam-Status: No, score=-4.0 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --------------ZYUG1WwMBDfthR2T7euAX5f6 Content-Type: multipart/mixed; boundary="------------ptYLBtOnCNiJ7juqMbw01Z2p"; protected-headers="v1" From: Alejandro Colomar To: David Malcolm , gcc-patches@gcc.gnu.org Cc: Alejandro Colomar , Doug McIlroy , "G. Branden Robinson" , Ralph Corderoy , Dave Kemper , Larry McVoy , Andrew Pinski , Jonathan Wakely , Andrew Clayton , Martin Uecker Message-ID: <4ba61ffe-2322-728f-871f-930216b6a128@gmail.com> Subject: Re: [PATCH v2] C, ObjC: Add -Wunterminated-string-initialization References: <20230324133928.14753-1-alx@kernel.org> <7d57dcfbc21caa2c6d9ac1118f4f6a34a8fb341c.camel@redhat.com> In-Reply-To: <7d57dcfbc21caa2c6d9ac1118f4f6a34a8fb341c.camel@redhat.com> --------------ptYLBtOnCNiJ7juqMbw01Z2p Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Hi David, On 3/24/23 15:53, David Malcolm wrote: > On Fri, 2023-03-24 at 14:39 +0100, Alejandro Colomar via Gcc-patches > wrote: >> Warn about the following: >> >> =C2=A0=C2=A0=C2=A0 char=C2=A0 s[3] =3D "foo"; >> [...] >> --- >> >> Hi, >=20 > Hi Alex, thanks for the patch. :) >=20 >> >> I sent v1 to the wrong list.=C2=A0 This time I've made sure to write t= o >> gcc-patches@. >=20 > Note that right now we're deep in bug-fixing/stabilization for GCC 13 > (and trunk is still tracking that effort), so your patch might be more > suitable for GCC 14. Sure, no problem. Do you have a "next" branch where you pick patches for after the release, or should I resend after the release? Is discussion of a patch reasonable now, or is it too much distracting from your stabilization efforts? >=20 >> >> v2 adds some draft of a test, as suggested by Martin.=C2=A0 However, I= >> don't >> know yet how to write those, so the test is just a draft.=C2=A0 But I = did >> test the feature, by compiling GCC and compiling some small program >> with >> it. >=20 > Unfortunately the answer to the question "how do I run just one > testcase in GCC's testsuite" is rather non-trivial; FWIW I've written > up some notes on working with the GCC testsuite here: > https://gcc-newbies-guide.readthedocs.io/en/latest/working-with-the-tes= tsuite.html Hmm, I'll try following that; thanks! Is there anything obvious that I might have missed, at first glance? >=20 > Hope this is helpful Yup. Thanks! > Dave Cheers, Alex --=20 GPG key fingerprint: A9348594CE31283A826FBDD8D57633D441E25BB5 --------------ptYLBtOnCNiJ7juqMbw01Z2p-- --------------ZYUG1WwMBDfthR2T7euAX5f6 Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature" -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEE6jqH8KTroDDkXfJAnowa+77/2zIFAmQd4cgACgkQnowa+77/ 2zIYJA/8Cz0+XDDOicu6V8uqg/4oSJJ7+mZLrvLFFi0XrQH7TPfh+7gVfqkRDHud wnbNWYjieovc+y/3+LpauBLMn0RUekjDrGX1CI+7RypjFLOzqoVuIscP4/MF52Os rkAxDGaPOVE2on93RoOASAv3Hwce3lvP7f5S7IflDy4xcfEhVyoPndN63mCUXmqP vUr8nXzaj89oqOQrukcn/I/Aq9DCyDeh474nC1HCjB2CT6tJsOSMESRE/MQXeMen MAc9xGpgEpD8bZgPKb3nZYkq1m4GGpEbguSMHK2AwK65VfPcyzKp4hJC+QCBG2KG kaxbRnFKdH/qmoh/H9HCkOzL5wynN29NdKVi5igVGoAGLj3x1Vk4CFTyYAy4wCs1 dwcBbiIGBCkiyuK+YMt0ovyLN7CxGRqnOWqNyjKUtDQ2+WcECppcTHKwNdPET9vt i0SVLMRZQ+2m03bwP8sfxvimGrrY0SRERR9qhGGqK82x8bwv3rBNE2YeAUoc2NYu iFGTHKJwGdq8HfaozvGwIsIJU/wFZcYhc3D3Qv/pR7YqPafSn9xKSCupJk2NpLAe CN7rPwf+T3156L5r30bwBrxrdpOV8dsIW7JUyap+liSF6rw4FxS2JFQ6hYC/miJi W2WTTlQKcDvzwmdhPfX+8go5XO9dTKTPR1AXA7OJvgOLoBvGR/w= =obca -----END PGP SIGNATURE----- --------------ZYUG1WwMBDfthR2T7euAX5f6--