From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx0b-001b2d01.pphosted.com (mx0b-001b2d01.pphosted.com [148.163.158.5]) by sourceware.org (Postfix) with ESMTPS id 0BD883858D32 for ; Mon, 29 Aug 2022 06:18:46 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 0BD883858D32 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=linux.ibm.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=linux.ibm.com Received: from pps.filterd (m0098417.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.17.1.5/8.17.1.5) with ESMTP id 27T64VHR009240; Mon, 29 Aug 2022 06:18:45 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=message-id : date : mime-version : subject : to : cc : references : from : in-reply-to : content-type : content-transfer-encoding; s=pp1; bh=CLtIKqioBH7T0msrbU6qWGl9G7Rp1dz96WLN7mMCJUw=; b=oiFMqjSGj5kyhYLD/J0k+Xczn9KU5DJiN9Giyrxj7sBda8L37RJu1MxDqzzsWxZYMyFz ztIR0jrr/JVol1g7a8s0NRB5sUBTqIhNeilhl6s0MirBLx1wCUFAbBSA52pG38M3VhBG Wgr38EJgvpNQ6qX0SahEaZBuV1nGWuxMFklHmjHCpwM3mfnR3+enLN87Om6p2PR0GnyQ HK+njH+gvkqpMVbPkoKFyFK/i9Ki/DrqLbiFWZK9uaXIAchtD9eDii+A0xX3WV1F/P9w 5++tgJBtTfvIt7SwTFtWx4bdiXll5iV5Fei1dnU5Uz//aty7rYsMQRck4WiRiWVjLITr HQ== Received: from pps.reinject (localhost [127.0.0.1]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3j8qva08ey-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 29 Aug 2022 06:18:45 +0000 Received: from m0098417.ppops.net (m0098417.ppops.net [127.0.0.1]) by pps.reinject (8.17.1.5/8.17.1.5) with ESMTP id 27T65eN6015050; Mon, 29 Aug 2022 06:18:44 GMT Received: from ppma04fra.de.ibm.com (6a.4a.5195.ip4.static.sl-reverse.com [149.81.74.106]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3j8qva08eh-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 29 Aug 2022 06:18:44 +0000 Received: from pps.filterd (ppma04fra.de.ibm.com [127.0.0.1]) by ppma04fra.de.ibm.com (8.16.1.2/8.16.1.2) with SMTP id 27T6FeTa026603; Mon, 29 Aug 2022 06:18:43 GMT Received: from b06cxnps3074.portsmouth.uk.ibm.com (d06relay09.portsmouth.uk.ibm.com [9.149.109.194]) by ppma04fra.de.ibm.com with ESMTP id 3j7aw99cje-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 29 Aug 2022 06:18:42 +0000 Received: from d06av22.portsmouth.uk.ibm.com (d06av22.portsmouth.uk.ibm.com [9.149.105.58]) by b06cxnps3074.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 27T6IdX526673504 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 29 Aug 2022 06:18:39 GMT Received: from d06av22.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 982984C04E; Mon, 29 Aug 2022 06:18:39 +0000 (GMT) Received: from d06av22.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id A4CDB4C040; Mon, 29 Aug 2022 06:18:37 +0000 (GMT) Received: from [9.197.231.116] (unknown [9.197.231.116]) by d06av22.portsmouth.uk.ibm.com (Postfix) with ESMTP; Mon, 29 Aug 2022 06:18:37 +0000 (GMT) Message-ID: <4be9cb39-93f4-1a42-bc7e-1c95a09be90f@linux.ibm.com> Date: Mon, 29 Aug 2022 14:18:36 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.6.1 Subject: Re: [PATCH, rs6000] Put dg-options ahead of target selector checks Content-Language: en-US To: HAO CHEN GUI Cc: Segher Boessenkool , David , Peter Bergner , gcc-patches References: <55b5d04e-fa0a-771a-0c7a-f7dfb114fc8c@linux.ibm.com> From: "Kewen.Lin" In-Reply-To: <55b5d04e-fa0a-771a-0c7a-f7dfb114fc8c@linux.ibm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-TM-AS-GCONF: 00 X-Proofpoint-ORIG-GUID: BMTTXPclYMTb9dTY-WOusY8beU8Rdu8G X-Proofpoint-GUID: ApSL1aqwfYvBEeKfrKOIINCcLou9pKAC X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205,Aquarius:18.0.895,Hydra:6.0.517,FMLib:17.11.122.1 definitions=2022-08-29_03,2022-08-25_01,2022-06-22_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 bulkscore=0 malwarescore=0 clxscore=1015 suspectscore=0 impostorscore=0 mlxscore=0 spamscore=0 mlxlogscore=999 phishscore=0 lowpriorityscore=0 adultscore=0 priorityscore=1501 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2207270000 definitions=main-2208290026 X-Spam-Status: No, score=-11.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_EF,GIT_PATCH_0,KAM_SHORT,NICE_REPLY_A,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Hi Haochen, on 2022/8/26 15:29, HAO CHEN GUI wrote: > Hi, > This patch changes the sequence of test directives for 3 cases. Originally, > these 3 cases got failed or unsupported on some platforms, as their target > selector checks depend on compiling options. Maybe it's good to say more in the commit log to make it more clear, like: those effective target has_arch_* adopt current_compiler_flags in their checks, dg-options sitting before the dg-require-effective-target will be appended to current_compiler_flags, but won't if it's after. So adjusting the location of dg-options to make it more robust, or something like that. :) > > Bootstrapped and tested on powerpc64-linux BE and LE with no regressions. > Is this okay for trunk? Any recommendations? Thanks a lot. > > Thanks > Gui Haochen > > ChangeLog > 2022-08-26 Haochen Gui > > rs6000: Change the sequence of test directives for some test cases. Put > dg-options ahead of target selector checks as the compiling options affect the > result of these checks. > > gcc/testsuite/ > * gcc.target/powerpc/pr92398.p9+.c: Put dg-options ahead of target > selector check. > * gcc.target/powerpc/pr92398.p9-.c: Likewise. > * gcc.target/powerpc/pr93453-1.c: Likewise. > > > patch.diff > diff --git a/gcc/testsuite/gcc.target/powerpc/pr92398.p9+.c b/gcc/testsuite/gcc.target/powerpc/pr92398.p9+.c > index 72dd1d9a274..4e4fad620e8 100644 > --- a/gcc/testsuite/gcc.target/powerpc/pr92398.p9+.c > +++ b/gcc/testsuite/gcc.target/powerpc/pr92398.p9+.c > @@ -1,6 +1,8 @@ > -/* { dg-do compile { target { lp64 && has_arch_pwr9 } } } */ > +/* { dg-do compile } */ > +/* { dg-options "-O2 -mdejagnu-cpu=power9 -mvsx" } */ Previously this only gets compiled if has_arch_pwr9, now it's tested always. I assumed that this change with "-mdejagnu-cpu=power9" is intentional, but it's unrelated to dg-options things, so maybe it's good to have one note for this in commit log. The others look good to me. BR, Kewen > +/* { dg-require-effective-target has_arch_ppc64 } */ > +/* { dg-require-effective-target int128 } */ > /* { dg-require-effective-target powerpc_vsx_ok } */ > -/* { dg-options "-O2 -mvsx" } */ > > /* { dg-final { scan-assembler-times {\mmtvsrdd\M} 1 } } */ > /* { dg-final { scan-assembler-times {\mxxlnor\M} 1 } } */ > diff --git a/gcc/testsuite/gcc.target/powerpc/pr92398.p9-.c b/gcc/testsuite/gcc.target/powerpc/pr92398.p9-.c > index bd7fa98af51..4e6a8c8cb8e 100644 > --- a/gcc/testsuite/gcc.target/powerpc/pr92398.p9-.c > +++ b/gcc/testsuite/gcc.target/powerpc/pr92398.p9-.c > @@ -1,6 +1,8 @@ > -/* { dg-do compile { target { lp64 && {! has_arch_pwr9} } } } */ > -/* { dg-require-effective-target powerpc_vsx_ok } */ > /* { dg-options "-O2 -mvsx" } */ > +/* { dg-do compile { target { ! has_arch_pwr9 } } } */ > +/* { dg-require-effective-target int128 } */ > +/* { dg-require-effective-target has_arch_ppc64 } */ > +/* { dg-require-effective-target powerpc_vsx_ok } */ > > /* { dg-final { scan-assembler-times {\mnot\M} 2 { xfail be } } } */ > /* { dg-final { scan-assembler-times {\mstd\M} 2 { xfail { { {! has_arch_pwr9} && has_arch_pwr8 } && be } } } } */ > diff --git a/gcc/testsuite/gcc.target/powerpc/pr93453-1.c b/gcc/testsuite/gcc.target/powerpc/pr93453-1.c > index b396458ba12..6f4d899c114 100644 > --- a/gcc/testsuite/gcc.target/powerpc/pr93453-1.c > +++ b/gcc/testsuite/gcc.target/powerpc/pr93453-1.c > @@ -1,5 +1,6 @@ > -/* { dg-do compile { target has_arch_ppc64 } } */ > +/* { dg-do compile } */ > /* { dg-options "-mdejagnu-cpu=power6 -O2" } */ > +/* { dg-require-effective-target has_arch_ppc64 } */ > > unsigned long load_byte_reverse (unsigned long *in) > { >