From: Jeff Law <jeffreyalaw@gmail.com>
To: Alexandre Oliva <oliva@adacore.com>
Cc: gcc-patches@gcc.gnu.org, zsojka@seznam.cz, wilson@gcc.gnu.org
Subject: Re: [PR103302] skip multi-word pre-move clobber during lra
Date: Wed, 8 Dec 2021 23:03:12 -0700 [thread overview]
Message-ID: <4bf89538-8c3c-59a7-378b-d02982e6a5ea@gmail.com> (raw)
In-Reply-To: <orpmq6773m.fsf@lxoliva.fsfla.org>
On 12/8/2021 9:08 PM, Alexandre Oliva wrote:
> On Dec 8, 2021, Jeff Law <jeffreyalaw@gmail.com> wrote:
>
>>> expr.c (emit_move_multi_word): Skip clobber during lra.
>> OK.
> I found a similar pattern of issuing clobbers for multi-word moves, but
> not when reload_in_progress, in expr.c:emit_move_complex_parts. I don't
> have a testcase, but I'm tempted to propose '!lra_in_progress &&' for it
> as well. Can you think of any reason not to?
The only reason I can think of is we're in stage3 :-) It'd be a lot
easier to green light that if we could trigger an issue.
>
>
> I also see lots of uses of reload_in_progress in machine-dependent code,
> and I suspect many cases involving enabling patterns or checking for
> legitimate addresses might benefit from the addition of lra_in_progress,
> but that's too many occurrences to try to make sense of :-(
Yea, very likely.
jeff
next prev parent reply other threads:[~2021-12-09 6:03 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-08 5:37 Alexandre Oliva
2021-12-08 23:12 ` Jeff Law
2021-12-09 2:25 ` Alexandre Oliva
2021-12-09 4:08 ` Alexandre Oliva
2021-12-09 6:03 ` Jeff Law [this message]
2021-12-15 8:22 ` Alexandre Oliva
2021-12-15 16:00 ` Jeff Law
2022-02-18 23:27 ` Alexandre Oliva
2022-02-21 7:13 ` Richard Biener
2022-02-23 22:39 ` Alexandre Oliva
2022-03-01 20:15 ` Alexandre Oliva
2022-03-02 12:25 ` Alexandre Oliva
2022-03-02 14:21 ` Vladimir Makarov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4bf89538-8c3c-59a7-378b-d02982e6a5ea@gmail.com \
--to=jeffreyalaw@gmail.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=oliva@adacore.com \
--cc=wilson@gcc.gnu.org \
--cc=zsojka@seznam.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).