From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pf1-x42e.google.com (mail-pf1-x42e.google.com [IPv6:2607:f8b0:4864:20::42e]) by sourceware.org (Postfix) with ESMTPS id CED343858C27; Thu, 9 Dec 2021 06:03:15 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org CED343858C27 Received: by mail-pf1-x42e.google.com with SMTP id z6so4458093pfe.7; Wed, 08 Dec 2021 22:03:15 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=H53gCkG7JecnN4WKE1Xx852RyT5BM56mcuoEa9hrZr4=; b=H7ruBJW9dQ77dQZAE7hyltRUuqiIwvMymmtfzdQcxwAeTv8ddcHtrt0z17iqigbeIn LljtkS1WzXaTExHDBvATIOaF9FwWvDGV1fNf7R/68AMWtINTqxLY893tEV7RTXJzKGnh 8CzcdaRqxIGukhJr+RUudKSPoAY62+eIKNYzVUgfirer4U5mqe250qp3MttpoJosG8qh jei4Zf7s5mWxFuOXHtwVWxuiiWSF1OKB7py5jZZAGG14d2ddZZ/wTUl2iOv+ckVzW8q9 FKLu+C0771v4ql9A9iQdJLQjJir0WGkmo6AG10Cu7QXjkFl5I/xRF0F13wht2tJwuZxJ KcoA== X-Gm-Message-State: AOAM530d68TFoq/oKPAN4uD8fMfnI5StHwPbQNcRa3B8YFIwAUGJBCtq ixV7vhBS+Gnjdv671AnZLg0= X-Google-Smtp-Source: ABdhPJy+ZqnuqRKWY4M/Fz08tqr/yzRefCUQQdPTBTX7cLGSMd7rOwVqSwKI8GkpdoBRhS/Q6k+ZlA== X-Received: by 2002:a62:4e0a:0:b0:4a0:4127:174b with SMTP id c10-20020a624e0a000000b004a04127174bmr10024277pfb.41.1639029794685; Wed, 08 Dec 2021 22:03:14 -0800 (PST) Received: from [192.168.1.15] (65-130-86-172.slkc.qwest.net. [65.130.86.172]) by smtp.gmail.com with ESMTPSA id j23sm4307263pgn.40.2021.12.08.22.03.13 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 08 Dec 2021 22:03:14 -0800 (PST) Message-ID: <4bf89538-8c3c-59a7-378b-d02982e6a5ea@gmail.com> Date: Wed, 8 Dec 2021 23:03:12 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.3.2 Subject: Re: [PR103302] skip multi-word pre-move clobber during lra Content-Language: en-US To: Alexandre Oliva Cc: gcc-patches@gcc.gnu.org, zsojka@seznam.cz, wilson@gcc.gnu.org References: <74d2af86-c1c4-0842-b319-09e76b3bf633@gmail.com> From: Jeff Law In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-3.9 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, NICE_REPLY_A, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 09 Dec 2021 06:03:17 -0000 On 12/8/2021 9:08 PM, Alexandre Oliva wrote: > On Dec 8, 2021, Jeff Law wrote: > >>> expr.c (emit_move_multi_word): Skip clobber during lra. >> OK. > I found a similar pattern of issuing clobbers for multi-word moves, but > not when reload_in_progress, in expr.c:emit_move_complex_parts. I don't > have a testcase, but I'm tempted to propose '!lra_in_progress &&' for it > as well. Can you think of any reason not to? The only reason I can think of is we're in stage3 :-)  It'd be a lot easier to green light that if we could trigger an issue. > > > I also see lots of uses of reload_in_progress in machine-dependent code, > and I suspect many cases involving enabling patterns or checking for > legitimate addresses might benefit from the addition of lra_in_progress, > but that's too many occurrences to try to make sense of :-( Yea, very likely. jeff