From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <SRS0=lOFA=7N=mentor.com=Andrew_Stubbs@sourceware.org>
Received: from esa3.mentor.iphmx.com (esa3.mentor.iphmx.com [68.232.137.180])
	by sourceware.org (Postfix) with ESMTPS id F236B3858C5F
	for <gcc-patches@gcc.gnu.org>; Tue, 21 Mar 2023 15:16:13 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org F236B3858C5F
Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=codesourcery.com
Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=mentor.com
X-IronPort-AV: E=Sophos;i="5.98,279,1673942400"; 
   d="scan'208";a="100845995"
Received: from orw-gwy-01-in.mentorg.com ([192.94.38.165])
  by esa3.mentor.iphmx.com with ESMTP; 21 Mar 2023 07:16:09 -0800
IronPort-SDR: egmT4OYdHnhs0uAcQBLP2ciR/jPZMGDY9xJFfxvsm6K/73jylLt4n+tFxxAvewo2CbHWQX72lS
 IBpDdrykac8PaS/ZkD/JuhxrGt1jZTyt9nw9rp6Et90wKEe5PORHbV2WahSIds1tjZOCp36NSz
 nugmXWSWKnvSRPAmcBLk4HGM3r2wUE3MPXjXISMG3yGBUWF7jiSgdTV9I5KIYVmG/ywpPtnEmf
 BJfHNNUZG9RQGv0o9yqz1EmC1foY8jtuvugQvzKl7SGcTAr0INyum+ryXmN11n5WSeqhL02iC2
 y1g=
Message-ID: <4c31ef19-cb67-e3d4-fb8a-4a7036e6aab8@codesourcery.com>
Date: Tue, 21 Mar 2023 15:16:04 +0000
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.9.0
Subject: Re: [PATCH] amdgcn: Add instruction patterns for vector operations on
 complex numbers
Content-Language: en-GB
To: Andrew Jenner <andrew@codesourcery.com>, GCC Patches
	<gcc-patches@gcc.gnu.org>
References: <b3ec97bf-eaa2-d472-3db8-74989015407e@codesourcery.com>
 <ce7d56c5-be6b-8c06-f8ca-8107439bf0a4@codesourcery.com>
 <5568381f-7705-d085-53c2-8cd28d010292@codesourcery.com>
From: Andrew Stubbs <ams@codesourcery.com>
In-Reply-To: <5568381f-7705-d085-53c2-8cd28d010292@codesourcery.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 8bit
X-Originating-IP: [137.202.0.90]
X-ClientProxiedBy: svr-ies-mbx-10.mgc.mentorg.com (139.181.222.10) To
 svr-ies-mbx-11.mgc.mentorg.com (139.181.222.11)
X-Spam-Status: No, score=-6.2 required=5.0 tests=BAYES_00,HEADER_FROM_DIFFERENT_DOMAINS,KAM_DMARC_STATUS,KAM_SHORT,NICE_REPLY_A,SPF_HELO_PASS,SPF_PASS,TXREP autolearn=no autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org
List-Id: <gcc-patches.gcc.gnu.org>

On 21/03/2023 13:35, Andrew Jenner wrote:
> I have updated this patch to incorporate the feedback from Andrew 
> Stubbs. Tested on CDNA2 GFX90a.
> 
> gcc/ChangeLog:
> 
>      * config/gcn/gcn-protos.h (gcn_expand_dpp_swap_pairs_insn)
>      (gcn_expand_dpp_distribute_even_insn)
>      (gcn_expand_dpp_distribute_odd_insn): Declare.
>      * config/gcn/gcn-valu.md (@dpp_swap_pairs<mode>)
>      (@dpp_distribute_even<mode>, @dpp_distribute_odd<mode>)
>      (cmul<conj_op><mode>3, cml<addsub_as><mode>4, vec_addsub<mode>3)
>      (cadd<rot><mode>3, vec_fmaddsub<mode>4, vec_fmsubadd<mode>4)
>      (fms<mode>4<exec>, fms<mode>4_negop2<exec>, fms<mode>4)
>      (fms<mode>4_negop2): New patterns.
>      * config/gcn/gcn.cc (gcn_expand_dpp_swap_pairs_insn)
>      (gcn_expand_dpp_distribute_even_insn)
>      (gcn_expand_dpp_distribute_odd_insn): New functions.
>      * config/gcn/gcn.md: Add entries to unspec enum.
> 
> gcc/testsuite/ChangeLog:
> 
>      * gcc.target/gcn/complex.c: New test.

OK.

Andrew