From: "Martin Liška" <mliska@suse.cz>
To: Indu Bhagat <indu.bhagat@oracle.com>, Martin Sebor <msebor@gmail.com>
Cc: gcc-patches@gcc.gnu.org
Subject: Re: [PATCH] PR86957
Date: Wed, 26 Sep 2018 09:23:00 -0000 [thread overview]
Message-ID: <4c627646-ad17-0642-994e-88eb2c258060@suse.cz> (raw)
In-Reply-To: <e568ce88-af88-7738-7908-12f33c2846fd@oracle.com>
On 9/24/18 9:21 PM, Indu Bhagat wrote:
> Done. Attached is updated patch.
Thanks for it, I tested that right now.
You have ACK, so please install the patch. Please do not forget
to install ChangeLog entry and I would include PR entry:
https://www.gnu.org/software/gcc/contribute.html
example can be seen here:
https://github.com/gcc-mirror/gcc/blob/089d1a5f4939282881c108e0d04d026bdd82f6c6/ChangeLog#L178
Martin
>
> Patch is tested on x86_64
>
> Thanks
>
>
> On 09/24/2018 09:37 AM, Martin Sebor wrote:
>> I would suggest to use the term "remove" or "delete" instead of
>> the informal "wipe out" when referring to removing files or their
>> contents.
>>
>> Martin
>
next prev parent reply other threads:[~2018-09-26 9:23 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-05 19:29 Indu Bhagat
2018-09-11 9:21 ` Martin Liška
2018-09-16 8:28 ` Indu Bhagat
[not found] ` <159a29c5-8f8b-4194-dbea-1c9bd414db3a@oracle.com>
2018-09-17 10:10 ` Martin Liška
2018-09-17 11:20 ` Jan Hubicka
2018-09-18 19:41 ` Indu Bhagat
2018-09-21 23:23 ` Indu Bhagat
2018-09-24 16:46 ` Martin Sebor
2018-09-24 19:16 ` Indu Bhagat
2018-09-26 9:23 ` Martin Liška [this message]
2018-09-27 10:02 ` Richard Biener
2018-09-27 10:15 ` Martin Liška
2018-09-27 13:13 ` Martin Liška
2018-09-27 14:58 ` Richard Biener
2018-12-05 11:33 ` Thomas Schwinge
2018-12-07 1:46 ` Indu Bhagat
2018-12-10 20:45 ` Indu Bhagat
2018-12-11 9:14 ` Thomas Schwinge
2018-12-04 15:33 ` [committed, testsuite] Fix PR88310 Iain Sandoe
2018-09-11 9:23 ` [PATCH] PR86957 Martin Liška
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4c627646-ad17-0642-994e-88eb2c258060@suse.cz \
--to=mliska@suse.cz \
--cc=gcc-patches@gcc.gnu.org \
--cc=indu.bhagat@oracle.com \
--cc=msebor@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).