public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
* Re: [GCC][PATCH][ARM] Set profile to M for Armv8.1-M
       [not found] <5e38566b.1c69fb81.5a748.8539SMTPIN_ADDED_MISSING@mx.google.com>
@ 2020-02-04 13:49 ` Christophe Lyon
  2020-02-06 16:38   ` Kyrill Tkachov
  0 siblings, 1 reply; 3+ messages in thread
From: Christophe Lyon @ 2020-02-04 13:49 UTC (permalink / raw)
  To: Mihail Ionescu; +Cc: gcc Patches, Richard Earnshaw, Kyrylo Tkachov

On Mon, 3 Feb 2020 at 18:20, Mihail Ionescu <mihail.ionescu@foss.arm.com> wrote:
>
> Hi,
>
> We noticed that the profile for armv8.1-m.main was not set in arm-cpus.in
> , which led to TARGET_ARM_ARCH_PROFILE and _ARM_ARCH_PROFILE not being
> defined properly.
>
>
>
> gcc/ChangeLog:
>
> 2020-02-03  Mihail Ionescu  <mihail.ionescu@arm.com>
>
>         * config/arm/arm-cpus.in: Set profile M
>         for armv8.1-m.main.
>
>
> Ok for trunk?
>
> Regards,
> Mihail
>
>
> ###############     Attachment also inlined for ease of reply    ###############
>
>
> diff --git a/gcc/config/arm/arm-cpus.in b/gcc/config/arm/arm-cpus.in
> index 1805b2b1cd8d6f65a967b4e3945257854a7e0fc1..96f584da325172bd1460251e2de0ad679589d312 100644
> --- a/gcc/config/arm/arm-cpus.in
> +++ b/gcc/config/arm/arm-cpus.in
> @@ -692,6 +692,7 @@ begin arch armv8.1-m.main
>   tune for cortex-m7
>   tune flags CO_PROC
>   base 8M_MAIN
> + profile M
>   isa ARMv8_1m_main
>  # fp => FPv5-sp-d16; fp.dp => FPv5-d16
>   option dsp add armv7em
>

I'm wondering whether this is obvious?
OTOH, what's the impact of missing this (or why didn't we notice the
problem via a failing testcase?)

Christophe

^ permalink raw reply	[flat|nested] 3+ messages in thread
* Re: [GCC][PATCH][ARM] Set profile to M for Armv8.1-M
  2020-02-04 13:49 ` [GCC][PATCH][ARM] Set profile to M for Armv8.1-M Christophe Lyon
@ 2020-02-06 16:38   ` Kyrill Tkachov
  0 siblings, 0 replies; 3+ messages in thread
From: Kyrill Tkachov @ 2020-02-06 16:38 UTC (permalink / raw)
  To: Christophe Lyon, Mihail Ionescu; +Cc: gcc Patches, Richard Earnshaw


On 2/4/20 1:49 PM, Christophe Lyon wrote:
> On Mon, 3 Feb 2020 at 18:20, Mihail Ionescu 
> <mihail.ionescu@foss.arm.com> wrote:
> >
> > Hi,
> >
> > We noticed that the profile for armv8.1-m.main was not set in 
> arm-cpus.in
> > , which led to TARGET_ARM_ARCH_PROFILE and _ARM_ARCH_PROFILE not being
> > defined properly.
> >
> >
> >
> > gcc/ChangeLog:
> >
> > 2020-02-03  Mihail Ionescu <mihail.ionescu@arm.com>
> >
> >         * config/arm/arm-cpus.in: Set profile M
> >         for armv8.1-m.main.
> >
> >
> > Ok for trunk?
> >
> > Regards,
> > Mihail
> >
> >
> > ###############     Attachment also inlined for ease of reply    
> ###############
> >
> >
> > diff --git a/gcc/config/arm/arm-cpus.in b/gcc/config/arm/arm-cpus.in
> > index 
> 1805b2b1cd8d6f65a967b4e3945257854a7e0fc1..96f584da325172bd1460251e2de0ad679589d312 
> 100644
> > --- a/gcc/config/arm/arm-cpus.in
> > +++ b/gcc/config/arm/arm-cpus.in
> > @@ -692,6 +692,7 @@ begin arch armv8.1-m.main
> >   tune for cortex-m7
> >   tune flags CO_PROC
> >   base 8M_MAIN
> > + profile M
> >   isa ARMv8_1m_main
> >  # fp => FPv5-sp-d16; fp.dp => FPv5-d16
> >   option dsp add armv7em
> >
>
> I'm wondering whether this is obvious?
> OTOH, what's the impact of missing this (or why didn't we notice the
> problem via a failing testcase?)

It's only used to set the __ARM_ARCH_PROFILE macro in arm-c.c

I do agree that the patch is obvious, so go ahead and commit this 
please, Mihail.

Thanks,

Kyrill



>
> Christophe

^ permalink raw reply	[flat|nested] 3+ messages in thread
* [GCC][PATCH][ARM] Set profile to M for Armv8.1-M
@ 2020-02-03 17:20 Mihail Ionescu
  0 siblings, 0 replies; 3+ messages in thread
From: Mihail Ionescu @ 2020-02-03 17:20 UTC (permalink / raw)
  To: gcc-patches; +Cc: Richard.Earnshaw, Kyrylo.Tkachov

[-- Attachment #1: Type: text/plain, Size: 853 bytes --]

Hi,

We noticed that the profile for armv8.1-m.main was not set in arm-cpus.in
, which led to TARGET_ARM_ARCH_PROFILE and _ARM_ARCH_PROFILE not being
defined properly.



gcc/ChangeLog:

2020-02-03  Mihail Ionescu  <mihail.ionescu@arm.com>

	* config/arm/arm-cpus.in: Set profile M
	for armv8.1-m.main.


Ok for trunk?

Regards,
Mihail


###############     Attachment also inlined for ease of reply    ###############


diff --git a/gcc/config/arm/arm-cpus.in b/gcc/config/arm/arm-cpus.in
index 1805b2b1cd8d6f65a967b4e3945257854a7e0fc1..96f584da325172bd1460251e2de0ad679589d312 100644
--- a/gcc/config/arm/arm-cpus.in
+++ b/gcc/config/arm/arm-cpus.in
@@ -692,6 +692,7 @@ begin arch armv8.1-m.main
  tune for cortex-m7
  tune flags CO_PROC
  base 8M_MAIN
+ profile M
  isa ARMv8_1m_main
 # fp => FPv5-sp-d16; fp.dp => FPv5-d16
  option dsp add armv7em


[-- Attachment #2: diff.patch --]
[-- Type: text/plain, Size: 432 bytes --]

diff --git a/gcc/config/arm/arm-cpus.in b/gcc/config/arm/arm-cpus.in
index 1805b2b1cd8d6f65a967b4e3945257854a7e0fc1..96f584da325172bd1460251e2de0ad679589d312 100644
--- a/gcc/config/arm/arm-cpus.in
+++ b/gcc/config/arm/arm-cpus.in
@@ -692,6 +692,7 @@ begin arch armv8.1-m.main
  tune for cortex-m7
  tune flags CO_PROC
  base 8M_MAIN
+ profile M
  isa ARMv8_1m_main
 # fp => FPv5-sp-d16; fp.dp => FPv5-d16
  option dsp add armv7em


^ permalink raw reply	[flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-02-06 16:38 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
     [not found] <5e38566b.1c69fb81.5a748.8539SMTPIN_ADDED_MISSING@mx.google.com>
2020-02-04 13:49 ` [GCC][PATCH][ARM] Set profile to M for Armv8.1-M Christophe Lyon
2020-02-06 16:38   ` Kyrill Tkachov
2020-02-03 17:20 Mihail Ionescu

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).