From: Jeff Law <jeffreyalaw@gmail.com>
To: Xi Ruoyao via Gcc-patches <gcc-patches@gcc.gnu.org>,
Jeff Law <law@redhat.com>, Jakub Jelinek <jakub@redhat.com>,
Xi Ruoyao <xry111@mengyan1223.wang>,
richard.sandiford@arm.com
Subject: Re: [PATCH] MIPS: Fix PR target/98491 (ChangeLog)
Date: Tue, 2 Mar 2021 16:16:42 -0700 [thread overview]
Message-ID: <4d0fde15-68e1-70f3-ff30-e05354fc70f3@gmail.com> (raw)
In-Reply-To: <mpt1rderjf4.fsf@arm.com>
On 2/17/21 5:02 AM, Richard Sandiford wrote:
> Xi Ruoyao via Gcc-patches <gcc-patches@gcc.gnu.org> writes:
>>>>>> I can't understand the comment either. To me it looks like it's
>>>>>> possible to
>>>>>> remove this "if (MSA_SUPPORTED_P (mode)) return 0;"
> I think the point is that the MSA loads and stores only have a 10-bit
> offset field instead of the usual 16-bit offset field and so the usual
> approaches to handling symbolic addresses won't work.
Ah.
>
>>>>>> CC Robert to get some help.
>>>>> Happy new lunar year folks.
>>>>>
>>>>> I found a newer email address of Robert. Hope it is still being used.
>>>>>
>>>>> Could someone update MAINTAINERS file by the way?
>>>> If you have an updated email address, I can reach out to Robert and see
>>>> if he wants his entry updated or removed.
>>> His latest reply in gcc mail lists used Robert.Suchanek@mips.com. But when I
>>> sent mail to it, the mail was just rejected with "access denied". Google told
>>> me Office 365 mail service (used by mips.com) rejects mail to deleted accounts
>>> with "access denied". So I'm not sure if this email address is invalid again,
>>> or
>>> Office 365 just dislikes me...
>> Hi Jeff,
>>
>> I think it's better to just fix the out-of-bound array access now by special
>> casing MAX_MACHINE_MODE, if we can't figure out if this entry should be removed.
>> Either in MSA_SUPPORTED_P or in mips_symbol_insns.
>>
>> It's really "irrational" to leave such a obvious programming error in new GCC 11
>> release... And I've built a Linux system (in Linux From Scratch way, X11 was
>> built and it runs correctly now) on the Loongson 3A4000 with patched GCC-10.2.0,
>> and "-O3 -mmsa" in CFLAGS for most packages so the change should be OK.
> Yeah, agreed. I think the mips_symbol_insns patch is the right one,
> so I've pushed to it trunk. I think it's also worth backporting
> to release branches, but let me know how far back you've tested it.
Seems reasonable to me. THanks for lending a hand on this Richard.
jeff
prev parent reply other threads:[~2021-03-02 23:16 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-31 23:29 [PATCH] MIPS: Fix PR target/98491 Xi Ruoyao
2020-12-31 23:34 ` [PATCH] MIPS: Fix PR target/98491 (ChangeLog) Xi Ruoyao
2021-01-04 20:51 ` Jeff Law
2021-01-04 21:00 ` Jakub Jelinek
2021-01-04 21:19 ` Jeff Law
2021-01-10 17:01 ` Xi Ruoyao
2021-01-10 17:04 ` Xi Ruoyao
2021-02-12 14:17 ` Xi Ruoyao
2021-02-12 14:54 ` Xi Ruoyao
2021-02-12 14:57 ` Xi Ruoyao
2021-02-12 15:15 ` Xi Ruoyao
2021-02-15 23:16 ` Jeff Law
2021-02-16 3:59 ` Xi Ruoyao
2021-02-17 11:13 ` Xi Ruoyao
2021-02-17 12:02 ` Richard Sandiford
2021-03-02 23:16 ` Jeff Law [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4d0fde15-68e1-70f3-ff30-e05354fc70f3@gmail.com \
--to=jeffreyalaw@gmail.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=jakub@redhat.com \
--cc=law@redhat.com \
--cc=richard.sandiford@arm.com \
--cc=xry111@mengyan1223.wang \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).